Age | Commit message (Collapse) | Author |
|
Now we have a Dispatcher and two ResponseHandlers that have the same interface.
Moving towards a Chain of Responsibility pattern.
|
|
This way we can separate the EmailHandler and the FingerprintHandler as well.
|
|
The original idea was that we would have all the celluloid related things
injected in reel_server. However it seems unlikely that we will use a
different http system anytime soon.
Removing some layers of dependency injection to reduce complexity. We
can easily bring this back if we want.
|
|
|
|
We have a specific way of encoding the thing we are looking for in the
request. I added a small helper class to access the fingerprint and
email.
This also cleans up the RequestHandler code to some extend.
|
|
These warnings were showing on gitlab ci.
$ bundle exec rake test
/usr/local/bin/ruby -w -Ilib:test -I/builds/leap/nickserver/vendor/ruby/2.1.0/gems/rake-11.2.2/lib /builds/leap/nickserver/vendor/ruby/2.1.0/gems/rake-11.2.2/lib/rake/rake_test_loader.rb test/**/*_test.rb
/usr/local/lib/ruby/gems/2.1.0/gems/bundler-1.12.5/lib/bundler/rubygems_integration.rb:468: warning: method redefined; discarding old find_spec_for_exe
/usr/local/lib/ruby/site_ruby/2.1.0/rubygems.rb:261: warning: previous definition of find_spec_for_exe was here
I, [2016-08-26T15:34:46.162843 #325] INFO -- : Celluloid 0.17.3 is running in BACKPORTED mode. [ http://git.io/vJf3J ]
/builds/leap/nickserver/test/unit/request_handler_test.rb:28: warning: mismatched indentations at 'end' with 'def' at 21
/builds/leap/nickserver/vendor/ruby/2.1.0/gems/celluloid-io-0.17.3/lib/celluloid/io/ssl_socket.rb:22: warning: instance variable @npn_protocols not initialized
/builds/leap/nickserver/vendor/ruby/2.1.0/gems/celluloid-io-0.17.3/lib/celluloid/io/ssl_socket.rb:22: warning: instance variable @npn_select_cb not initialized
Run options: --seed 61653
# Running:
.................../builds/leap/nickserver/vendor/ruby/2.1.0/gems/celluloid-io-0.17.3/lib/celluloid/io/ssl_socket.rb:22: warning: instance variable @npn_protocols not initialized
/builds/leap/nickserver/vendor/ruby/2.1.0/gems/celluloid-io-0.17.3/lib/celluloid/io/ssl_socket.rb:22: warning: instance variable @npn_select_cb not initialized
.../builds/leap/nickserver/vendor/ruby/2.1.0/gems/celluloid-io-0.17.3/lib/celluloid/io/ssl_socket.rb:22: warning: instance variable @npn_protocols not initialized
/builds/leap/nickserver/vendor/ruby/2.1.0/gems/celluloid-io-0.17.3/lib/celluloid/io/ssl_socket.rb:22: warning: instance variable @npn_select_cb not initialized
.................
Finished in 2.029982s, 19.2120 runs/s, 10.8375 assertions/s.
|
|
- add fingerprint unit tests
- add integration test
- implement by_fingerprint
|
|
in order to get key by fp as well
|
|
I have to admit I don't completely understand what is going on here.
https://github.com/celluloid/celluloid/wiki/Frequently-Asked-Questions says
you can either use sleep after initiating the actors or call run on them.
But this might not be true for reel. At least run did not work and now
new; sleep seems to work fine.
|
|
|
|
This became possible because we now use celluloid.
Celluloid handles asynchronity without the need for callbacks
or blocks.
|
|
|
|
|
|
|
|
|
|
some tests are still broken. But at least they are running now.
|
|
Main problem right now is the outdated version of webmock.
|
|
This way the interface mimics the one of Celluloid Reels request.
request.respond status, content
|
|
The request handler takes a responder (the EmServer) and an adapter as initialization arguments.
It will then respond to requests by querying the sources using the adapter and calling send_response on the responder.
|
|
|
|
|
|
|
|
wraps the hkp protocol
|
|
|
|
|
|
The source was really just an empty shell now that we pushed the
em specific stuff further down.
|
|
|
|
|
|
|
|
well kind of since we were yielding this is more inlining the
block and renaming the method
|
|
|
|
This moves all the em_http related stuff into a single adapter.
We're also not using callback and errback inside fetch_key or
server for couch requests anymore.
Changing the interface for hkp to do the same will follow.
|
|
|
|
|
|
|
|
|
|
I started a nickserver from scratch to implement the things that are independent of our choice of stack (eventmachine or other).
This commit copies them over and tests both things in parallel.
|
|
|
|
|
|
|
|
Only parse responses that have status code 200 (OK).
Simplify status code handling a bit
Also profiled it to see if duplicate calculations matter.
They don't (2ms for validating 12 keys)
|
|
|
|
I also separated the parsing of the hkp response from
FetchKeyInfo.
This way FetchKeyInfo has the EM specific code that has
sideeffects and the logic is in a class without sideeffects
and (almost) without state.
The only state we keep is the KeyInfo array that contains
all the information the server returns. This way we avoid
parsing the response multiple times.
|
|
|
|
https://leap.se/code/issues/3526
|
|
|
|
permissions anyway.
|
|
|
|
|
|
|