<feed xmlns='http://www.w3.org/2005/Atom'>
<title>nickserver.git/lib/nickserver/hkp, branch master</title>
<subtitle>[nickserver] 
</subtitle>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/'/>
<entry>
<title>refactor: turn Hkp::Response into KeyResponse</title>
<updated>2017-11-04T07:30:08+00:00</updated>
<author>
<name>Azul</name>
<email>azul@riseup.net</email>
</author>
<published>2017-11-04T07:30:08+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/commit/?id=85a567286cf61a3a8193c339dd0967116d79299c'/>
<id>85a567286cf61a3a8193c339dd0967116d79299c</id>
<content type='text'>
We now also use it from wkd and it seems like a generally
useful kind of response.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We now also use it from wkd and it seems like a generally
useful kind of response.
</pre>
</div>
</content>
</entry>
<entry>
<title>fix: no expiration date means not outdated</title>
<updated>2017-11-03T13:33:51+00:00</updated>
<author>
<name>Azul</name>
<email>azul@riseup.net</email>
</author>
<published>2017-11-03T13:33:51+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/commit/?id=ec996134a1f23ee36aff9d3ad2c800af71623207'/>
<id>ec996134a1f23ee36aff9d3ad2c800af71623207</id>
<content type='text'>
We were using Time.at(expirationdate) even if it was nil which
led to using the Time.at(0). Instead an unset expirationdate
is meant to not expire the key at all.

Our tests did not catch this because the assertions were in
blocks that did not get run at all. (at least in the HKP
integration test).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We were using Time.at(expirationdate) even if it was nil which
led to using the Time.at(0). Instead an unset expirationdate
is meant to not expire the key at all.

Our tests did not catch this because the assertions were in
blocks that did not get run at all. (at least in the HKP
integration test).
</pre>
</div>
</content>
</entry>
<entry>
<title>style: avoid endless elsif in KeyInfo#error</title>
<updated>2017-09-23T14:53:27+00:00</updated>
<author>
<name>Azul</name>
<email>azul@riseup.net</email>
</author>
<published>2017-09-23T13:41:56+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/commit/?id=8ac6bb8492c9a3b9ec5d7b5bf2b35907a1f8c332'/>
<id>8ac6bb8492c9a3b9ec5d7b5bf2b35907a1f8c332</id>
<content type='text'>
using an array of symbols representing the different checks now.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
using an array of symbols representing the different checks now.
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: move error detection into key_info</title>
<updated>2017-09-23T14:53:27+00:00</updated>
<author>
<name>Azul</name>
<email>azul@riseup.net</email>
</author>
<published>2017-09-23T13:10:11+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/commit/?id=b2543051d0629ab11adae1a64a1aed2105a1b9d9'/>
<id>b2543051d0629ab11adae1a64a1aed2105a1b9d9</id>
<content type='text'>
Still needs something better than all these elsifs though
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Still needs something better than all these elsifs though
</pre>
</div>
</content>
</entry>
<entry>
<title>style: more rubocop fixes</title>
<updated>2017-09-23T14:53:27+00:00</updated>
<author>
<name>Azul</name>
<email>azul@riseup.net</email>
</author>
<published>2017-09-23T11:43:29+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/commit/?id=f40ef14010af08c49810c0a6a2349072948170e6'/>
<id>f40ef14010af08c49810c0a6a2349072948170e6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>style: rubocop mostly auto-correct</title>
<updated>2017-09-23T14:53:27+00:00</updated>
<author>
<name>Azul</name>
<email>azul@riseup.net</email>
</author>
<published>2017-09-23T09:07:32+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/commit/?id=40916407517f4bdb75a295caf29e02d4f403349b'/>
<id>40916407517f4bdb75a295caf29e02d4f403349b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>return nil on 404 in hkp source</title>
<updated>2016-09-22T10:27:53+00:00</updated>
<author>
<name>Azul</name>
<email>azul@riseup.net</email>
</author>
<published>2016-09-22T10:27:53+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/commit/?id=68ffe9928620d3e5e3b96152ed4d37da90f6a89b'/>
<id>68ffe9928620d3e5e3b96152ed4d37da90f6a89b</id>
<content type='text'>
This way the other RequestHandlers can give it a try.
If none handles it we'll get a 404 anyway. But maybe there's
been an exception before so a 502 should be send.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This way the other RequestHandlers can give it a try.
If none handles it we'll get a 404 anyway. But maybe there's
been an exception before so a 502 should be send.
</pre>
</div>
</content>
</entry>
<entry>
<title>[FEATURE] fetch key by fingerprint</title>
<updated>2016-07-13T18:35:55+00:00</updated>
<author>
<name>Zara Gebru</name>
<email>zgebru@thoughtworks.com</email>
</author>
<published>2016-07-13T18:20:52+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/commit/?id=59263baee9fc04524c8a69af1f7293fa4315d3ff'/>
<id>59263baee9fc04524c8a69af1f7293fa4315d3ff</id>
<content type='text'>
- add fingerprint unit tests
- add integration test
- implement by_fingerprint
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- add fingerprint unit tests
- add integration test
- implement by_fingerprint
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: turn EmailAddress into a class, cleanup</title>
<updated>2016-07-02T11:26:43+00:00</updated>
<author>
<name>Azul</name>
<email>azul@riseup.net</email>
</author>
<published>2016-07-02T11:16:35+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/commit/?id=e81c1a8cf274a13903be00c74c975c0cb2c20995'/>
<id>e81c1a8cf274a13903be00c74c975c0cb2c20995</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>refactor: replace blocks/yields with returns</title>
<updated>2016-07-02T10:03:46+00:00</updated>
<author>
<name>Azul</name>
<email>azul@riseup.net</email>
</author>
<published>2016-07-02T10:03:46+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/nickserver.git/commit/?id=fb2d7e6f8f1fceefbc8964d34369a867eb8f25bb'/>
<id>fb2d7e6f8f1fceefbc8964d34369a867eb8f25bb</id>
<content type='text'>
This became possible because we now use celluloid.
Celluloid handles asynchronity without the need for callbacks
or blocks.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This became possible because we now use celluloid.
Celluloid handles asynchronity without the need for callbacks
or blocks.
</pre>
</div>
</content>
</entry>
</feed>
