1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
|
require 'test_helper'
class TicketsControllerTest < ActionController::TestCase
setup do
User.create(User.valid_attributes_hash.merge({:login => 'first_test'}))
User.create(User.valid_attributes_hash.merge({:login => 'different'}))
end
teardown do
User.find_by_login('first_test').destroy
User.find_by_login('different').destroy
end
test "should get index if logged in" do
login(User.last)
get :index
assert_response :success
assert_not_nil assigns(:tickets)
end
test "should get new" do
get :new
assert_equal Ticket, assigns(:ticket).class
assert_response :success
end
test "ticket show access" do
ticket = Ticket.first
ticket.created_by = nil # TODO: hacky, but this makes sure this ticket is an unauthenticated one
ticket.save
get :show, :id => ticket.id
assert_response :success
ticket.created_by = User.last.id
ticket.save
get :show, :id => ticket.id
assert_response :redirect
assert_redirected_to login_url
login(User.last)
get :show, :id => ticket.id
assert_response :success
login(User.first) #assumes User.first != User.last:
assert_not_equal User.first, User.last
get :show, :id => ticket.id
assert_response :redirect
assert_redirected_to root_url
end
test "should create unauthenticated ticket" do
params = {:title => "unauth ticket test title", :comments_attributes => {"0" => {"body" =>"body of test ticket"}}}
assert_difference('Ticket.count') do
post :create, :ticket => params
end
assert_response :redirect
assert_nil assigns(:ticket).created_by
assert_equal 1, assigns(:ticket).comments.count
assert_nil assigns(:ticket).comments.first.posted_by
assigns(:ticket).destroy # destroys without checking permission. is that okay?
end
test "should create authenticated ticket" do
params = {:title => "auth ticket test title", :comments_attributes => {"0" => {"body" =>"body of test ticket"}}}
login User.last
assert_difference('Ticket.count') do
post :create, :ticket => params
end
assert_response :redirect
assert_not_nil assigns(:ticket).created_by
assert_equal assigns(:ticket).created_by, @current_user.id
assert_equal assigns(:ticket).email, @current_user.email
assert_equal 1, assigns(:ticket).comments.count
assert_not_nil assigns(:ticket).comments.first.posted_by
assert_equal assigns(:ticket).comments.first.posted_by, @current_user.id
assigns(:ticket).destroy
end
test "add comment to unauthenticated ticket" do
ticket = Ticket.last
ticket.created_by = nil # TODO: hacky, but this makes sure this ticket is an unauthenticated one
ticket.save
assert_difference('Ticket.last.comments.count') do
put :update, :id => ticket.id,
:ticket => {:comments_attributes => {"0" => {"body" =>"NEWER comment"}} }
end
assert_equal ticket, assigns(:ticket) # still same ticket, with different comments
assert_not_equal ticket.comments, assigns(:ticket).comments # ticket == assigns(:ticket), but they have different comments (which we want)
end
test "add comment to own authenticated ticket" do
login(User.last)
ticket = Ticket.last
ticket.created_by = User.last.id # TODO: hacky, but confirms it is their ticket
ticket.save
#they should be able to comment if it is their ticket:
assert_difference('Ticket.last.comments.count') do
put :update, :id => ticket.id,
:ticket => {:comments_attributes => {"0" => {"body" =>"NEWER comment"}} }
end
assert_not_equal ticket.comments, assigns(:ticket).comments
assert_not_nil assigns(:ticket).comments.last.posted_by
assert_equal assigns(:ticket).comments.last.posted_by, @current_user.id
end
test "cannot comment if it is not your ticket" do
login :is_admin? => false, :email => nil
ticket = Ticket.first
assert_not_nil User.first.id
ticket.created_by = User.first.id
ticket.save
# they should *not* be able to comment if it is not their ticket
put :update, :id => ticket.id, :ticket => {:comments_attributes => {"0" => {"body" =>"TEST NEWER comment"}} }
assert_response :redirect
assert_access_denied
assert_equal ticket.comments, assigns(:ticket).comments
end
test "admin add comment to authenticated ticket" do
login :is_admin? => true
ticket = Ticket.last
assert_not_nil User.last.id
ticket.created_by = User.last.id # TODO: hacky, but confirms it somebody elses ticket. assumes last user is not admin user:
assert_not_equal User.last.id, @current_user.id
ticket.save
#admin should be able to comment:
assert_difference('Ticket.last.comments.count') do
put :update, :id => ticket.id,
:ticket => {:comments_attributes => {"0" => {"body" =>"NEWER comment"}} }
end
assert_not_equal ticket.comments, assigns(:ticket).comments
assert_not_nil assigns(:ticket).comments.last.posted_by
assert_equal assigns(:ticket).comments.last.posted_by, @current_user.id
end
test "tickets by admin" do
login :is_admin? => true, :email => nil
post :create, :ticket => {:title => "test tick", :comments_attributes => {"0" => {"body" =>"body of test tick"}}}
post :create, :ticket => {:title => "another test tick", :comments_attributes => {"0" => {"body" =>"body of another test tick"}}}
assert_not_nil assigns(:ticket).created_by
assert_equal assigns(:ticket).created_by, @current_user.id
get :index, {:admin_status => "mine", :open_status => "open"}
assert assigns(:all_tickets).count > 1 # at least 2 tickets
# if we close one ticket, the admin should have 1 less open ticket they admin
assert_difference('assigns[:all_tickets].all.count', -1) do #not clear why do we need .all
assigns(:tickets).all.first.close
assigns(:tickets).all.first.save
get :index, {:admin_status => "mine", :open_status => "open"}
end
testticket = Ticket.create :title => 'testytest'
assert !assigns(:all_tickets).all.include?(testticket)
# admin should have one more ticket if a new tick gets an admin comment
assert_difference('assigns[:all_tickets].all.count') do
put :update, :id => testticket.id, :ticket => {:comments_attributes => {"0" => {"body" =>"NEWER comment"}}}
get :index, {:admin_status => "mine", :open_status => "open"}
end
assert assigns(:all_tickets).all.include?(assigns(:ticket))
assert_not_nil assigns(:ticket).comments.last.posted_by
assert_equal assigns(:ticket).comments.last.posted_by, @current_user.id
assigns(:ticket).destroy
# test ordering
get :index, {:admin_status => "mine", :open_status => "open", :sort_order => 'created_at_desc'}
first_tick = assigns(:all_tickets).all.first
last_tick = assigns(:all_tickets).all.last
# and now reverse order:
get :index, {:admin_status => "mine", :open_status => "open", :sort_order => 'created_at_asc'}
assert_equal first_tick, assigns(:all_tickets).all.last
assert_equal last_tick, assigns(:all_tickets).all.first
assert_not_equal first_tick, assigns(:all_tickets).all.first
assert_not_equal last_tick, assigns(:all_tickets).all.last
end
end
|
