From beacb663226085a77ce03a6dda70e8b135d2e8c7 Mon Sep 17 00:00:00 2001 From: jessib Date: Thu, 13 Jun 2013 14:29:15 -0700 Subject: Quick way to give warnings if javascript and/or cookies are not enabled. Will want to tweak so the code isn't redundant, and ideally so check for cookies doesn't rely on javascript. And we'll want to expand the texts. --- users/app/views/sessions/new.html.haml | 15 +++++++++++++-- users/app/views/users/new.html.haml | 11 +++++++++++ users/config/locales/en.yml | 2 ++ 3 files changed, 26 insertions(+), 2 deletions(-) (limited to 'users') diff --git a/users/app/views/sessions/new.html.haml b/users/app/views/sessions/new.html.haml index a04f584..20705b9 100644 --- a/users/app/views/sessions/new.html.haml +++ b/users/app/views/sessions/new.html.haml @@ -1,8 +1,19 @@ .span8.offset2 + %noscript.alert.alert-error=t :js_required + #cookie_warning.alert.alert-error{:display => 'none'} + =t :cookie_disabled_warning + :javascript + document.cookie = "testing=cookies_enabled; path=/"; + if(document.cookie.indexOf("testing=cookies_enabled") < 0) + { + document.getElementById('cookie_warning').style.display = 'block'; + } else { + document.getElementById('cookie_warning').style.display = 'none'; + } %h2=t :login = simple_form_for @session, :validate => true, :html => { :id => :new_session, :class => 'form-horizontal' } do |f| %legend=t :login_message = f.input :login, :input_html => { :id => :srp_username } = f.input :password, :required => true, :input_html => { :id => :srp_password } - = f.button :submit, :value => t(:login), :class => 'btn-primary' - = link_to t(:cancel), root_url, :class => :btn + = f.button :submit, :value => t(:login), :class => 'btn-primary' + = link_to t(:cancel), root_url, :class => :btn \ No newline at end of file diff --git a/users/app/views/users/new.html.haml b/users/app/views/users/new.html.haml index 98cccb0..709289e 100644 --- a/users/app/views/users/new.html.haml +++ b/users/app/views/users/new.html.haml @@ -1,4 +1,15 @@ .span8.offset2 + %noscript.alert.alert-error=t :js_required + #cookie_warning.alert.alert-error{:display => 'none'} + =t :cookie_disabled_warning + :javascript + document.cookie = "testing=cookies_enabled; path=/"; + if(document.cookie.indexOf("testing=cookies_enabled") < 0) + { + document.getElementById('cookie_warning').style.display = 'block'; + } else { + document.getElementById('cookie_warning').style.display = 'none'; + } %h2=t :signup = user_form do |f| %legend= t(:signup_message) diff --git a/users/config/locales/en.yml b/users/config/locales/en.yml index 2077858..dded88c 100644 --- a/users/config/locales/en.yml +++ b/users/config/locales/en.yml @@ -22,6 +22,8 @@ en: use_ascii_key: "Use ASCII-armored PGP key" can_retype_old_password: "Retype your old password if you would like to keep that" associated_email: "The associated email address is" + cookie_disabled_warning: "You have cookies disabled. You will not be able to login until you enable cookies." + js_required: "We are sorry, but this doesn't work without javascript enabled. This is for security reasons." activemodel: models: -- cgit v1.2.3 From 11c4155aff42fe3f8bbce858bc87cdb6a91f67a2 Mon Sep 17 00:00:00 2001 From: jessib Date: Mon, 17 Jun 2013 11:33:56 -0700 Subject: Tweaks to display javascript and cookies warning: * will only display cookies warning if javascript is enabled. * remove redundant code * tweak noscript html to display better div --- users/app/views/sessions/new.html.haml | 12 +----------- users/app/views/users/_warnings.html.haml | 12 ++++++++++++ users/app/views/users/new.html.haml | 12 +----------- 3 files changed, 14 insertions(+), 22 deletions(-) create mode 100644 users/app/views/users/_warnings.html.haml (limited to 'users') diff --git a/users/app/views/sessions/new.html.haml b/users/app/views/sessions/new.html.haml index 20705b9..6743407 100644 --- a/users/app/views/sessions/new.html.haml +++ b/users/app/views/sessions/new.html.haml @@ -1,15 +1,5 @@ .span8.offset2 - %noscript.alert.alert-error=t :js_required - #cookie_warning.alert.alert-error{:display => 'none'} - =t :cookie_disabled_warning - :javascript - document.cookie = "testing=cookies_enabled; path=/"; - if(document.cookie.indexOf("testing=cookies_enabled") < 0) - { - document.getElementById('cookie_warning').style.display = 'block'; - } else { - document.getElementById('cookie_warning').style.display = 'none'; - } + = render :partial => 'users/warnings' %h2=t :login = simple_form_for @session, :validate => true, :html => { :id => :new_session, :class => 'form-horizontal' } do |f| %legend=t :login_message diff --git a/users/app/views/users/_warnings.html.haml b/users/app/views/users/_warnings.html.haml new file mode 100644 index 0000000..7e0b2ce --- /dev/null +++ b/users/app/views/users/_warnings.html.haml @@ -0,0 +1,12 @@ +%noscript + %div.alert.alert-error=t :js_required +#cookie_warning.alert.alert-error{:style => "display:none"} + =t :cookie_disabled_warning +:javascript + document.cookie = "testing=cookies_enabled; path=/"; + if(document.cookie.indexOf("testing=cookies_enabled") < 0) + { + document.getElementById('cookie_warning').style.display = 'block'; + } else { + document.getElementById('cookie_warning').style.display = 'none'; + } \ No newline at end of file diff --git a/users/app/views/users/new.html.haml b/users/app/views/users/new.html.haml index 709289e..80482b2 100644 --- a/users/app/views/users/new.html.haml +++ b/users/app/views/users/new.html.haml @@ -1,15 +1,5 @@ .span8.offset2 - %noscript.alert.alert-error=t :js_required - #cookie_warning.alert.alert-error{:display => 'none'} - =t :cookie_disabled_warning - :javascript - document.cookie = "testing=cookies_enabled; path=/"; - if(document.cookie.indexOf("testing=cookies_enabled") < 0) - { - document.getElementById('cookie_warning').style.display = 'block'; - } else { - document.getElementById('cookie_warning').style.display = 'none'; - } + = render :partial => 'warnings' %h2=t :signup = user_form do |f| %legend= t(:signup_message) -- cgit v1.2.3