From 36ef16fb01865552e3fcc14c81819cbbead49169 Mon Sep 17 00:00:00 2001 From: Azul Date: Fri, 4 Aug 2017 11:06:20 +0200 Subject: feat: remove signup link from landing page We are deprecating webapp based signup. It leads to an inconsistent state for mail providers and offers no useful interactions for vpn providers either. Instead of trying to deal with the halve way signup through the webapp we require signup through bitmask app which can also create the pgp keys for email and download and use the cert for vpn. In addition this reduces the attack surface for js injection, phishing and other browser based attacks. For now we still keep the signup form in case providers link to it directly. We also keep all the tests based on it. Cleanup will happen right after 0.10.0 release. --- app/views/common/_action_buttons.html.haml | 14 -------------- app/views/common/_download_button.html.haml | 8 -------- app/views/common/_home_page_buttons.html.haml | 19 +++++++++++++------ 3 files changed, 13 insertions(+), 28 deletions(-) delete mode 100644 app/views/common/_action_buttons.html.haml delete mode 100644 app/views/common/_download_button.html.haml (limited to 'app/views') diff --git a/app/views/common/_action_buttons.html.haml b/app/views/common/_action_buttons.html.haml deleted file mode 100644 index eb663c0..0000000 --- a/app/views/common/_action_buttons.html.haml +++ /dev/null @@ -1,14 +0,0 @@ -.home-buttons - .row.second - .login.col-md-4 - %span.link= btn icon('ok-sign') + t(:login), login_path - %span.info= t(:login_info, default: "") - - if APP_CONFIG[:allow_registration] - .signup.col-md-4 - %span.link= btn icon('user') + t(:signup), signup_path - %span.info= t(:signup_info, default: "") - - else - .signup.col-md-4 - .help.col-md-4 - %span.link= btn icon('question-sign') + t(:get_help), new_ticket_path - %span.info= t(:support_info, default: "") diff --git a/app/views/common/_download_button.html.haml b/app/views/common/_download_button.html.haml deleted file mode 100644 index 1278230..0000000 --- a/app/views/common/_download_button.html.haml +++ /dev/null @@ -1,8 +0,0 @@ -.home-buttons - .row.first - .col-md-2 - .download.col-md-8 - = btn client_download_url, type: [:large, :primary] do - = big_icon('download') - = t(:download_bitmask) - .col-md-2 diff --git a/app/views/common/_home_page_buttons.html.haml b/app/views/common/_home_page_buttons.html.haml index cfe3734..33cf796 100644 --- a/app/views/common/_home_page_buttons.html.haml +++ b/app/views/common/_home_page_buttons.html.haml @@ -1,6 +1,13 @@ -= render 'common/download_button' -- if local_assigns[:divider] - .row - .col-md-12 - = render local_assigns[:divider] -= render 'common/action_buttons' +.home-buttons + .row.first + .login.col-md-4 + %span.link= btn icon('ok-sign') + t(:login), login_path + %span.info= t(:login_info, default: "") + .download.col-md-4 + = btn client_download_url, type: [:large, :primary] do + = big_icon('download') + = t(:download_bitmask) + %span.info= t(:signup_info, default: "") + .help.col-md-4 + %span.link= btn icon('question-sign') + t(:get_help), new_ticket_path + %span.info= t(:support_info, default: "") -- cgit v1.2.3