From 460129e5965751127bb6cb363a661afb7c7d5ab4 Mon Sep 17 00:00:00 2001 From: thea Date: Wed, 21 Sep 2016 14:08:38 +0200 Subject: included error-handling: twitter-helper includes rescue and error message for fourth value in array. there will always be an empty array that view (text and each - method) does not break. if empty array in view the error-message is shown. (its WIP) --- app/helpers/twitter_helper.rb | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'app/helpers/twitter_helper.rb') diff --git a/app/helpers/twitter_helper.rb b/app/helpers/twitter_helper.rb index f824a03..8503f24 100644 --- a/app/helpers/twitter_helper.rb +++ b/app/helpers/twitter_helper.rb @@ -23,6 +23,26 @@ module TwitterHelper twitter_user_info[0] = Time.now twitter_user_info[1] = twitter_client.user(twitter_handle).name twitter_user_info[2] = twitter_client.user_timeline(twitter_handle).select{ |tweet| tweet.text.start_with?('RT','@')==false}.take(3) + if twitter_user_info[2] == nil + error_handling + twitter_user_info[3] = "The twitter-handle does not exist or the account is private. Please change it or contact your provider-admin." + end + rescue Twitter::Error::BadRequest + error_handling + rescue Twitter::Error::Unauthorized + error_handling + rescue Twitter::Error::Forbidden + error_handling + rescue Twitter::Error::NotAcceptable + error_handling + rescue Twitter::Error::TooManyRequests + error_handling + end + + def error_handling + twitter_user_info[2] = [] + twitter_user_info[3] = "The twitter-handle does not exist or the account is private. Please change it or contact your provider-admin." + return twitter_user_info end def cached_info @@ -43,4 +63,8 @@ module TwitterHelper def tweets cached_info[2] end + + def error_message + cached_info[3] + end end -- cgit v1.2.3 From d44fc9292637ed6d1a4a7e04883e8b3b88dc3c15 Mon Sep 17 00:00:00 2001 From: theaamanda Date: Wed, 21 Sep 2016 23:34:53 +0200 Subject: finished error-handling with different error-messages for different errors. added info that the account has to be public in Twitter-Doc --- app/helpers/twitter_helper.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'app/helpers/twitter_helper.rb') diff --git a/app/helpers/twitter_helper.rb b/app/helpers/twitter_helper.rb index 8503f24..719f95e 100644 --- a/app/helpers/twitter_helper.rb +++ b/app/helpers/twitter_helper.rb @@ -29,19 +29,23 @@ module TwitterHelper end rescue Twitter::Error::BadRequest error_handling + twitter_user_info[3] = "The request to have the tweets shown was invalid or cannot be otherwise served." rescue Twitter::Error::Unauthorized error_handling + twitter_user_info[3] = "Please change your twitter-credentials, make sure that the twitter-account you access is public or contact your provider-admin to have the tweets shown." rescue Twitter::Error::Forbidden error_handling + twitter_user_info[3] = "The request to have the tweets shown is understood, but it has been refused or access is not allowed." rescue Twitter::Error::NotAcceptable error_handling + twitter_user_info[3] = "An invalid format is specified in the request to have the tweets shown." rescue Twitter::Error::TooManyRequests error_handling + twitter_user_info[3] = "The rate-limit for accessing the tweets is reached. You should be able to see the tweets in a couple of minutes." end def error_handling twitter_user_info[2] = [] - twitter_user_info[3] = "The twitter-handle does not exist or the account is private. Please change it or contact your provider-admin." return twitter_user_info end -- cgit v1.2.3