| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
closes #6550
|
|
tickets db might not yet be initialized.
|
|
Also reformated long haml lines some. You can add a linebreak after a comma.
|
|
|
|
It removed most of the reduce functions... really not what we wanted
|
|
We completely ingnore the user_id param for non admins now. So if someone tries to show somebody elses tickets they will see their own instead.
|
|
|
|
only submit the params that differ from the defaults
|
|
When an admin sorted the tickets view in a different order it would take them to their own tickets list before
|
|
This was causing problems with zeus
|
|
Use link_to_navigation for all important navigation items. It creates a link in a list item for use with bootstrap. It supports an :active flag and an :icon option in the html_options now. It also translates the label. This way it can be used in a lot of places as the generic navigation link.
|
|
There's an identities tab now for admins that will allow unblocking blocked handles. It should be easy to expand for aliases and forwards and other types of actions such as editing.
|
|
|
|
|
|
|
|
|
|
Also translates the first arg if it's a symbol and adds more btn- classes if given as html_options[:type]
|
|
Just in case some translation keys are not present things should still work and make sense.
So translation keys should be picked in a meaningful way and scoped rather than prefixed.
For example overview.account will turn into "Account" if no translation is present while "overview_account" will turn into "Overview Account". We usually want the former.
|
|
|
|
|
|
FlashResponder added a flash before responding. However at the point of responding objects have already been saved. So there is no way to test if they were changed.
Now instead we can call
flash_for resource
before
resource.save
and it will add the flash messages only if the resource was actually changed.
|
|
close and open actions for plain opening and closing the tickets
respond_with so fields are not cleared on invalid update
the custom actions are not strictly restful. But adding a subresource felt like too much overhead and is conceptually hard to grasp (so we destroy the openess of the ticket to close it?).
|
|
|
|
|
|
|
|
This controller does too much - so the tests are also getting large and hard to keep track of
|
|
open/close toggle and fields in different forms - fixes #5659
|
|
Ticket.is_creator_vlidated? now actually fetches the user from the db and returns false if it does not exist.
|
|
|
|
email and regarding user fields can be set to defaults based on
created_by user.
If these fields are emptied by the submitting user they will be set to whereas they are nil if they have not been initialized. In that case we will use meaningful defaults from the user who created the ticket.
|
|
We should respect the users choice. We can still get their email from the user id if we really need to.
|
|
They do not save any changes. So i think it's better to keep them separated from the Save button that does save changes.
|
|
|
|
the loading... text on the buttons was not capitalized before.
So in order to change this in a (more or less) single place i added
new button types to simple_form:
button :wrapped - normal button, with loading and an optional cancel button wrapped in the classical bootstrap action div.
cancel option contains the url to go to when canceling.
button :loading - simple button with loading text capitalized by using i18n (simple_form.buttons.loading)
Conflicts:
engines/support/app/views/tickets/new.html.haml
|
|
Feature/api quota support + current_user null pattern
|
|
|
|
when rendered from teh create action due to an error user_id param will
sometimes be an empty string. We should still avoid rendering the
navigation because the path's can not be resolved without a user_id.
|
|
|
|
The auto_ticket_path is referenced from the tickets_controller like this:
respond_with(@ticket, :location => auto_ticket_path(@ticket))
While this only uses the location parameter when the ticket is valid it will still attampt to calculate it if not. During the create action this will lead to crashes because the ticket_path can not be calculated for a ticket without an id.
This led to https://leap.se/code/issues/5552 and probably
https://leap.se/code/issues/5545.
|
|
|
|
Null Pattern for current_user - use it to get rid of some conditionals
|
|
|
|
Also renamed help to support so it's harder to confuse it with documentation
|
