summaryrefslogtreecommitdiff
path: root/engines/support
AgeCommit message (Collapse)Author
2014-05-29fix flash for creating anonymous ticketsAzul
2014-05-29adopt tests to new translationsAzul
2014-05-28destroy_btn helper methodAzul
2014-05-27add btn helper for link_to with .btnAzul
Also translates the first arg if it's a symbol and adds more btn- classes if given as html_options[:type]
2014-05-26navigation works with empty locale selectedAzul
Just in case some translation keys are not present things should still work and make sense. So translation keys should be picked in a meaningful way and scoped rather than prefixed. For example overview.account will turn into "Account" if no translation is present while "overview_account" will turn into "Overview Account". We usually want the former.
2014-05-26tickets: structure i18nAzul
2014-05-26flash_for with_errors option displays error messagesAzul
2014-05-26Controller#flash_for instead of FlashResponderAzul
FlashResponder added a flash before responding. However at the point of responding objects have already been saved. So there is no way to test if they were changed. Now instead we can call flash_for resource before resource.save and it will add the flash messages only if the resource was actually changed.
2014-05-26split up and refactor TicketController#updateAzul
close and open actions for plain opening and closing the tickets respond_with so fields are not cleared on invalid update the custom actions are not strictly restful. But adding a subresource felt like too much overhead and is conceptually hard to grasp (so we destroy the openess of the ticket to close it?).
2014-05-26separate tests for the ticket list from main controller testAzul
2014-05-26splitting up long functional test caseAzul
2014-05-26FlashResponder will automagically add flash messagesAzul
2014-05-26move comment related tests out of TicketControllerTestAzul
This controller does too much - so the tests are also getting large and hard to keep track of
2014-05-14Merge pull request #159 from azul/bugfix/5659-fix-ticket-form-submitazul
open/close toggle and fields in different forms - fixes #5659
2014-05-13adjust tests to new config and method implementationAzul
Ticket.is_creator_vlidated? now actually fetches the user from the db and returns false if it does not exist.
2014-05-13open/close toggle and fields in different forms - fixes #5659Azul
2014-05-13prefill ticket form from the model - fixes #5657Azul
email and regarding user fields can be set to defaults based on created_by user. If these fields are emptied by the submitting user they will be set to whereas they are nil if they have not been initialized. In that case we will use meaningful defaults from the user who created the ticket.
2014-05-13keep empty email field if user removed prefillAzul
We should respect the users choice. We can still get their email from the user id if we really need to.
2014-04-25move open and close buttons into status displayAzul
They do not save any changes. So i think it's better to keep them separated from the Save button that does save changes.
2014-04-25using simple_form for the last form that was not using it.Azul
2014-04-25simple form: add wrapped and loading... buttons #5542Azul
the loading... text on the buttons was not capitalized before. So in order to change this in a (more or less) single place i added new button types to simple_form: button :wrapped - normal button, with loading and an optional cancel button wrapped in the classical bootstrap action div. cancel option contains the url to go to when canceling. button :loading - simple button with loading text capitalized by using i18n (simple_form.buttons.loading) Conflicts: engines/support/app/views/tickets/new.html.haml
2014-04-25Merge pull request #148 from azul/feature/api-quota-supportazul
Feature/api quota support + current_user null pattern
2014-04-24add tests for invalid ticket creationAzul
2014-04-24check user_id param for present? instead of !nil?Azul
when rendered from teh create action due to an error user_id param will sometimes be an empty string. We should still avoid rendering the navigation because the path's can not be resolved without a user_id.
2014-04-24let's only add the flash notice if the ticket has been createdAzul
2014-04-24return nil as auto_ticket_path for invalid ticketsAzul
The auto_ticket_path is referenced from the tickets_controller like this: respond_with(@ticket, :location => auto_ticket_path(@ticket)) While this only uses the location parameter when the ticket is valid it will still attampt to calculate it if not. During the create action this will lead to crashes because the ticket_path can not be calculated for a ticket without an id. This led to https://leap.se/code/issues/5552 and probably https://leap.se/code/issues/5545.
2014-04-18minor fix: User#email_address not User#emailAzul
2014-04-17make use of the UnauthorizedUserAzul
Null Pattern for current_user - use it to get rid of some conditionals
2014-04-11minor: our engines do not have a db directoryAzul
2014-04-11move engines into engines directoryAzul
Also renamed help to support so it's harder to confuse it with documentation