Cleanup of code for messages API and cron job for 1 month payment warning. Authentication still remaining piece.

1 files changed, 3 insertions, 12 deletions

diff --git a/users/app/controllers/v1/messages_controller.rb b/users/app/controllers/v1/messages_controller.rb
index 18f9f46..42a88f7 100644
--- a/users/app/controllers/v1/messages_controller.rb
+++ b/users/app/controllers/v1/messages_controller.rb
@@ -12,20 +12,11 @@ module V1
 
     # routes ensure this is only for PUT
     def mark_read
-=begin
-      user_message = UserMessage.find_by_user_id_and_message_id([params[:user_id], params[:message_id]])
-      user_message.seen = true if user_message
 
-      # TODO what to return?
-      if user_message and user_message.save
-        render json: true
-      else
-        render json: false
-      end
-    end
-=end
+      # make sure user and message exist
       if (user = User.find(params[:user_id])) && Message.find(params[:message_id])
-        user.message_ids_seen << params[:message_id] if !user.message_ids_seen.include?(params[:message_id]) #is it quicker to instead run uniq after adding?
+
+        user.message_ids_seen << params[:message_id] if !user.message_ids_seen.include?(params[:message_id]) #TODO: is it quicker to instead call uniq! after adding?
         user.message_ids_to_see.delete(params[:message_id])
         user.save
         render json: true