test: use assert_error_response in functional test

This way the changed flash hash still is recognized.

Also changed the generic 'no_such_thing' i18n key to more specific 'no_such_user'.
The former is very hard to translate as the gender of thing may affect the translation of the 'no such' part.

1 files changed, 7 insertions, 4 deletions

diff --git a/test/support/assert_responses.rb b/test/support/assert_responses.rb
index 98c9ad2..6a22642 100644
--- a/test/support/assert_responses.rb
+++ b/test/support/assert_responses.rb
@@ -71,15 +71,18 @@ module AssertResponses
   end
 
   def assert_login_required
-    assert_error_response :not_authorized_login, :unauthorized
+    assert_error_response :not_authorized_login,
+      status: :unauthorized
   end
 
   def assert_access_denied
-    assert_error_response :not_authorized, :forbidden
+    assert_error_response :not_authorized,
+      status: :forbidden
   end
 
-  def assert_error_response(key, status=nil)
-    message = I18n.t(key)
+  def assert_error_response(key, options = {})
+    status=options.delete :status
+    message = I18n.t(key, options)
     if content_type == 'application/json'
       status ||= :unprocessable_entity
       assert_json_response('error' => key.to_s, 'message' => message)