diff options
| author | azul <azul@riseup.net> | 2013-12-20 11:52:00 -0800 |
|---|---|---|
| committer | azul <azul@riseup.net> | 2013-12-20 11:52:00 -0800 |
| commit | 3d9a6d11003a72d88b4d49c66584041275fa1dd4 (patch) | |
| tree | 7b49f252d2229142084aaca95122a04554fb3350 | |
| parent | 9d1fdcb1d5a18c74776b43cb78e3dc305fdddffc (diff) | |
| parent | 5c9d2ba552537b8dba98d9fe98e05c38fa788a5e (diff) | |
Merge pull request #130 from azul/bugfix/4805-fix-overview-active
make sure overview link is active on Users#show - fixes #4805
| -rw-r--r-- | app/views/layouts/_navigation.html.haml | 4 | ||||
| -rw-r--r-- | users/test/integration/browser/account_test.rb | 5 |
2 files changed, 6 insertions, 3 deletions
diff --git a/app/views/layouts/_navigation.html.haml b/app/views/layouts/_navigation.html.haml index f90ed16..b81c43d 100644 --- a/app/views/layouts/_navigation.html.haml +++ b/app/views/layouts/_navigation.html.haml @@ -1,6 +1,6 @@ %ul.nav.sidenav - = link_to_navigation t(:overview), @user, :active => controller?(:overviews) - = link_to_navigation t(:account_settings), edit_user_path(@user), :active => controller?(:users) + = link_to_navigation t(:overview), @user, :active => (controller?(:users) && action?(:show)) + = link_to_navigation t(:account_settings), edit_user_path(@user), :active => (controller?(:users) && !action?(:show)) - # will want link for identity settings = link_to_navigation t(:support_tickets), auto_tickets_path, :active => controller?(:tickets) = link_to_navigation t(:billing_settings), billing_top_link(@user), :active => controller?(:customer, :payments, :subscriptions, :credit_card_info) if APP_CONFIG[:billing] diff --git a/users/test/integration/browser/account_test.rb b/users/test/integration/browser/account_test.rb index 4cefe35..3785b72 100644 --- a/users/test/integration/browser/account_test.rb +++ b/users/test/integration/browser/account_test.rb @@ -14,7 +14,7 @@ class AccountTest < BrowserIntegrationTest username, password = submit_signup assert page.has_content?("Welcome #{username}") click_on 'Logout' - assert page.has_content?("Sign Up") + assert page.has_content?("Log In") assert_equal '/', current_path assert user = User.find_by_login(username) user.account.destroy @@ -25,6 +25,9 @@ class AccountTest < BrowserIntegrationTest click_on 'Logout' attempt_login(username, password) assert page.has_content?("Welcome #{username}") + within('.sidenav li.active') do + assert page.has_content?("Overview") + end User.find_by_login(username).account.destroy end |