diff options
| author | Azul <azul@leap.se> | 2014-04-22 14:43:19 +0200 |
|---|---|---|
| committer | Azul <azul@leap.se> | 2014-04-24 20:36:11 +0200 |
| commit | 7df11eed6aa48d1f61ee7f3700295c78b62358f0 (patch) | |
| tree | 39418a3103406d6a30fb6ef2e4ef6f80515476b7 | |
| parent | c5c54ec2035813949a81e8b5977a8f2538897260 (diff) | |
check user_id param for present? instead of !nil?
when rendered from teh create action due to an error user_id param will
sometimes be an empty string. We should still avoid rendering the
navigation because the path's can not be resolved without a user_id.
| -rw-r--r-- | engines/support/app/views/tickets/index.html.haml | 2 | ||||
| -rw-r--r-- | engines/support/app/views/tickets/new.html.haml | 4 | ||||
| -rw-r--r-- | engines/support/app/views/tickets/show.html.haml | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/engines/support/app/views/tickets/index.html.haml b/engines/support/app/views/tickets/index.html.haml index c02a326..a4df6e3 100644 --- a/engines/support/app/views/tickets/index.html.haml +++ b/engines/support/app/views/tickets/index.html.haml @@ -1,4 +1,4 @@ -- @show_navigation = !params[:user_id].nil? +- @show_navigation = params[:user_id].present? = render 'tickets/tabs' diff --git a/engines/support/app/views/tickets/new.html.haml b/engines/support/app/views/tickets/new.html.haml index 8f217a5..ba86ac3 100644 --- a/engines/support/app/views/tickets/new.html.haml +++ b/engines/support/app/views/tickets/new.html.haml @@ -1,4 +1,4 @@ -- @show_navigation = !params[:user_id].nil? +- @show_navigation = params[:user_id].present? = render 'tickets/tabs' @@ -27,4 +27,4 @@ - if logged_in? = link_to t(:cancel), auto_tickets_path, :class => :btn - else - = link_to t(:cancel), home_path, :class => 'btn'
\ No newline at end of file + = link_to t(:cancel), home_path, :class => 'btn' diff --git a/engines/support/app/views/tickets/show.html.haml b/engines/support/app/views/tickets/show.html.haml index bfdb773..bbca4bf 100644 --- a/engines/support/app/views/tickets/show.html.haml +++ b/engines/support/app/views/tickets/show.html.haml @@ -1,4 +1,4 @@ -- @show_navigation = !params[:user_id].nil? +- @show_navigation = params[:user_id].present? .ticket = render 'tickets/edit_form' @@ -9,4 +9,4 @@ %td.user = logged_in? ? current_user.login : t(:anonymous) %td.comment - = render 'tickets/new_comment_form'
\ No newline at end of file + = render 'tickets/new_comment_form' |