leap_web.git/users/test/unit, branch 0.2.2 [leap_web] Merge pull request #73 from azul/bugfix/3623-teardown-test-data-properly 2013-09-03T17:48:13+00:00 jessib jessib@riseup.net 2013-09-03T17:48:13+00:00 07d0f6fe1d80cb730bd12a03a107c18d18779acc Bugfix/3623 teardown test data properly 
Bugfix/3623 teardown test data properly
 Account: Composition to handle User and its identities 2013-09-03T06:54:25+00:00 Azul azul@leap.se 2013-08-30T09:20:04+00:00 859b79d0dcd53c85bb57e3db888a1af702802987 We have a lot of things that act upon a user record and one or more of it's identities at the same time: * Sing up: Create a user and it's initial identity * Rename: Change the username and create a new identity, turn old into an alias * Cancel Account: Remove user and all their identities. In order to keep the User and Identity behaviour isolated but still have a this logic represented in a sinle place the Account model deals with all these things. We could have overwritten the User#create, User#update and User#destroy methods instead. But then we would always create identities, even if we only need a user (for example in tests). 
We have a lot of things that act upon a user record and one or more of it's identities at the same time:
* Sing up: Create a user and it's initial identity
* Rename:  Change the username and create a new identity, turn old into an alias
* Cancel Account: Remove user and all their identities.

In order to keep the User and Identity behaviour isolated but still have a this logic represented in a sinle place the Account model deals with all these things.

We could have overwritten the User#create, User#update and User#destroy methods instead. But then we would always create identities, even if we only need a user (for example in tests).
don't leave id records behind when unit testing 2013-09-03T06:54:25+00:00 Azul azul@leap.se 2013-08-30T08:14:22+00:00 e2a3daa9ae3f3570aca0dc22b70d87252e599d7a 






expire token according to config setting auth:token_expires_after
2013-09-03T06:36:17+00:00

Azul
azul@leap.se

2013-08-28T09:13:38+00:00

42cef3117cd97d9c37968a8cf63d33b27b4b8ed2












there's no need for User#find_by_param. clean it up
2013-08-30T12:54:30+00:00

Azul
azul@leap.se

2013-08-28T09:53:58+00:00

7bb1a16d4eee3eb3ef36c6f5b4fc7968e3da7dd6












keeping the pgp_key accessors for User so views still work
2013-07-24T09:38:32+00:00

Azul
azul@leap.se

2013-07-24T09:09:04+00:00

370be6caa8a366774fba15d09fb03ee4d923b861












separate signup and settings service objects for user
2013-07-24T08:56:45+00:00

Azul
azul@leap.se

2013-07-19T14:02:02+00:00

d70c5796a2989b7b43f7e287899fb1394ae28280












setter for keys for dirty tracking, more robust tests
2013-07-24T08:55:51+00:00

Azul
azul@leap.se

2013-07-19T10:21:40+00:00

c0b88d9e8fe574d6164f48211db50f3b8a4c4d93

Just altering identity.keys did not mark identities as changed. Also we now have a sane default for keys.





Just altering identity.keys did not mark identities as changed. Also we now have a sane default for keys.







test user validates uniqueness of login amongst aliases
2013-07-24T08:55:51+00:00

Azul
azul@leap.se

2013-07-19T09:20:01+00:00

51582a668b04d2c1322ad1babe8599ae8797cd3b












support deprecated API to set users main identity pgp key
2013-07-24T08:55:51+00:00

Azul
azul@leap.se

2013-07-19T09:09:25+00:00

8ddbaa6184e4dbcc6ef7e81cf555cc18d3822dce

We'll want to get rid of the #public_key and #public_key= functions but they are still used from the users controller. We'll probably have an identity controller instead at some point.





We'll want to get rid of the #public_key and #public_key= functions but they are still used from the users controller. We'll probably have an identity controller instead at some point.