summaryrefslogtreecommitdiff
path: root/puppet/modules/site_static
diff options
context:
space:
mode:
authorelijah <elijah@riseup.net>2014-06-02 12:02:29 -0700
committerelijah <elijah@riseup.net>2014-06-02 12:03:06 -0700
commit455422ddd5152679eb8df5554e371dbcf2c28f27 (patch)
treef01d1d38ae6349806e85950bb03323adcac427be /puppet/modules/site_static
parent0c4c0ab6863c4c1cf59d0e999c7ba7bd41d3546c (diff)
static site: better message for wrong location type.
Diffstat (limited to 'puppet/modules/site_static')
-rw-r--r--puppet/modules/site_static/manifests/location.pp6
-rw-r--r--puppet/modules/site_static/templates/apache.conf.erb4
2 files changed, 7 insertions, 3 deletions
diff --git a/puppet/modules/site_static/manifests/location.pp b/puppet/modules/site_static/manifests/location.pp
index 9c749b00..ce2af9af 100644
--- a/puppet/modules/site_static/manifests/location.pp
+++ b/puppet/modules/site_static/manifests/location.pp
@@ -1,13 +1,15 @@
define site_static::location($path, $format, $source) {
$file_path = "/srv/static/${name}"
+ $allowed_formats = ['amber','rack']
if $format == undef {
fail("static_site location `${path}` is missing `format` field.")
}
- if ! member(['amber','rack'], $format) {
- fail("Could not understand static_site location format `${format}`.")
+ if ! member($allowed_formats, $format) {
+ $formats_str = join($allowed_formats, ', ')
+ fail("Unsupported static_site location format `${format}`. Supported formats include ${formats_str}.")
}
if ($format == 'amber') {
diff --git a/puppet/modules/site_static/templates/apache.conf.erb b/puppet/modules/site_static/templates/apache.conf.erb
index a16d51f4..07ac481d 100644
--- a/puppet/modules/site_static/templates/apache.conf.erb
+++ b/puppet/modules/site_static/templates/apache.conf.erb
@@ -82,10 +82,12 @@
<%- location_path = location['path'].gsub(%r{^/|/$}, '') -%>
<%- directory = location_directory(name, location) -%>
<%- local_vars = {'location_path'=>location_path, 'directory'=>directory, 'location'=>location, 'name'=>name} -%>
+<%- template_path = File.join(File.dirname(__FILE__), location['format']) + '.erb' -%>
+<%- break unless File.exists?(template_path) -%>
##
## <%= name %> (<%= location['format'] %>)
##
-<%= scope.function_templatewlv([File.join(File.dirname(__FILE__), location['format']) + '.erb', local_vars]) %>
+<%= scope.function_templatewlv([template_path, local_vars]) %>
<%- end -%>
</VirtualHost>