static site: better message for wrong location type.

1 files changed, 4 insertions, 2 deletions

diff --git a/puppet/modules/site_static/manifests/location.pp b/puppet/modules/site_static/manifests/location.pp
index 9c749b00..ce2af9af 100644
--- a/puppet/modules/site_static/manifests/location.pp
+++ b/puppet/modules/site_static/manifests/location.pp
@@ -1,13 +1,15 @@
 define site_static::location($path, $format, $source) {
 
   $file_path = "/srv/static/${name}"
+  $allowed_formats = ['amber','rack']
 
   if $format == undef {
     fail("static_site location `${path}` is missing `format` field.")
   }
 
-  if ! member(['amber','rack'], $format) {
-    fail("Could not understand static_site location format `${format}`.")
+  if ! member($allowed_formats, $format) {
+    $formats_str = join($allowed_formats, ', ')
+    fail("Unsupported static_site location format `${format}`. Supported formats include ${formats_str}.")
   }
 
   if ($format == 'amber') {