[feat] Remove puppet run stages

To reduce complexity, let's get rid of run stages.
We used them earlier but they seem to have no purpose anymore.

There was two stage leftovers:

- `site_config::slow` did an `apt-get dist-upgrade` in the
  `setup` stage
- `site_config::setup` did call the `site_config::hosts` class
  in the `setup` stage

I checked for dependencies to to those resources, and it looks good,
i tested by triggering a citest.

From
https://docs.puppetlabs.com/puppet/latest/reference/lang_run_stages.html#limitations-and-known-issues:

```
Due to these limitations, stages should only be used with the simplest
of classes, and only when absolutely necessary. Mass dependencies like
package repositories are effectively the only valid use case.
```

1 files changed, 5 insertions, 3 deletions

diff --git a/puppet/modules/site_config/manifests/setup.pp b/puppet/modules/site_config/manifests/setup.pp
index b09d0413..dba5fa14 100644
--- a/puppet/modules/site_config/manifests/setup.pp
+++ b/puppet/modules/site_config/manifests/setup.pp
@@ -1,3 +1,7 @@
+# common things to set up on every node
+# leftover from the past, where we did two puppetruns
+# after another. We should consolidate this into site_config::default
+# in the future.
 class site_config::setup {
   tag 'leap_base'
 
@@ -13,9 +17,7 @@ class site_config::setup {
   include stdlib
 
   # configure /etc/hosts
-  class { 'site_config::hosts':
-    stage => setup,
-  }
+  class { 'site_config::hosts': }
 
   include site_config::initial_firewall