diff options
| author | varac <varacanero@zeromail.org> | 2016-02-01 17:35:16 +0100 |
|---|---|---|
| committer | varac <varacanero@zeromail.org> | 2016-02-02 09:47:45 +0100 |
| commit | 9278d76636fcffa624528b1fb11a7197f9f6b27c (patch) | |
| tree | cc2b13cf25770a966ef455420b0fc04c40dbc5ab | |
| parent | 432b139f6529fab2f190b7f066064559ecd5a5d5 (diff) | |
[refactor] Dont duplicate Package resource override
`site_apt` aready ensures for installing packages after Exec[update_apt]
is run, so we don't need to duplicate this in `site_config::default.pp`.
| -rw-r--r-- | puppet/modules/site_apt/manifests/init.pp | 8 | ||||
| -rw-r--r-- | puppet/modules/site_config/manifests/default.pp | 12 |
2 files changed, 3 insertions, 17 deletions
diff --git a/puppet/modules/site_apt/manifests/init.pp b/puppet/modules/site_apt/manifests/init.pp index 04b1ce69..447e1781 100644 --- a/puppet/modules/site_apt/manifests/init.pp +++ b/puppet/modules/site_apt/manifests/init.pp @@ -52,10 +52,8 @@ class site_apt { pin => 'origin "deb.leap.se"' } -# All packages should be installed _after_ refresh_apt is called, -# which does an apt-get update. - - Exec['apt_updated'] -> - Package <||> + # All packages should be installed after 'update_apt' is called, + # which does an 'apt-get update'. + Exec['update_apt'] -> Package <||> } diff --git a/puppet/modules/site_config/manifests/default.pp b/puppet/modules/site_config/manifests/default.pp index b5d0f32d..256de1a1 100644 --- a/puppet/modules/site_config/manifests/default.pp +++ b/puppet/modules/site_config/manifests/default.pp @@ -7,18 +7,6 @@ class site_config::default { include site_config::params include site_config::setup - # By default, the class 'site_config::slow' is included in site.pp. - # It basically does an 'apt-get update' and 'apt-get dist-upgrade'. - # This class can be excluded by using 'leap deploy --fast', - # see https://leap.se/en/docs/platform/details/under-the-hood#tags for more - # details. - # The following Package resource override makes sure that *if* an - # 'apt-get update' is executed by 'site_config::slow', it should be done - # before any packages are installed. - - Package { require => Exec['apt_updated'] } - - # default class, used by all hosts include lsb, git |