From 3fc38cfa269fd7a8fa602aaf2a3e025b5403b71b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1s=20Touceda?= <chiiph@leap.se>
Date: Wed, 6 Nov 2013 14:27:24 -0300
Subject: Refactor mail processing routine

---
 src/leap/mx/mail_receiver.py | 48 ++++++++++++++++++++++++--------------------
 1 file changed, 26 insertions(+), 22 deletions(-)

(limited to 'src/leap/mx/mail_receiver.py')

diff --git a/src/leap/mx/mail_receiver.py b/src/leap/mx/mail_receiver.py
index 741b99d..785be2e 100644
--- a/src/leap/mx/mail_receiver.py
+++ b/src/leap/mx/mail_receiver.py
@@ -220,6 +220,31 @@ class MailReceiver(Service):
 
         return uuid
 
+    @defer.inlineCallbacks
+    def _step_process_mail_backend(self, filepath):
+        log.msg("Processing new mail at %r" % (filepath.path,))
+        with filepath.open("r") as f:
+            mail_data = f.read()
+            mail = message_from_string(mail_data)
+            uuid = self._get_owner(mail)
+            if uuid is None:
+                log.msg("Don't know how to deliver mail %r, skipping..." %
+                        filepath.path)
+                defer.returnValue(None)
+            log.msg("Mail owner: %s" % (uuid,))
+
+            if uuid is None:
+                log.msg("BUG: There was no uuid!")
+                defer.returnValue(None)
+
+            pubkey = yield self._users_cdb.getPubKey(uuid)
+
+            log.msg("Encrypting message to %s's pubkey" % (uuid,))
+            doc = yield self._encrypt_message(pubkey, mail_data)
+
+            do_remove = yield self._export_message(uuid, doc)
+            yield self._conditional_remove(do_remove, filepath)
+
     @defer.inlineCallbacks
     def _process_incoming_email(self, otherself, filepath, mask):
         """
@@ -236,27 +261,6 @@ class MailReceiver(Service):
         """
         try:
             if os.path.split(filepath.dirname())[-1]  == "new":
-                log.msg("Processing new mail at %r" % (filepath.path,))
-                with filepath.open("r") as f:
-                    mail_data = f.read()
-                    mail = message_from_string(mail_data)
-                    uuid = self._get_owner(mail)
-                    if uuid is None:
-                        log.msg("Don't know how to deliver mail %r, skipping..." %
-                                filepath.path)
-                        return
-                    log.msg("Mail owner: %s" % (uuid,))
-
-                    if uuid is None:
-                        log.msg("BUG: There was no uuid!")
-                        return
-
-                    pubkey = yield self._users_cdb.getPubKey(uuid)
-
-                    log.msg("Encrypting message to %s's pubkey" % (uuid,))
-                    doc = yield self._encrypt_message(pubkey, mail_data)
-
-                    do_remove = yield self._export_message(uuid, doc)
-                    yield self._conditional_remove(do_remove, filepath)
+                yield self._step_process_mail_backend(filepath)
         except Exception:
             log.err()
-- 
cgit v1.2.3