From 91115f6bc8430fbef03b5e8e7e3975e5846eb50f Mon Sep 17 00:00:00 2001 From: Kali Kaneko Date: Mon, 2 Mar 2015 11:49:35 -0400 Subject: [refactor] remove dead code in IMAP implementation while updating the tests, I found that IMAPMessageCollection was not actually being used: all the work is done in IMAPMailbox, using directly the MessageCollection instance. So, this extra level of abstraction was finally not used. Releases: 0.9.0 --- src/leap/mail/imap/mailbox.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'src/leap/mail/imap/mailbox.py') diff --git a/src/leap/mail/imap/mailbox.py b/src/leap/mail/imap/mailbox.py index 2653ae4..91c6549 100644 --- a/src/leap/mail/imap/mailbox.py +++ b/src/leap/mail/imap/mailbox.py @@ -82,9 +82,9 @@ class IMAPMailbox(object): A Soledad-backed IMAP mailbox. Implements the high-level method needed for the Mailbox interfaces. - The low-level database methods are contained in IMAPMessageCollection - class, which we instantiate and make accessible in the `messages` - attribute. + The low-level database methods are contained in the generic + MessageCollection class. We receive an instance of it and it is made + accessible in the `collection` attribute. """ implements( imap4.IMailbox, @@ -107,14 +107,13 @@ class IMAPMailbox(object): def __init__(self, collection, rw=1): """ - :param collection: instance of IMAPMessageCollection - :type collection: IMAPMessageCollection + :param collection: instance of MessageCollection + :type collection: MessageCollection :param rw: read-and-write flag for this mailbox :type rw: int """ self.rw = rw - self._uidvalidity = None self.collection = collection -- cgit v1.2.3