Age | Commit message (Collapse) | Author |
|
- Related: #6359
|
|
Current twisted implementation correctly parses partial fetches using
substrings by use of angle brackets (see section 6.4.5 of imap rfc), but
no use is made of the requested substring in the spew_body method.
this commit minimally implements conformance to the substring request,
although further boundary checks should be made (ie, checking whether
the starting octet is beyond the end of the text).
Resolves: #6841
Releases: 0.4.0
|
|
By removing this call to lower(), we avoid a bug in which the
BODYSTRUCTURE response returns a boundary all in lower case.
Should send patch upstream to twisted.
Related: #6773
|
|
Thunderbird (as of 37.0b1) will display a blank body (with no
attachments) if some conditions are met:
* disk synchronization is disabled
* mime_part_on_demand = true
* msg size is bigger than the parts_on_demand threshold (30000 by
default).
Comparing the logs with a well behaved imap server (dovecot, on this
case), it's easy to see that twisted implementation is lacking an extra
line separator at the end of each group of headers that is rendered in
response to each of the `BODY.PEEK[X.MIME]` command that the
mime_parts_on_demand will issue after getting the BODYSTRUCTURE.
This change patches the spew_body command on the body server.
We still would have to see if this is a bad behaviour in the thunderbird
side. The most similar bug I've found is:
https://bugzilla.mozilla.org/show_bug.cgi?id=149771
Which apparently was happening with exchange server.
We should send the patch to upstream twisted as well.
Note that this fix is not enough: the following commit, about fixing the
case of the boundary passed in the BODYSTRUCTURE response is also needed
to fix the bug (since a bad parsing happens all the same).
Resolves: #6773, #5010
Documentation: #6773
Releases: 0.4.0
|
|
|
|
|
|
mostly having to do with poor, missing or outdated documentation,
naming of confusing things and reordering of code blocks for improved
readability.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This also paves the way to MULTIAPPEND IMAP Extension (rfc3502)
Related to: Feature #5182
|
|
This fixes a bug with qtreactor that was making the 'OK foo copied'
not being delivered.
This or something similar will probably have to be re-added, because
on the current state the destination folder will not receive the
notification if it's selected *before* the copy operation has finished.
But in this way we have a clean slate that is working properly.
The bottleneck in the copy/append operations seems to have moved to
the select operation now.
|
|
also, dispatch query for all headers to its own method.
|
|
|
|
So we're safe under the green lights before further rewriting.
:)
|
|
|
|
because THE KEYS WILL BE STRINGS AFTER ADDED TO SOLEDAD
Can I remember that?
* Fix copy from local folders
* Fix copy when we already have a copy of the message in the inbox,
marked as deleted.
* Fix also bad deferred.succeed in add_msg when it already exist.
|
|
* reorganize and simplify STORE command processing
* add the notification after the processing of the whole sequence
|
|
Also some fixes for None comparisons.
|
|
|
|
|
|
|
|
...aaaand not a single fuck was given that day!
|
|
|
|
This change will allow for quicker access times, and smaller
syncs since the fields that change more often will fall in a
pretty small document. For the big raw message, we only need
to sync once.
Also, implemented multipart interface for messages.
This will need additional migration helper in --repair-mailboxes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Other fixes in the commit:
* Correct the semantic for the recent flag (reset)
* Minor unicode fixes.
* Use a field for tracking the last_uid
In general, this tries to squash all the quick and naive methods
that were relying on evaluating all the message objects before returning
a result.
Further work is still needed, planned also for 0.5 release.
get_by_index needs to be indexed too.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|