diff options
| author | Duda Dornelles <ddornell@thoughtworks.com> | 2014-09-09 15:07:41 -0300 |
|---|---|---|
| committer | Duda Dornelles <ddornell@thoughtworks.com> | 2014-09-09 15:07:41 -0300 |
| commit | b52104f908d668aec39e563923c7f04c05e5f221 (patch) | |
| tree | f9ce3168d9b4c1c8e1b9e521c34240f5307ce122 | |
| parent | 6ee0c7040d9bf8bb9f0fb33dccf80ea6a456c58c (diff) | |
addMailbox shouldn't accept empty names since it makes it impossible to retrieve it later
| -rw-r--r-- | changes/prevent-mailbox-with-blank-name | 3 | ||||
| -rw-r--r-- | src/leap/mail/imap/account.py | 2 |
2 files changed, 5 insertions, 0 deletions
diff --git a/changes/prevent-mailbox-with-blank-name b/changes/prevent-mailbox-with-blank-name new file mode 100644 index 0000000..c676fb6 --- /dev/null +++ b/changes/prevent-mailbox-with-blank-name @@ -0,0 +1,3 @@ + o account#addMailbox can't allow empty mailbox names since it makes it +impossible to create it later (mailbox#__init__ will throw an error), which makes +it impossible to getMailbox or even delete it diff --git a/src/leap/mail/imap/account.py b/src/leap/mail/imap/account.py index 74ec11e..70ed13b 100644 --- a/src/leap/mail/imap/account.py +++ b/src/leap/mail/imap/account.py @@ -187,6 +187,8 @@ class SoledadBackedAccount(WithMsgFields, IndexedDB, MBoxParser): """ name = self._parse_mailbox_name(name) + leap_assert(name, "Need a mailbox name to create a mailbox") + if name in self.mailboxes: raise imap4.MailboxCollision(repr(name)) |