From eaef7350ff03e4447962c06262ca1831cc06cab0 Mon Sep 17 00:00:00 2001 From: Arne Schwabe Date: Thu, 24 May 2012 11:11:45 +0200 Subject: Add more diagnostic messages for management password queries --- src/de/blinkt/openvpn/OpenVPN.java | 3 +++ src/de/blinkt/openvpn/OpenVpnManagementThread.java | 2 ++ src/de/blinkt/openvpn/VpnProfile.java | 4 +++- 3 files changed, 8 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/de/blinkt/openvpn/OpenVPN.java b/src/de/blinkt/openvpn/OpenVPN.java index 40fe3afd..55e15abc 100644 --- a/src/de/blinkt/openvpn/OpenVPN.java +++ b/src/de/blinkt/openvpn/OpenVPN.java @@ -7,6 +7,9 @@ public class OpenVPN { private static final int MAXLOGENTRIES = 200; + public static final String MANAGMENT_PREFIX = "M:"; + + public static LinkedList logbuffer = new LinkedList(); private static Vector logListener=new Vector(); diff --git a/src/de/blinkt/openvpn/OpenVpnManagementThread.java b/src/de/blinkt/openvpn/OpenVpnManagementThread.java index affd8045..6d67a4e6 100644 --- a/src/de/blinkt/openvpn/OpenVpnManagementThread.java +++ b/src/de/blinkt/openvpn/OpenVpnManagementThread.java @@ -355,6 +355,8 @@ public class OpenVpnManagementThread implements Runnable { if(pw!=null) { String cmd = String.format("password '%s' %s\n", needed, VpnProfile.openVpnEscape(pw)); managmentCommand(cmd); + } else { + OpenVPN.logMessage(0, OpenVPN.MANAGMENT_PREFIX, String.format("Openvpn requires Authentication type '%s' but no password/key information available", needed)); } } diff --git a/src/de/blinkt/openvpn/VpnProfile.java b/src/de/blinkt/openvpn/VpnProfile.java index 5cdff43d..125dc675 100644 --- a/src/de/blinkt/openvpn/VpnProfile.java +++ b/src/de/blinkt/openvpn/VpnProfile.java @@ -505,7 +505,9 @@ public class VpnProfile implements Serializable{ if(!mUsePull) { if(mIPv4Address == null || cidrToIPAndNetmask(mIPv4Address) == null) return R.string.ipv4_format_error; - + } + if(isUserPWAuth() && !nonNull(mUsername)) { + return R.string.error_empty_username; } if(!mUseDefaultRoute && getCustomRoutes()==null) return R.string.custom_route_format_error; -- cgit v1.2.3