From ccd5b7e72cc35fd95d21a63dfcdb22ce9a738992 Mon Sep 17 00:00:00 2001
From: Arne Schwabe <arne@rfc2549.org>
Date: Thu, 21 Jan 2021 12:25:06 +0100
Subject: Make Coverity happy

Most of these things are minor to the point that changing them is
only to make the scanner happy.
---
 .../main/java/de/blinkt/openvpn/remote/MainFragment.java   | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'remoteExample/src/main')

diff --git a/remoteExample/src/main/java/de/blinkt/openvpn/remote/MainFragment.java b/remoteExample/src/main/java/de/blinkt/openvpn/remote/MainFragment.java
index 6eb85e9b..c450bf22 100644
--- a/remoteExample/src/main/java/de/blinkt/openvpn/remote/MainFragment.java
+++ b/remoteExample/src/main/java/de/blinkt/openvpn/remote/MainFragment.java
@@ -78,22 +78,22 @@ public class MainFragment extends Fragment implements View.OnClickListener, Hand
     {
         try {
             InputStream conf = getActivity().getAssets().open("test.conf");
-            InputStreamReader isr = new InputStreamReader(conf);
-            BufferedReader br = new BufferedReader(isr);
-            String config="";
+            BufferedReader br = new BufferedReader(new InputStreamReader(conf));
+            StringBuilder config= new StringBuilder();
             String line;
             while(true) {
                 line = br.readLine();
                 if(line == null)
                     break;
-                config += line + "\n";
+                config.append(line).append("\n");
             }
-            br.readLine();
+            br.close();
+            conf.close();
 
             if (addNew)
-                mService.addNewVPNProfile("nonEditable", false, config);
+                mService.addNewVPNProfile("nonEditable", false, config.toString());
             else
-                mService.startVPN(config);
+                mService.startVPN(config.toString());
         } catch (IOException | RemoteException e) {
             e.printStackTrace();
         }
-- 
cgit v1.2.3