diff options
author | Adam Kocoloski <kocolosk@apache.org> | 2009-07-16 20:40:59 +0000 |
---|---|---|
committer | Adam Kocoloski <kocolosk@apache.org> | 2009-07-16 20:40:59 +0000 |
commit | 4d99f60a9fcc93e45eb5670c0dd8cc0b71820f77 (patch) | |
tree | 1002df1fd811c0ecd9852279072f6e83394dba41 /src/couchdb/couch_view_group.erl | |
parent | c8b74127b475cd6ac13a832295a73feb49826231 (diff) |
checkpoint long-running view updates
Improves stale=ok view queries, which will now see gradually updating indexes.
Also reduces the consequences of an updater crash because we can restart from
the latest checkpoint.
git-svn-id: https://svn.apache.org/repos/asf/couchdb/trunk@794843 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'src/couchdb/couch_view_group.erl')
-rw-r--r-- | src/couchdb/couch_view_group.erl | 30 |
1 files changed, 24 insertions, 6 deletions
diff --git a/src/couchdb/couch_view_group.erl b/src/couchdb/couch_view_group.erl index fa4e832e..c4b495b0 100644 --- a/src/couchdb/couch_view_group.erl +++ b/src/couchdb/couch_view_group.erl @@ -89,7 +89,8 @@ init({InitArgs, ReturnPid, Ref}) -> case prepare_group(InitArgs, false) of {ok, #group{db=Db, fd=Fd}=Group} -> couch_db:monitor(Db), - Pid = spawn_link(fun()-> couch_view_updater:update(Group) end), + Owner = self(), + Pid = spawn_link(fun()-> couch_view_updater:update(Owner, Group) end), {ok, RefCounter} = couch_ref_counter:start([Fd]), {ok, #group_state{ db_name=couch_db:name(Db), @@ -127,7 +128,8 @@ handle_call({request_group, RequestSeq}, From, }=State) when RequestSeq > Seq -> {ok, Db} = couch_db:open(DbName, []), Group2 = Group#group{db=Db}, - Pid = spawn_link(fun()-> couch_view_updater:update(Group2) end), + Owner = self(), + Pid = spawn_link(fun()-> couch_view_updater:update(Owner, Group2) end), {noreply, State#group_state{ updater_pid=Pid, @@ -205,7 +207,7 @@ handle_cast({compact_done, NewGroup}, #group_state{ {ok, Db} = couch_db:open(DbName, []), Pid = spawn_link(fun() -> {_,Ref} = erlang:spawn_monitor(fun() -> - couch_view_updater:update(NewGroup#group{db = Db}) + couch_view_updater:update(nil, NewGroup#group{db = Db}) end), receive {'DOWN', Ref, _, _, {new_group, NewGroup2}} -> @@ -214,7 +216,21 @@ handle_cast({compact_done, NewGroup}, #group_state{ gen_server:cast(Pid2, {compact_done, NewGroup2}) end end), - {noreply, State#group_state{compactor_pid = Pid}}. + {noreply, State#group_state{compactor_pid = Pid}}; + +handle_cast({partial_update, NewGroup}, State) -> + #group_state{ + db_name = DbName, + waiting_commit = WaitingCommit + } = State, + NewSeq = NewGroup#group.current_seq, + ?LOG_INFO("checkpointing view update at seq ~p for ~s ~s", [NewSeq, + DbName, NewGroup#group.name]), + if not WaitingCommit -> + erlang:send_after(1000, self(), delayed_commit); + true -> ok + end, + {noreply, State#group_state{group=NewGroup, waiting_commit=true}}. handle_info(delayed_commit, #group_state{db_name=DbName,group=Group}=State) -> {ok, Db} = couch_db:open(DbName, []), @@ -254,7 +270,8 @@ handle_info({'EXIT', FromPid, {new_group, #group{db=Db}=Group}}, % we still have some waiters, reopen the database and reupdate the index {ok, Db2} = couch_db:open(DbName, []), Group2 = Group#group{db=Db2}, - Pid = spawn_link(fun() -> couch_view_updater:update(Group2) end), + Owner = self(), + Pid = spawn_link(fun() -> couch_view_updater:update(Owner, Group2) end), {noreply, State#group_state{waiting_commit=true, waiting_list=StillWaiting, group=Group2, updater_pid=Pid}} end; @@ -267,7 +284,8 @@ handle_info({'EXIT', FromPid, reset}, ok = couch_db:close(Group#group.db), case prepare_group(InitArgs, true) of {ok, ResetGroup} -> - Pid = spawn_link(fun()-> couch_view_updater:update(ResetGroup) end), + Owner = self(), + Pid = spawn_link(fun()-> couch_view_updater:update(Owner, ResetGroup) end), {noreply, State#group_state{ updater_pid=Pid, group=ResetGroup}}; |