diff options
author | Paul Joseph Davis <davisp@apache.org> | 2009-04-25 18:29:15 +0000 |
---|---|---|
committer | Paul Joseph Davis <davisp@apache.org> | 2009-04-25 18:29:15 +0000 |
commit | 37541bbf91d09ad0200f2c26c7a3f79fdf050801 (patch) | |
tree | 0a5b6020ef6a719778a5f8a36838e496f63a39a2 | |
parent | e5be78e42c38b5546d68d98e4b1db286600e9ed5 (diff) |
Resolves COUCHDB-331 - Allow reduce=true&include_docs=false
git-svn-id: https://svn.apache.org/repos/asf/couchdb/trunk@768573 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r-- | share/www/script/test/view_include_docs.js | 5 | ||||
-rw-r--r-- | src/couchdb/couch_httpd_view.erl | 4 |
2 files changed, 8 insertions, 1 deletions
diff --git a/share/www/script/test/view_include_docs.js b/share/www/script/test/view_include_docs.js index 2c47b696..4d19bf55 100644 --- a/share/www/script/test/view_include_docs.js +++ b/share/www/script/test/view_include_docs.js @@ -79,6 +79,11 @@ couchTests.view_include_docs = function(debug) { resp = db.view('test/summate', {reduce: false, include_docs: true}); T(resp.rows.length == 100); + // Not an error with include_docs=false&reduce=true + resp = db.view('test/summate', {reduce: true, include_docs: false}); + T(resp.rows.length == 1); + T(resp.rows[0].value == 4950); + // Check emitted _rev controls things resp = db.allDocs({include_docs: true}, ["0"]); var before = resp.rows[0].doc; diff --git a/src/couchdb/couch_httpd_view.erl b/src/couchdb/couch_httpd_view.erl index 7f875051..7907f68f 100644 --- a/src/couchdb/couch_httpd_view.erl +++ b/src/couchdb/couch_httpd_view.erl @@ -409,7 +409,7 @@ validate_view_query(reduce, _, Args) -> _ -> Args end; -validate_view_query(include_docs, _Value, Args) -> +validate_view_query(include_docs, true, Args) -> case Args#view_query_args.view_type of reduce -> Msg = <<"Query paramter `include_docs` " @@ -418,6 +418,8 @@ validate_view_query(include_docs, _Value, Args) -> _ -> Args#view_query_args{include_docs=true} end; +validate_view_query(include_docs, _Value, Args) -> + Args; validate_view_query(extra, {Key, _}, Args) -> case Args#view_query_args.ignore of strict -> |