summaryrefslogtreecommitdiff
path: root/src/leap/platform_init
diff options
context:
space:
mode:
Diffstat (limited to 'src/leap/platform_init')
-rw-r--r--src/leap/platform_init/initializers.py16
1 files changed, 8 insertions, 8 deletions
diff --git a/src/leap/platform_init/initializers.py b/src/leap/platform_init/initializers.py
index cf7e71b8..91c7086b 100644
--- a/src/leap/platform_init/initializers.py
+++ b/src/leap/platform_init/initializers.py
@@ -103,7 +103,6 @@ def WindowsInitializer():
inf_path = os.path.join(driver_path,
"OemWin2k.inf")
cmd = [dev_installer, "install", inf_path, "tap0901"]
- # XXX should avoid shell expansion.
ret = subprocess.call(cmd, stdout=subprocess.PIPE, shell=True)
else:
logger.error("Tried to install TAP driver, but the installer "
@@ -120,8 +119,9 @@ def _darwin_has_tun_kext():
has_kext = os.path.isdir("/System/Library/Extensions/tun.kext")
has_startup = os.path.isdir("/System/Library/StartupItems/tun")
has_tun_and_startup = has_kext and has_startup
- logger.debug('platform initializer check: has tun_and_startup = %s' %
- (has_tun_and_startup,))
+ logger.debug(
+ 'platform initializer check: has tun_and_startup = %s' %
+ (has_tun_and_startup,))
return has_tun_and_startup
@@ -155,14 +155,14 @@ def DarwinInitializer():
ret = msg.exec_()
if ret == QtGui.QMessageBox.Yes:
- installer_path = os.path.join(os.getcwd(),
- "..",
- "Resources",
- "tuntap-installer.app")
+ installer_path = os.path.join(
+ os.getcwd(),
+ "..",
+ "Resources",
+ "tuntap-installer.app")
if os.path.isdir(installer_path):
cmd = ["open %s" % (installer_path,)]
try:
- # XXX should avoid shell expansion
ret = subprocess.call(
cmd, stdout=subprocess.PIPE,
shell=True)