diff options
| author | Kali Kaneko <kali@leap.se> | 2014-11-07 20:14:51 +0100 |
|---|---|---|
| committer | Ivan Alejandro <ivanalejandro0@gmail.com> | 2014-11-12 16:07:37 -0300 |
| commit | 26ec219c305d2033457b3c2689d918a49815f0f6 (patch) | |
| tree | 15be3c144447164ff297f1d5a09fb119ad0f8784 | |
| parent | b13193406f81c80d12fc185a135e7df38b173648 (diff) | |
Do not use logger.exception during provider checks.
Closes: #6219
leap log handler was choking on the captured exception.
it might have to do with the exception unwinding made by the reactor.
this is a workaround to allow the provider checks to show a meaningful
error message. The backtrace should only be there for development
purpuses, so removing it.
| -rw-r--r-- | src/leap/bitmask/provider/providerbootstrapper.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/leap/bitmask/provider/providerbootstrapper.py b/src/leap/bitmask/provider/providerbootstrapper.py index 71edbb87..8eefb9d9 100644 --- a/src/leap/bitmask/provider/providerbootstrapper.py +++ b/src/leap/bitmask/provider/providerbootstrapper.py @@ -148,7 +148,6 @@ class ProviderBootstrapper(AbstractBootstrapper): timeout=REQUEST_TIMEOUT) res.raise_for_status() except requests.exceptions.SSLError as exc: - logger.exception(exc) self._err_msg = self.tr("Provider certificate could " "not be verified") raise @@ -156,7 +155,6 @@ class ProviderBootstrapper(AbstractBootstrapper): # XXX careful!. The error might be also a SSL handshake # timeout error, in which case we should retry a couple of times # more, for cases where the ssl server gives high latencies. - logger.exception(exc) self._err_msg = self.tr("Provider does not support HTTPS") raise |