diff options
| author | kali <kali@leap.se> | 2013-04-09 00:06:27 +0900 |
|---|---|---|
| committer | kali <kali@leap.se> | 2013-04-09 00:06:27 +0900 |
| commit | 3b253461e79f286f29b890cd0e4adb94c2695393 (patch) | |
| tree | 54bad98bd231cc87fcc11a3338d8068b1e982bbc | |
| parent | 2c4cbe8f0e77e0b7cb08fd2dec3cd43bab6ac62e (diff) | |
add TODO about refactor install dialog
| -rw-r--r-- | src/leap/platform_init/initializers.py | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/leap/platform_init/initializers.py b/src/leap/platform_init/initializers.py index 3cb19fc6..055c90a2 100644 --- a/src/leap/platform_init/initializers.py +++ b/src/leap/platform_init/initializers.py @@ -124,6 +124,7 @@ def _darwin_has_tun_kext(): (has_tun_and_startup,)) return has_tun_and_startup + def DarwinInitializer(): """ Raises a dialog in case that the osx tuntap driver has not been found @@ -133,6 +134,11 @@ def DarwinInitializer(): "is not found inside this bundle.") BADEXEC_MSG = ("Tried to install tuntaposx kext, but the installer " "failed to be launched.") + + # TODO DRY this with other cases, and + # factor out to _should_install() function. + # Leave the dialog as a more generic thing. + if not _darwin_has_tun_kext(): msg = QtGui.QMessageBox() msg.setWindowTitle(msg.tr("TUN Driver")) |