From eab561951adcc46f32b93bd788b4f0ba120d7582 Mon Sep 17 00:00:00 2001
From: cyBerta <cyberta@riseup.net>
Date: Sat, 19 Oct 2019 02:06:06 +0200
Subject: don't show error dialogs for internally handled EIP errors

---
 .../java/se/leap/bitmaskclient/MainActivity.java   | 35 +++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

(limited to 'app')

diff --git a/app/src/main/java/se/leap/bitmaskclient/MainActivity.java b/app/src/main/java/se/leap/bitmaskclient/MainActivity.java
index b163f1dd..ad7c8ae3 100644
--- a/app/src/main/java/se/leap/bitmaskclient/MainActivity.java
+++ b/app/src/main/java/se/leap/bitmaskclient/MainActivity.java
@@ -50,12 +50,14 @@ import static se.leap.bitmaskclient.Constants.REQUEST_CODE_CONFIGURE_LEAP;
 import static se.leap.bitmaskclient.Constants.REQUEST_CODE_LOG_IN;
 import static se.leap.bitmaskclient.Constants.REQUEST_CODE_SWITCH_PROVIDER;
 import static se.leap.bitmaskclient.Constants.SHARED_PREFERENCES;
+import static se.leap.bitmaskclient.ProviderAPI.ERRORID;
 import static se.leap.bitmaskclient.ProviderAPI.ERRORS;
 import static se.leap.bitmaskclient.ProviderAPI.INCORRECTLY_DOWNLOADED_EIP_SERVICE;
 import static se.leap.bitmaskclient.ProviderAPI.INCORRECTLY_UPDATED_INVALID_VPN_CERTIFICATE;
 import static se.leap.bitmaskclient.ProviderAPI.USER_MESSAGE;
 import static se.leap.bitmaskclient.R.string.downloading_vpn_certificate_failed;
 import static se.leap.bitmaskclient.R.string.vpn_certificate_user_message;
+import static se.leap.bitmaskclient.eip.EIP.EIPErrors.ERROR_INVALID_VPN_CERTIFICATE;
 import static se.leap.bitmaskclient.utils.PreferenceHelper.storeProviderInPreferences;
 
 
@@ -234,9 +236,13 @@ public class MainActivity extends AppCompatActivity implements EipSetupListener,
             case EIP_ACTION_START:
                 if (resultCode == RESULT_CANCELED) {
                     String error = resultData.getString(ERRORS);
+                    if (isInternalErrorHandling(error)) {
+                        return;
+                    }
+
                     if (LeapSRPSession.loggedIn() || provider.allowsAnonymous()) {
                         showMainActivityErrorDialog(error);
-                    } else {
+                    } else if (isInvalidCertificateForLoginOnlyProvider(error)) {
                         askUserToLogIn(getString(vpn_certificate_user_message));
                     }
                 }
@@ -294,6 +300,33 @@ public class MainActivity extends AppCompatActivity implements EipSetupListener,
 
     }
 
+    /**
+     *
+     * @param errorJsonString
+     * @return true if errorJson is a valid json and contains only ERRORID but
+     * not an ERRORS field containing an error message
+     */
+    public boolean isInternalErrorHandling(String errorJsonString) {
+        try {
+            JSONObject errorJson = new JSONObject(errorJsonString);
+            return !errorJson.has(ERRORS) && errorJson.has(ERRORID);
+        } catch (JSONException | NullPointerException e) {
+            e.printStackTrace();
+        }
+        return false;
+    }
+
+    public boolean isInvalidCertificateForLoginOnlyProvider(String errorJsonString) {
+        try {
+            JSONObject errorJson = new JSONObject(errorJsonString);
+            return  ERROR_INVALID_VPN_CERTIFICATE.toString().equals(errorJson.getString(ERRORID)) &&
+                    !LeapSRPSession.loggedIn() &&
+                    !provider.allowsAnonymous();
+        } catch (JSONException e) {
+            e.printStackTrace();
+        }
+        return false;
+    }
 
     private void askUserToLogIn(String userMessage) {
         Intent intent = new Intent(this, LoginActivity.class);
-- 
cgit v1.2.3