From 5d28fc6602a214da51931e428112825117b2509f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Mon, 17 Nov 2014 19:54:51 +0100 Subject: An empty certificate is valid. If there is no certificate, there is no need to fix it. Right now, we use this class just to know if we need to update the certificate or redownload it. In case the certificate is corrupted, then it won't be empty but will contain an error message. If there is no certificate (e.g., because the user hasn't logged in and the provider doesn't provide anon vpn), then the "certificate" is ok but an upper layer of the code will have to handle the situation (in this case, eip will detect that there is no certificate and that the user needs to log in, prompting it to do so). --- .../main/java/se/leap/bitmaskclient/eip/VpnCertificateValidator.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app') diff --git a/app/src/main/java/se/leap/bitmaskclient/eip/VpnCertificateValidator.java b/app/src/main/java/se/leap/bitmaskclient/eip/VpnCertificateValidator.java index a5f04368..16ae6a85 100644 --- a/app/src/main/java/se/leap/bitmaskclient/eip/VpnCertificateValidator.java +++ b/app/src/main/java/se/leap/bitmaskclient/eip/VpnCertificateValidator.java @@ -31,7 +31,7 @@ public class VpnCertificateValidator { if(!certificate.isEmpty()) { X509Certificate certificate_x509 = ConfigHelper.parseX509CertificateFromString(certificate); return isValid(certificate_x509); - } else return false; + } else return true; } private boolean isValid(X509Certificate certificate) { -- cgit v1.2.3