From 2d2c035a77586962e26ba2259012584ec6320448 Mon Sep 17 00:00:00 2001 From: cyBerta Date: Wed, 4 Dec 2013 18:33:55 +0100 Subject: remove translations for LEAP for Android --- res/values-ca/strings.xml | 1 - res/values-cs/strings.xml | 1 - res/values-de/strings.xml | 1 - res/values-es/strings.xml | 1 - res/values-et/strings.xml | 1 - res/values-fr/strings.xml | 1 - res/values-id/strings.xml | 1 - res/values-it/strings.xml | 1 - res/values-ja/strings.xml | 1 - res/values-ko/strings.xml | 1 - res/values-nl/strings.xml | 1 - res/values-no/strings.xml | 1 - res/values-ro/strings.xml | 1 - res/values-ru/strings.xml | 1 - res/values-uk/strings.xml | 1 - res/values-zh-rCN/strings.xml | 1 - res/values-zh-rTW/strings.xml | 1 - res/values/strings.xml | 2 -- res/values/untranslatable.xml | 4 +++- 19 files changed, 3 insertions(+), 20 deletions(-) diff --git a/res/values-ca/strings.xml b/res/values-ca/strings.xml index 5131250a..e6ed93b7 100755 --- a/res/values-ca/strings.xml +++ b/res/values-ca/strings.xml @@ -1,7 +1,6 @@ - LEAP per Android Adreá del servidor: Port del servidor: Lloc diff --git a/res/values-cs/strings.xml b/res/values-cs/strings.xml index 37ae7f40..8bbb591d 100755 --- a/res/values-cs/strings.xml +++ b/res/values-cs/strings.xml @@ -1,7 +1,6 @@ - LEAP pro Android Adresa serveru: Port serveru: Lokace diff --git a/res/values-de/strings.xml b/res/values-de/strings.xml index df50b594..501bf4d2 100755 --- a/res/values-de/strings.xml +++ b/res/values-de/strings.xml @@ -1,7 +1,6 @@ - LEAP für Android Server: Server Port: Ort diff --git a/res/values-es/strings.xml b/res/values-es/strings.xml index 36fcc199..7d5a92fb 100755 --- a/res/values-es/strings.xml +++ b/res/values-es/strings.xml @@ -1,7 +1,6 @@ - LEAP para Android Dirección del servidor: Puerto del servidor: Ubicación diff --git a/res/values-et/strings.xml b/res/values-et/strings.xml index b0758d74..ac44dd15 100755 --- a/res/values-et/strings.xml +++ b/res/values-et/strings.xml @@ -1,7 +1,6 @@ - LEAP Androidile Serveri aadress: Serveri port: Asukoht diff --git a/res/values-fr/strings.xml b/res/values-fr/strings.xml index ec36bc8b..41facf4b 100755 --- a/res/values-fr/strings.xml +++ b/res/values-fr/strings.xml @@ -1,7 +1,6 @@ - "LEAP pour Android" "Adresse du serveur:" "Port:" "Emplacement" diff --git a/res/values-id/strings.xml b/res/values-id/strings.xml index 0166b7ea..3ea805c3 100755 --- a/res/values-id/strings.xml +++ b/res/values-id/strings.xml @@ -1,7 +1,6 @@ - LEAP untuk Android Alamat Server: Port server: Lokasi diff --git a/res/values-it/strings.xml b/res/values-it/strings.xml index 1e935bf2..ee50f56e 100755 --- a/res/values-it/strings.xml +++ b/res/values-it/strings.xml @@ -1,7 +1,6 @@ - LEAP per Android Indirizzo server: Porta del server: Posizione diff --git a/res/values-ja/strings.xml b/res/values-ja/strings.xml index db7602f7..cc767479 100755 --- a/res/values-ja/strings.xml +++ b/res/values-ja/strings.xml @@ -1,7 +1,6 @@ - LEAP Android サーバアドレス ポート番号 場所 diff --git a/res/values-ko/strings.xml b/res/values-ko/strings.xml index 4cd9da70..07d63ed4 100755 --- a/res/values-ko/strings.xml +++ b/res/values-ko/strings.xml @@ -1,7 +1,6 @@ - 안드로이드용 LEAP 서버 주소: 서버 포트: 위치 diff --git a/res/values-nl/strings.xml b/res/values-nl/strings.xml index 459c80ec..2aa78bb7 100755 --- a/res/values-nl/strings.xml +++ b/res/values-nl/strings.xml @@ -1,7 +1,6 @@ - LEAP voor Android Server Adres: Server Poort: Locatie diff --git a/res/values-no/strings.xml b/res/values-no/strings.xml index 99b97277..ce3518d1 100755 --- a/res/values-no/strings.xml +++ b/res/values-no/strings.xml @@ -1,7 +1,6 @@ - LEAP Android Server adresse: Server port: Plassering diff --git a/res/values-ro/strings.xml b/res/values-ro/strings.xml index 308a47ac..a81915f9 100755 --- a/res/values-ro/strings.xml +++ b/res/values-ro/strings.xml @@ -1,7 +1,6 @@ - LEAP pentru Android Adresa server: Port server: Locaţie diff --git a/res/values-ru/strings.xml b/res/values-ru/strings.xml index 1d3c10a3..59642c02 100755 --- a/res/values-ru/strings.xml +++ b/res/values-ru/strings.xml @@ -1,7 +1,6 @@ - LEAP для Android Адрес сервера: Порт сервера: Расположение diff --git a/res/values-uk/strings.xml b/res/values-uk/strings.xml index 14d9ce90..558bf6d5 100755 --- a/res/values-uk/strings.xml +++ b/res/values-uk/strings.xml @@ -1,7 +1,6 @@ - LEAP для Android Адреса сервера: Порт сервера: Розташування diff --git a/res/values-zh-rCN/strings.xml b/res/values-zh-rCN/strings.xml index 89d3aeab..4378c06e 100755 --- a/res/values-zh-rCN/strings.xml +++ b/res/values-zh-rCN/strings.xml @@ -1,7 +1,6 @@ - LEAP Android版 服务器地址： 服务器端口： 地点 diff --git a/res/values-zh-rTW/strings.xml b/res/values-zh-rTW/strings.xml index 2d2f31ca..d0eb9a5c 100755 --- a/res/values-zh-rTW/strings.xml +++ b/res/values-zh-rTW/strings.xml @@ -1,7 +1,6 @@ - LEAP Android 伺服器地址: 伺服器端口: 位置 diff --git a/res/values/strings.xml b/res/values/strings.xml index 2598d452..60124215 100755 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -2,8 +2,6 @@ - Bitmask - Bitmask Server Address: Server Port: Location diff --git a/res/values/untranslatable.xml b/res/values/untranslatable.xml index fe620aa8..8c15a213 100644 --- a/res/values/untranslatable.xml +++ b/res/values/untranslatable.xml @@ -1,6 +1,8 @@ - + Bitmask + Bitmask + Copyright 2012\nLEAP Encryption Access Project <info@leap.se> Copyright © 2002–2010 OpenVPN Technologies, Inc. <sales@openvpn.net>\n -- cgit v1.2.3 From 3b8bcb1383ec4e9deecd7a6d97180e60a3bf021a Mon Sep 17 00:00:00 2001 From: cyBerta Date: Wed, 4 Dec 2013 20:49:23 +0100 Subject: about bitmask instead of about LEAP --- res/values-ca/strings.xml | 2 +- res/values-cs/strings.xml | 2 +- res/values-de/strings.xml | 2 +- res/values-es/strings.xml | 2 +- res/values-et/strings.xml | 2 +- res/values-fr/strings.xml | 2 +- res/values-id/strings.xml | 2 +- res/values-it/strings.xml | 2 +- res/values-ja/strings.xml | 2 +- res/values-ko/strings.xml | 2 +- res/values-nl/strings.xml | 2 +- res/values-no/strings.xml | 2 +- res/values-ro/strings.xml | 2 +- res/values-ru/strings.xml | 2 +- res/values-uk/strings.xml | 2 +- res/values-zh-rCN/strings.xml | 2 +- res/values-zh-rTW/strings.xml | 2 +- res/values/strings.xml | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/res/values-ca/strings.xml b/res/values-ca/strings.xml index e6ed93b7..0840c365 100755 --- a/res/values-ca/strings.xml +++ b/res/values-ca/strings.xml @@ -14,7 +14,7 @@ Fitxer PKCS12 Certificat CA Quan a - Quan a LEAP per Android + Quan a Bitmask per Android Llista de VPNs configurades Perfils VPN Tipus diff --git a/res/values-cs/strings.xml b/res/values-cs/strings.xml index 8bbb591d..85a4f8a2 100755 --- a/res/values-cs/strings.xml +++ b/res/values-cs/strings.xml @@ -18,7 +18,7 @@ Zdrojové kódy a seznam problémů je na https://github.com/leapcode/bitmask_android/ Tento program používá následující komponenty; viz zdrojový kód pro detaily o licenci O programu - O programu LEAP pro Android + O programu Bitmask pro Android Seznam všech nakonfigurovaných VPN Všechny VPN Typ diff --git a/res/values-de/strings.xml b/res/values-de/strings.xml index 501bf4d2..fdad6103 100755 --- a/res/values-de/strings.xml +++ b/res/values-de/strings.xml @@ -18,7 +18,7 @@ Quellcode und Issue Tracker sind verfügbar unter https://github.com/leapcode/bitmask_android/ Dieses Programm nutzt die folgenden Komponenten. Die kompletten Lizenzdetails sind im Quelltext verfügbar. Über - Über LEAP für Android + Über Bitmask für Android Alle konfigurierten VPN Profile VPN Liste Typ diff --git a/res/values-es/strings.xml b/res/values-es/strings.xml index 7d5a92fb..e8398560 100755 --- a/res/values-es/strings.xml +++ b/res/values-es/strings.xml @@ -18,7 +18,7 @@ Codigo fuente y sistema de reporte de errores disponibles en https://github.com/leapcode/bitmask_android/ El programa utiliza los siguientes componentes. Vea los códigos fuentes para obtener más información sobre las licencias Acerca de - Acerca de LEAP para Android + Acerca de Bitmask para Android Lista de todas las VPN configuradas Perfiles VPN Tipo diff --git a/res/values-et/strings.xml b/res/values-et/strings.xml index ac44dd15..dba6caa4 100755 --- a/res/values-et/strings.xml +++ b/res/values-et/strings.xml @@ -18,7 +18,7 @@ Lähtetekst ja probleemihaldur asuvad veebilehel https://github.com/leapcode/bitmask_android/ Programmis kasutatakse järgnevaid komponente. Detailse litsenseerimisinfo leiate lähtekoodist Lähemalt - Täpsemalt programmist LEAP Androidile + Täpsemalt programmist Bitmask Androidile Kõigi seadistatud VPN kanalite nimekiri VPN profiilid Tüüp diff --git a/res/values-fr/strings.xml b/res/values-fr/strings.xml index 41facf4b..6ed418ff 100755 --- a/res/values-fr/strings.xml +++ b/res/values-fr/strings.xml @@ -18,7 +18,7 @@ "Le code source et le tracker de bugs est disponible ici: https://github.com/leapcode/bitmask_android/ " "Le programme utilise les composants suivants. Voir le code source pour plus de détails sur les licences." "À propos" - "À propos d\'LEAP pour Android" + "À propos d\'Bitmask pour Android" "Liste de tous les VPN configurés" "Vos VPNs" "Type" diff --git a/res/values-id/strings.xml b/res/values-id/strings.xml index 3ea805c3..f4e49938 100755 --- a/res/values-id/strings.xml +++ b/res/values-id/strings.xml @@ -18,7 +18,7 @@ Kode program dan perekam masalah tersedia di Aplikasi memakai komponen berikut; lihat kode program untuk lebih jelas mengenai lisensi Tentang... - Tentang LEAP untuk Android + Tentang Bitmask untuk Android Daftar konfigurasi VPN Profil VPN Tipe diff --git a/res/values-it/strings.xml b/res/values-it/strings.xml index ee50f56e..341d4d50 100755 --- a/res/values-it/strings.xml +++ b/res/values-it/strings.xml @@ -18,7 +18,7 @@ Il codice sorgente e il bug tracker sono disponibili all\'indirizzo https://github.com/leapcode/bitmask_android/ Questo programma usa i seguenti componenti; guarda il codice sorgente per i dettagli completi sulle licenze Informazioni - Informazioni su LEAP per Android + Informazioni su Bitmask per Android Elenco connessioni VPN configurate Profili VPN Tipo diff --git a/res/values-ja/strings.xml b/res/values-ja/strings.xml index cc767479..00831c68 100755 --- a/res/values-ja/strings.xml +++ b/res/values-ja/strings.xml @@ -18,7 +18,7 @@ ソースコードと問題管理は以下で： https://github.com/leapcode/bitmask_android/ プログラムは、次のコンポーネントを使用します。完全な詳細についてはソース上のライセンスを参照してください。 バージョン情報 - LEAP Androidについて + Bitmask Androidについて 設定されたすべてのVPN VPNプロファイル 種別 diff --git a/res/values-ko/strings.xml b/res/values-ko/strings.xml index 07d63ed4..08c1bc26 100755 --- a/res/values-ko/strings.xml +++ b/res/values-ko/strings.xml @@ -18,7 +18,7 @@ 소스 코드와 문제 추적기는 https://github.com/leapcode/bitmask_android/에서 사용할 수 있습니다 프로그램은 다음 구성 요소를 사용합니다. 라이선스에 대 한 자세한 내용은 소스를 참조 하십시오 소개 - 안드로이드용 LEAP 소개 + 안드로이드용 Bitmask 소개 설정된 VPN의 목록 VPN 프로파일 유형 diff --git a/res/values-nl/strings.xml b/res/values-nl/strings.xml index 2aa78bb7..01eefb86 100755 --- a/res/values-nl/strings.xml +++ b/res/values-nl/strings.xml @@ -14,7 +14,7 @@ PKCS12 Bestand CA Certificaat Over - Over LEAP voor Android + Over Bitmask voor Android Lijst van alle geconfigureerde VPN verbindingen VPN Profielen Type diff --git a/res/values-no/strings.xml b/res/values-no/strings.xml index ce3518d1..a5551578 100755 --- a/res/values-no/strings.xml +++ b/res/values-no/strings.xml @@ -14,7 +14,7 @@ PKCS12 fil CA-sertifikat Om - Om LEAP Android + Om Bitmask Android Liste over alle konfigurerte VPN-tilkoblinger VPN-profiler Type diff --git a/res/values-ro/strings.xml b/res/values-ro/strings.xml index a81915f9..0b669803 100755 --- a/res/values-ro/strings.xml +++ b/res/values-ro/strings.xml @@ -18,7 +18,7 @@ Cod sursă şi tracker probleme disponibile la https://github.com/leapcode/bitmask_android/ Acest program utilizează următoarele componente; a se vedea codul sursă pentru mai multe detalii despre licente Despre - Despre LEAP pentru Android + Despre Bitmask pentru Android Lista tuturor VPN-urilor configurate Profile VPN Tip diff --git a/res/values-ru/strings.xml b/res/values-ru/strings.xml index 59642c02..009e090d 100755 --- a/res/values-ru/strings.xml +++ b/res/values-ru/strings.xml @@ -18,7 +18,7 @@ Исходники и информация о версиях находятся по адресу https://github.com/leapcode/bitmask_android/ Данная программа использует следующие компоненты; смотрите исходный код для получения подробной информации о лицензии О программе - Описание LEAP для Android + Описание Bitmask для Android Список всех туннелей VPN Профили VPN Тип diff --git a/res/values-uk/strings.xml b/res/values-uk/strings.xml index 558bf6d5..5b08be94 100755 --- a/res/values-uk/strings.xml +++ b/res/values-uk/strings.xml @@ -18,7 +18,7 @@ Початковий код і відстеження проблем доступні по https://github.com/leapcode/bitmask_android/ Ця програма використовує такі компоненти; перегляньте вихідний код для повної інформації про ліцензії Про - Про LEAP для Android + Про Bitmask для Android Список всіх налаштованих VPN VPN профілі Тип diff --git a/res/values-zh-rCN/strings.xml b/res/values-zh-rCN/strings.xml index 4378c06e..5dfc1b68 100755 --- a/res/values-zh-rCN/strings.xml +++ b/res/values-zh-rCN/strings.xml @@ -18,7 +18,7 @@ 请前往 https://github.com/leapcode/bitmask_android/ 源码或提供问题反馈 本程序使用以下组件，请在 Licenses 查看源码获取更详细内容。 关于 - 关于 LEAP Android + 关于 Bitmask Android 已完成配置的 VPN 列表 VPN 配置文件 类型 diff --git a/res/values-zh-rTW/strings.xml b/res/values-zh-rTW/strings.xml index d0eb9a5c..3d178545 100755 --- a/res/values-zh-rTW/strings.xml +++ b/res/values-zh-rTW/strings.xml @@ -18,7 +18,7 @@ 取得原始碼與個案追蹤，可上 https://github.com/leapcode/bitmask_android/ 本程序使用了以下元件，其作者和授權資訊如下 關於 - 關於 LEAP Android + 關於 Bitmask Android 列出所有已設置的VPN VPN設定檔 類型 diff --git a/res/values/strings.xml b/res/values/strings.xml index 60124215..01eab8fe 100755 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -19,7 +19,7 @@ You must select a certificate Source code and issue tracker available at https://github.com/leapcode/bitmask_android/ This program uses the following components; see the source code for full details on the licenses - About LEAP + About Bitmask Switch provider About Bitmask for Android List of all configured VPNs -- cgit v1.2.3 From 8833649c3468fce9cc40a0e94371049093c5dd7d Mon Sep 17 00:00:00 2001 From: cyBerta Date: Thu, 5 Dec 2013 01:45:51 +0100 Subject: Show location in openvpn notification message (Feature #4665) --- res/values-cs/strings.xml | 2 +- res/values-de/strings.xml | 2 +- res/values-id/strings.xml | 2 +- res/values-ja/strings.xml | 2 +- res/values-ru/strings.xml | 2 +- res/values-uk/strings.xml | 2 +- res/values/strings.xml | 2 +- src/se/leap/openvpn/OpenVpnService.java | 5 ++++- 8 files changed, 11 insertions(+), 8 deletions(-) diff --git a/res/values-cs/strings.xml b/res/values-cs/strings.xml index 37ae7f40..fc367db0 100755 --- a/res/values-cs/strings.xml +++ b/res/values-cs/strings.xml @@ -235,7 +235,7 @@ OpenVPN neočekávaně havarovalo. Zvaž možnost použití volby poslat Minidump z hlavního menu Poslat Minidump vývojáři Poslat ladící informace o poslední havárii vývojáři - OpenVPN - %s + Bitmask - %s %1$s - %2$s %1$s - %3$s, %2$s Připojuji se diff --git a/res/values-de/strings.xml b/res/values-de/strings.xml index df50b594..c99314f4 100755 --- a/res/values-de/strings.xml +++ b/res/values-de/strings.xml @@ -235,7 +235,7 @@ Der OpenVPN Prozess ist unerwartet abgestürzt. Bitte erwägen Sie die Option \"Minidump senden\" im Hauptmenü Minidump an Entwickler senden Sendet Debugging Informationen des letzten Absturzes an den Entwickler - OpenVPN - %s + Bitmask - %s %1$s - %2$s %1$s - %3$s, %2$s Verbinde diff --git a/res/values-id/strings.xml b/res/values-id/strings.xml index 0166b7ea..2851a17b 100755 --- a/res/values-id/strings.xml +++ b/res/values-id/strings.xml @@ -235,7 +235,7 @@ OpenVPN crash tak terduga. Silakan mempertimbangkan mengirim menggunakan pilihan Minidump di Menu Utama Mengirim MiniDump untuk pengembang Kirim informasi kesalahan tentang kegagalan aplikasi yang terakhir ke pengembang - OpenVPN - %s + Bitmask - %s %1$ s - %2$ s %1$ s - %3$ s, %2$ s Menghubungkan diff --git a/res/values-ja/strings.xml b/res/values-ja/strings.xml index db7602f7..b7885861 100755 --- a/res/values-ja/strings.xml +++ b/res/values-ja/strings.xml @@ -274,7 +274,7 @@ TCP keepaliveと長いタイムアウト時間は動作しますが、TCP over T OpenVPN は予期せず終了しました。メイン メニューでミニダンプの送信オプションを検討してください。 ミニダンプを開発者に送信 最後にクラッシュした時のデバッグ情報を作者に送信します。 - OpenVPN - %s + Bitmask - %s %1$s - %2$s %1$s - %3$s, %2$s 接続中 diff --git a/res/values-ru/strings.xml b/res/values-ru/strings.xml index 1d3c10a3..0bd87cd0 100755 --- a/res/values-ru/strings.xml +++ b/res/values-ru/strings.xml @@ -234,7 +234,7 @@ OpenVPN завершилась неожиданно. Пожалуйста, посмотрите опцию \"Отправить Minidump\" в главном меню Отправить Minidump разработчику Отправка отладочной информации разработчику о последнем неудачном завершении - OpenVPN - %s + Bitmask - %s %1$s - %2$s %1$s - %3$s, %2$s Подключение diff --git a/res/values-uk/strings.xml b/res/values-uk/strings.xml index 14d9ce90..f055e913 100755 --- a/res/values-uk/strings.xml +++ b/res/values-uk/strings.xml @@ -235,7 +235,7 @@ OpenVPN впав несподівано. Будь ласка, розгляньте використання параметру \"Надіслати Мінідамп\" в головному меню Надіслати мінідамп розробнику Надіслати налагоджувальну інформацію про останній збій розробнику - OpenVPN - %s + Bitmask - %s %1$s - %2$s %1$s - %3$s, %2$s Підключення diff --git a/res/values/strings.xml b/res/values/strings.xml index 2598d452..28d159b0 100755 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -239,7 +239,7 @@ OpenVPN crashed unexpectedly. Please consider using the send Minidump option in the main menu Send Minidump to developer Send debugging information about last crash to developer - OpenVPN - %s + Bitmask - %s %1$s - %2$s %1$s - %3$s, %2$s Connecting diff --git a/src/se/leap/openvpn/OpenVpnService.java b/src/se/leap/openvpn/OpenVpnService.java index 69dd56f4..f5b932f2 100644 --- a/src/se/leap/openvpn/OpenVpnService.java +++ b/src/se/leap/openvpn/OpenVpnService.java @@ -114,7 +114,7 @@ public class OpenVpnService extends VpnService implements StateListener, Callbac android.app.Notification.Builder nbuilder = new Notification.Builder(this); - nbuilder.setContentTitle(getString(R.string.notifcation_title,mProfile.mName)); + nbuilder.setContentTitle(getString(R.string.notifcation_title,mProfile.mLocation)); nbuilder.setContentText(msg); nbuilder.setOnlyAlertOnce(true); nbuilder.setOngoing(persistant); @@ -481,6 +481,9 @@ public class OpenVpnService extends VpnService implements StateListener, Callbac boolean persist = false; if (("NOPROCESS".equals(state) ) || ("EXITING").equals(state)){ showNotification(state, getString(R.string.eip_state_not_connected), ticker, false, 0, persist); + } + else if (state.equals("GET_CONFIG")){ + } else{ persist = true; -- cgit v1.2.3 From ff4d4fde206a405064e48f49edcc7ce46ca68fab Mon Sep 17 00:00:00 2001 From: cyBerta Date: Thu, 5 Dec 2013 02:22:44 +0100 Subject: Turn the login icon into simple text (Bug #4659) --- res/menu/client_dashboard.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/res/menu/client_dashboard.xml b/res/menu/client_dashboard.xml index 2ce8b87c..8f4a7ba8 100644 --- a/res/menu/client_dashboard.xml +++ b/res/menu/client_dashboard.xml @@ -17,11 +17,10 @@ + android:title="@string/switch_provider_menu_option"/> -- cgit v1.2.3 From 49535f168c32a5ef8ef187247da135a3774e4e78 Mon Sep 17 00:00:00 2001 From: Sean Leonard Date: Fri, 29 Nov 2013 19:25:06 -0800 Subject: Changelog --- CHANGELOG | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 09ad9761..0913edee 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,12 @@ +0.2.3-rc1 Nov 29 2013 +Features +- Begin integrating tests into repository +- Clearer wording in some places +- Show VPN Gateway location in notification +Bugs Fixed +- URL parsing error if http entered for custom provider + + 0.2.2 - Nov 15 2013 - the "rampant growth" release: Features - Rebranded to Bitmask @@ -11,6 +20,8 @@ Bugs Fixed - Complex certificate verification - Remember authentication status - Widget shortcut crashes app + + 0.2.1 - Oct 21 2013 - the "get on that rolling bandwagon" release: Bugs Fixed - SRP tests should be runnable localhost -- cgit v1.2.3 From 53b7ba635f8a37db6594eae135ef5fbb3a934351 Mon Sep 17 00:00:00 2001 From: Sean Leonard Date: Fri, 29 Nov 2013 19:25:54 -0800 Subject: Bump build and version --- AndroidManifest.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 2cb8766e..87cd24fe 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -17,8 +17,8 @@ + android:versionCode="63" + android:versionName="0.2.3 RC1" > -- cgit v1.2.3 From 6ba458f00be2f3ad12caf76bfb8ee95159c3d73d Mon Sep 17 00:00:00 2001 From: Sean Leonard Date: Wed, 4 Dec 2013 19:42:05 -0800 Subject: Changelog --- CHANGELOG | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 0913edee..b0f0d8e0 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -5,6 +5,8 @@ Features - Show VPN Gateway location in notification Bugs Fixed - URL parsing error if http entered for custom provider +- Issues with certificates and gateways when switching providers +- SEVERE: Routes were not set on VPN connection and traffic was routed in the clear 0.2.2 - Nov 15 2013 - the "rampant growth" release: -- cgit v1.2.3 From 73e6fe619ce54d0845dcd18e41bc5a7545c9f774 Mon Sep 17 00:00:00 2001 From: Sean Leonard Date: Wed, 4 Dec 2013 19:42:33 -0800 Subject: Bump build and version --- AndroidManifest.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 87cd24fe..bb788109 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -17,8 +17,8 @@ + android:versionCode="64" + android:versionName="0.2.3" > -- cgit v1.2.3 From 5ceb82f87fb4f94984d3720f68187bf6ba00d1e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Fri, 6 Sep 2013 12:54:24 +0200 Subject: Removing unnecessary fields from ProviderItem. I'm targeting to refactor the whole ProviderItem class because I've not used the Provider class so far and I should not duplicate information from "Provider" into "ProviderItem". --- src/se/leap/bitmaskclient/ConfigurationWizard.java | 27 ++++---- src/se/leap/bitmaskclient/ProviderListContent.java | 77 ++++++---------------- 2 files changed, 35 insertions(+), 69 deletions(-) diff --git a/src/se/leap/bitmaskclient/ConfigurationWizard.java b/src/se/leap/bitmaskclient/ConfigurationWizard.java index 4a3bb12b..532debfd 100644 --- a/src/se/leap/bitmaskclient/ConfigurationWizard.java +++ b/src/se/leap/bitmaskclient/ConfigurationWizard.java @@ -175,13 +175,14 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn //Toast.makeText(this, getResources().getString(R.string.config_error_parsing), Toast.LENGTH_LONG); setResult(RESULT_CANCELED, mConfigState); } - } + } else if(resultCode == ProviderAPI.INCORRECTLY_UPDATED_PROVIDER_DOT_JSON) { String reason_to_fail = resultData.getString(ProviderAPI.ERRORS); showDownloadFailedDialog(getCurrentFocus(), reason_to_fail); refreshProviderList(0); mProgressBar.setVisibility(ProgressBar.GONE); progressbar_description.setVisibility(TextView.GONE); + ConfigHelper.removeFromSharedPref(Provider.KEY); setResult(RESULT_CANCELED, mConfigState); } else if(resultCode == ProviderAPI.CORRECTLY_DOWNLOADED_JSON_FILES) { @@ -237,8 +238,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn int provider_index = getProviderIndex(id); startProgressBar(provider_index); mSelectedProvider = selected_provider; - - saveProviderJson(mSelectedProvider); + updateProviderDotJson(mSelectedProvider.name(), mSelectedProvider.providerJsonUrl(), mSelectedProvider.completelyTrusted()); } @Override @@ -265,7 +265,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn Iterator providers_iterator = ProviderListContent.ITEMS.iterator(); while(providers_iterator.hasNext()) { ProviderItem provider = providers_iterator.next(); - if(provider.id.equalsIgnoreCase(id)) { + if(provider.name().equalsIgnoreCase(id)) { return provider; } } @@ -343,7 +343,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn return loaded_preseeded_providers; } - /** + /** * Saves provider.json file associated with provider. * * If the provider is custom, the file has already been downloaded so we load it from memory. @@ -353,18 +353,19 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn private void saveProviderJson(ProviderItem provider) { JSONObject provider_json = new JSONObject(); try { - if(!provider.custom) { - updateProviderDotJson(provider.name, provider.provider_json_url, provider.danger_on); + if(!provider.custom()) { + updateProviderDotJson(mSelectedProvider.name(), provider.providerJsonUrl(), provider.completelyTrusted()); } else { // FIXME!! We should we be updating our seeded providers list at ConfigurationWizard onStart() ? // I think yes, but if so, where does this list live? leap.se, as it's the non-profit project for the software? // If not, we should just be getting names/urls, and fetching the provider.json like in custom entries - provider_json = provider.provider_json; + provider_json = ConfigHelper.getJsonFromSharedPref(Provider.KEY); ConfigHelper.saveSharedPref(Provider.KEY, provider_json); ConfigHelper.saveSharedPref(EIP.ALLOWED_ANON, provider_json.getJSONObject(Provider.SERVICE).getBoolean(EIP.ALLOWED_ANON)); - ConfigHelper.saveSharedPref(ProviderItem.DANGER_ON, provider.danger_on); + ConfigHelper.saveSharedPref(ProviderItem.DANGER_ON, provider.completelyTrusted()); mProgressBar.incrementProgressBy(1); + downloadJSONFiles(mSelectedProvider); } } catch (JSONException e) { @@ -373,7 +374,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn } } - /** + /** * Asks ProviderAPI to download provider site's certificate and eip-service.json * * URLs are fetched from the provider parameter @@ -382,12 +383,12 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn private void downloadJSONFiles(ProviderItem provider) { Intent provider_API_command = new Intent(this, ProviderAPI.class); - Bundle parameters = new Bundle(); + Bundle parameters = new Bundle(); - parameters.putString(Provider.KEY, provider.name); + parameters.putString(Provider.KEY, provider.name()); parameters.putString(Provider.CA_CERT, provider.cert_json_url); parameters.putString(EIP.KEY, provider.eip_service_json_url); - parameters.putBoolean(ProviderItem.DANGER_ON, provider.danger_on); + parameters.putBoolean(ProviderItem.DANGER_ON, provider.completelyTrusted()); provider_API_command.setAction(ProviderAPI.DOWNLOAD_JSON_FILES_BUNDLE_EXTRA); provider_API_command.putExtra(ProviderAPI.PARAMETERS, parameters); diff --git a/src/se/leap/bitmaskclient/ProviderListContent.java b/src/se/leap/bitmaskclient/ProviderListContent.java index 75d91733..42cac792 100644 --- a/src/se/leap/bitmaskclient/ProviderListContent.java +++ b/src/se/leap/bitmaskclient/ProviderListContent.java @@ -55,23 +55,14 @@ public class ProviderListContent { /** * A provider item. - */ + */ public static class ProviderItem { - - final public static String CUSTOM = "custom"; final public static String DANGER_ON = "danger_on"; - - public boolean custom = false; - public String id; - public String name; - public String domain; - public String provider_json_url; - public JSONObject provider_json; - public String provider_json_filename; - public String eip_service_json_url; - public String cert_json_url; - public boolean danger_on = false; + private boolean custom = false; + private String provider_json_url; + private String name; + private boolean danger_on = false; /** * @param name of the provider @@ -85,19 +76,11 @@ public class ProviderListContent { byte[] urls_file_bytes = new byte[urls_file_input_stream.available()]; urls_file_input_stream.read(urls_file_bytes); String urls_file_content = new String(urls_file_bytes); - JSONObject file_contents = new JSONObject(urls_file_content); - id = name; - this.name = name; + JSONObject file_contents = new JSONObject(urls_file_content); provider_json_url = file_contents.getString(Provider.DOT_JSON_URL); - domain = new URL(provider_json_url).getHost(); - //provider_json_filename = file_contents.getString("assets_json_provider"); - eip_service_json_url = file_contents.getString("json_eip_service"); - cert_json_url = file_contents.getString(EIP.CERTIFICATE); + this.name = name; this.custom = custom; this.danger_on = danger_on; - } catch (MalformedURLException e) { - // TODO Auto-generated catch block - e.printStackTrace(); } catch (JSONException e) { // TODO Auto-generated catch block e.printStackTrace(); @@ -113,38 +96,20 @@ public class ProviderListContent { * @param provider_json already downloaded * @param custom if it's a new provider entered by the user or not * @param danger_on if the user trusts completely the new provider - */ - public ProviderItem(String name, String provider_json_url, JSONObject provider_json, boolean custom, boolean danger_on) { - - try { - id = name; - //this.name = name; - this.provider_json_url = provider_json_url; - this.provider_json = provider_json; - this.name = provider_json.getJSONObject("name").getString("en"); - domain = new URL(provider_json_url).getHost(); - eip_service_json_url = provider_json.getString(Provider.API_URL) + "/" + provider_json.getString(Provider.API_VERSION) + "/" + EIP.SERVICE_API_PATH; - cert_json_url = provider_json.getString("ca_cert_uri"); - this.custom = custom; - this.danger_on = danger_on; - if(custom) - provider_json_filename = name + "_provider.json".replaceFirst("__", "_"); - } catch (MalformedURLException e) { - // TODO Auto-generated catch block - e.printStackTrace(); - } catch (JSONException e) { - // TODO Auto-generated catch block - e.printStackTrace(); - } - } - - @Override - public String toString() { - return name; - } - - public String getName() { - return id; + */ + public ProviderItem(String name, String provider_json_url, boolean custom, boolean danger_on) { + this.name = name; + this.provider_json_url = provider_json_url; + this.custom = custom; + this.danger_on = danger_on; } + + public String name() { return name; } + + public boolean custom() { return custom; } + + public String providerJsonUrl() { return provider_json_url; } + + public boolean completelyTrusted() { return danger_on; } } } -- cgit v1.2.3 From 8fe314897cb59067c10cee376afbe01d623a9661 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Mon, 9 Sep 2013 20:08:00 +0200 Subject: Preseeded providers only have provider.json url I've refactored everything to be able to remove all but provider.json url at urls files. --- assets/urls/bitmask.url | 6 +-- src/se/leap/bitmaskclient/AboutFragment.java | 3 -- src/se/leap/bitmaskclient/ConfigurationWizard.java | 43 ++++++++++++---------- src/se/leap/bitmaskclient/ProviderListContent.java | 8 ++++ .../leap/bitmaskclient/ProviderListFragment.java | 2 +- 5 files changed, 34 insertions(+), 28 deletions(-) diff --git a/assets/urls/bitmask.url b/assets/urls/bitmask.url index a17a5ff8..9e4c1317 100644 --- a/assets/urls/bitmask.url +++ b/assets/urls/bitmask.url @@ -1,7 +1,3 @@ { - "name" : "bitmask", - "assets_json_provider" : "providers/bitmask.net_provider.json", - "provider_json_url" : "https://bitmask.net/provider.json", - "cert" : "https://bitmask.net/ca.crt", - "json_eip_service" : "https://api.bitmask.net:4430/1/config/eip-service.json" + "provider_json_url" : "https://bitmask.net/provider.json" } \ No newline at end of file diff --git a/src/se/leap/bitmaskclient/AboutFragment.java b/src/se/leap/bitmaskclient/AboutFragment.java index d751dc2f..4d03a44b 100644 --- a/src/se/leap/bitmaskclient/AboutFragment.java +++ b/src/se/leap/bitmaskclient/AboutFragment.java @@ -4,9 +4,6 @@ import android.app.Fragment; import android.content.pm.PackageInfo; import android.content.pm.PackageManager.NameNotFoundException; import android.os.Bundle; -import android.text.Html; -import android.text.Spanned; -import android.text.method.LinkMovementMethod; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; diff --git a/src/se/leap/bitmaskclient/ConfigurationWizard.java b/src/se/leap/bitmaskclient/ConfigurationWizard.java index 532debfd..6d088a85 100644 --- a/src/se/leap/bitmaskclient/ConfigurationWizard.java +++ b/src/se/leap/bitmaskclient/ConfigurationWizard.java @@ -165,7 +165,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn mProgressBar.incrementProgressBy(1); } - downloadJSONFiles(mSelectedProvider); + downloadJSONFiles(provider_json, danger_on); } catch (JSONException e) { // TODO Auto-generated catch block e.printStackTrace(); @@ -366,7 +366,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn mProgressBar.incrementProgressBy(1); - downloadJSONFiles(mSelectedProvider); + downloadJSONFiles(provider_json, provider.completelyTrusted()); } } catch (JSONException e) { setResult(RESULT_CANCELED); @@ -378,23 +378,28 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn * Asks ProviderAPI to download provider site's certificate and eip-service.json * * URLs are fetched from the provider parameter - * @param provider from which certificate and eip-service.json files are going to be downloaded - */ - private void downloadJSONFiles(ProviderItem provider) { - Intent provider_API_command = new Intent(this, ProviderAPI.class); - - Bundle parameters = new Bundle(); - - parameters.putString(Provider.KEY, provider.name()); - parameters.putString(Provider.CA_CERT, provider.cert_json_url); - parameters.putString(EIP.KEY, provider.eip_service_json_url); - parameters.putBoolean(ProviderItem.DANGER_ON, provider.completelyTrusted()); - - provider_API_command.setAction(ProviderAPI.DOWNLOAD_JSON_FILES_BUNDLE_EXTRA); - provider_API_command.putExtra(ProviderAPI.PARAMETERS, parameters); - provider_API_command.putExtra(ProviderAPI.RECEIVER_KEY, providerAPI_result_receiver); - - startService(provider_API_command); + * @param provider_json describing the provider from which certificate and eip-service.json files are going to be downloaded + */ + private void downloadJSONFiles(JSONObject provider_json, boolean danger_on) { + try { + Intent provider_API_command = new Intent(this, ProviderAPI.class); + + Bundle parameters = new Bundle(); + + parameters.putBoolean(ProviderItem.DANGER_ON, danger_on); + parameters.putString(Provider.CA_CERT, provider_json.getString("ca_cert_uri")); + String eip_service_url = provider_json.getString(Provider.API_URL) + "/" + provider_json.getString(Provider.API_VERSION) + "/config/eip-service.json"; + parameters.putString(EIP.KEY, eip_service_url); + + provider_API_command.setAction(ProviderAPI.DOWNLOAD_JSON_FILES_BUNDLE_EXTRA); + provider_API_command.putExtra(ProviderAPI.PARAMETERS, parameters); + provider_API_command.putExtra(ProviderAPI.RECEIVER_KEY, providerAPI_result_receiver); + + startService(provider_API_command); + } catch (JSONException e) { + //TODO Show error to the user. This will eventually be transformed to "unselectProvider()", which will show the graphical notice itself. + ConfigHelper.removeFromSharedPref(Provider.KEY); + } } /** diff --git a/src/se/leap/bitmaskclient/ProviderListContent.java b/src/se/leap/bitmaskclient/ProviderListContent.java index 42cac792..a6da5620 100644 --- a/src/se/leap/bitmaskclient/ProviderListContent.java +++ b/src/se/leap/bitmaskclient/ProviderListContent.java @@ -110,6 +110,14 @@ public class ProviderListContent { public String providerJsonUrl() { return provider_json_url; } + public String domain() { + try { + return new URL(provider_json_url).getHost(); + } catch (MalformedURLException e) { + return provider_json_url.replaceFirst("http[s]?://", "").replaceFirst("/.*", ""); + } + } + public boolean completelyTrusted() { return danger_on; } } } diff --git a/src/se/leap/bitmaskclient/ProviderListFragment.java b/src/se/leap/bitmaskclient/ProviderListFragment.java index 84d46a11..ca66d295 100644 --- a/src/se/leap/bitmaskclient/ProviderListFragment.java +++ b/src/se/leap/bitmaskclient/ProviderListFragment.java @@ -155,7 +155,7 @@ public class ProviderListFragment extends ListFragment { // Notify the active callbacks interface (the activity, if the // fragment is attached to one) that an item has been selected. - mCallbacks.onItemSelected(ProviderListContent.ITEMS.get(position).id); + mCallbacks.onItemSelected(ProviderListContent.ITEMS.get(position).name()); for(int item_position = 0; item_position < listView.getCount(); item_position++) { if(item_position != position) -- cgit v1.2.3 From b001f59fcbc30112ce04891fbca4c1365b457813 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Thu, 10 Oct 2013 21:12:32 +0200 Subject: Simplified the methods to add a new provider. Adding a new provider is the same that selecting a new one, using the same methods and following the same workflow. --- assets/urls/bitmask.url | 2 +- src/se/leap/bitmaskclient/ConfigurationWizard.java | 74 +++++++--------------- src/se/leap/bitmaskclient/NewProviderDialog.java | 4 +- src/se/leap/bitmaskclient/ProviderAPI.java | 64 ++----------------- src/se/leap/bitmaskclient/ProviderListContent.java | 18 +++--- .../leap/bitmaskclient/ProviderListFragment.java | 3 + 6 files changed, 43 insertions(+), 122 deletions(-) diff --git a/assets/urls/bitmask.url b/assets/urls/bitmask.url index 9e4c1317..f924301e 100644 --- a/assets/urls/bitmask.url +++ b/assets/urls/bitmask.url @@ -1,3 +1,3 @@ { - "provider_json_url" : "https://bitmask.net/provider.json" + "main_url" : "https://bitmask.net/" } \ No newline at end of file diff --git a/src/se/leap/bitmaskclient/ConfigurationWizard.java b/src/se/leap/bitmaskclient/ConfigurationWizard.java index 6d088a85..43ac8dd8 100644 --- a/src/se/leap/bitmaskclient/ConfigurationWizard.java +++ b/src/se/leap/bitmaskclient/ConfigurationWizard.java @@ -238,7 +238,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn int provider_index = getProviderIndex(id); startProgressBar(provider_index); mSelectedProvider = selected_provider; - updateProviderDotJson(mSelectedProvider.name(), mSelectedProvider.providerJsonUrl(), mSelectedProvider.completelyTrusted()); + updateProviderDotJson(mSelectedProvider.providerMainUrl(), mSelectedProvider.completelyTrusted()); } @Override @@ -343,37 +343,6 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn return loaded_preseeded_providers; } - /** - * Saves provider.json file associated with provider. - * - * If the provider is custom, the file has already been downloaded so we load it from memory. - * If not, the file is updated using the provider's URL. - * @param provider - */ - private void saveProviderJson(ProviderItem provider) { - JSONObject provider_json = new JSONObject(); - try { - if(!provider.custom()) { - updateProviderDotJson(mSelectedProvider.name(), provider.providerJsonUrl(), provider.completelyTrusted()); - } else { - // FIXME!! We should we be updating our seeded providers list at ConfigurationWizard onStart() ? - // I think yes, but if so, where does this list live? leap.se, as it's the non-profit project for the software? - // If not, we should just be getting names/urls, and fetching the provider.json like in custom entries - provider_json = ConfigHelper.getJsonFromSharedPref(Provider.KEY); - ConfigHelper.saveSharedPref(Provider.KEY, provider_json); - ConfigHelper.saveSharedPref(EIP.ALLOWED_ANON, provider_json.getJSONObject(Provider.SERVICE).getBoolean(EIP.ALLOWED_ANON)); - ConfigHelper.saveSharedPref(ProviderItem.DANGER_ON, provider.completelyTrusted()); - - mProgressBar.incrementProgressBy(1); - - downloadJSONFiles(provider_json, provider.completelyTrusted()); - } - } catch (JSONException e) { - setResult(RESULT_CANCELED); - finish(); - } - } - /** * Asks ProviderAPI to download provider site's certificate and eip-service.json * @@ -471,34 +440,37 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn newFragment.show(fragment_transaction, ProviderDetailFragment.TAG); } - @Override - public void saveAndSelectProvider(String provider_main_url, boolean danger_on) { - Intent provider_API_command = new Intent(this, ProviderAPI.class); - - Bundle parameters = new Bundle(); - parameters.putString(Provider.MAIN_URL, provider_main_url); - parameters.putBoolean(ProviderItem.DANGER_ON, danger_on); - - provider_API_command.setAction(ProviderAPI.DOWNLOAD_NEW_PROVIDER_DOTJSON); - provider_API_command.putExtra(ProviderAPI.PARAMETERS, parameters); - provider_API_command.putExtra(ProviderAPI.RECEIVER_KEY, providerAPI_result_receiver); - - startService(provider_API_command); + public void showAndSelectProvider(String provider_main_url, boolean danger_on) { + showProvider(provider_main_url, danger_on); + updateProviderDotJson(provider_main_url, danger_on); + } + + private void showProvider(final String provider_main_url, final boolean danger_on) { + String provider_name = provider_main_url.replaceFirst("http[s]?://", "").replaceFirst("\\/", "_"); + boolean custom = true; + final ProviderItem added_provider = new ProviderItem(provider_name, provider_main_url, custom, danger_on); + runOnUiThread(new Runnable() { + + @Override + public void run() { + // TODO Auto-generated method stub + ProviderListContent.addItem(added_provider); + ProviderListFragment provider_list_fragment = (ProviderListFragment) getFragmentManager().findFragmentByTag("providerlist"); + provider_list_fragment.notifyAdapter(); + } + }); } /** * Asks ProviderAPI to download a new provider.json file * @param provider_name - * @param provider_json_url + * @param provider_main_url * @param danger_on tells if HTTPS client should bypass certificate errors */ - public void updateProviderDotJson(String provider_name, String provider_json_url, boolean danger_on) { - - + public void updateProviderDotJson(String provider_main_url, boolean danger_on) { Intent provider_API_command = new Intent(this, ProviderAPI.class); Bundle parameters = new Bundle(); - parameters.putString(Provider.NAME, provider_name); - parameters.putString(Provider.DOT_JSON_URL, provider_json_url); + parameters.putString(Provider.MAIN_URL, provider_main_url); parameters.putBoolean(ProviderItem.DANGER_ON, danger_on); provider_API_command.setAction(ProviderAPI.UPDATE_PROVIDER_DOTJSON); diff --git a/src/se/leap/bitmaskclient/NewProviderDialog.java b/src/se/leap/bitmaskclient/NewProviderDialog.java index a0b8a763..98686bd2 100644 --- a/src/se/leap/bitmaskclient/NewProviderDialog.java +++ b/src/se/leap/bitmaskclient/NewProviderDialog.java @@ -41,7 +41,7 @@ public class NewProviderDialog extends DialogFragment { final public static String TAG = "newProviderDialog"; public interface NewProviderDialogInterface { - public void saveAndSelectProvider(String url_provider, boolean danger_on); + public void showAndSelectProvider(String url_provider, boolean danger_on); } NewProviderDialogInterface interface_with_ConfigurationWizard; @@ -85,7 +85,7 @@ public class NewProviderDialog extends DialogFragment { } boolean danger_on = danger_checkbox.isChecked(); if(validURL(entered_url)) { - interface_with_ConfigurationWizard.saveAndSelectProvider(entered_url, danger_on); + interface_with_ConfigurationWizard.showAndSelectProvider(entered_url, danger_on); Toast.makeText(getActivity().getApplicationContext(), R.string.valid_url_entered, Toast.LENGTH_LONG).show(); } else { url_input_field.setText(""); diff --git a/src/se/leap/bitmaskclient/ProviderAPI.java b/src/se/leap/bitmaskclient/ProviderAPI.java index 871a20dd..268275e2 100644 --- a/src/se/leap/bitmaskclient/ProviderAPI.java +++ b/src/se/leap/bitmaskclient/ProviderAPI.java @@ -156,13 +156,6 @@ public class ProviderAPI extends IntentService { } else { receiver.send(INCORRECTLY_UPDATED_PROVIDER_DOT_JSON, Bundle.EMPTY); } - } else if (action.equalsIgnoreCase(DOWNLOAD_NEW_PROVIDER_DOTJSON)) { - Bundle result = downloadNewProviderDotJSON(parameters); - if(result.getBoolean(RESULT_KEY)) { - receiver.send(CORRECTLY_UPDATED_PROVIDER_DOT_JSON, result); - } else { - receiver.send(INCORRECTLY_DOWNLOADED_JSON_FILES, result); - } } else if (action.equalsIgnoreCase(SRP_AUTH)) { Bundle session_id_bundle = authenticateBySRP(parameters); if(session_id_bundle.getBoolean(RESULT_KEY)) { @@ -494,10 +487,8 @@ public class ProviderAPI extends IntentService { */ private Bundle updateProviderDotJSON(Bundle task) { Bundle result = new Bundle(); - boolean custom = task.getBoolean(ProviderItem.CUSTOM); boolean danger_on = task.getBoolean(ProviderItem.DANGER_ON); - String provider_json_url = task.getString(Provider.DOT_JSON_URL); - String provider_name = task.getString(Provider.NAME); + String provider_json_url = task.getString(Provider.MAIN_URL) + "/provider.json"; try { String provider_dot_json_string = downloadWithCommercialCA(provider_json_url, danger_on); @@ -512,56 +503,9 @@ public class ProviderAPI extends IntentService { } else { ConfigHelper.saveSharedPref(EIP.ALLOWED_ANON, provider_json.getJSONObject(Provider.SERVICE).getBoolean(EIP.ALLOWED_ANON)); - //ProviderListContent.addItem(new ProviderItem(provider_name, provider_json_url, provider_json, custom, danger_on)); - result.putBoolean(RESULT_KEY, true); - result.putString(Provider.KEY, provider_json.toString()); - result.putBoolean(ProviderItem.DANGER_ON, danger_on); - } - } - } catch (JSONException e) { - result.putBoolean(RESULT_KEY, false); - } - - return result; - } - - /** - * Downloads a custom provider provider.json file - * @param task containing a boolean meaning if the user completely trusts this provider, and the provider main url entered in the new custom provider dialog. - * @return true if provider.json file was successfully parsed as a JSON object. - */ - private Bundle downloadNewProviderDotJSON(Bundle task) { - Bundle result = new Bundle(); - boolean custom = true; - boolean danger_on = task.getBoolean(ProviderItem.DANGER_ON); - - String provider_main_url = (String) task.get(Provider.MAIN_URL); - String provider_name = provider_main_url.replaceFirst("http[s]?://", "").replaceFirst("\\/", "_"); - String provider_json_url = guessProviderDotJsonURL(provider_main_url); - - String provider_json_string = downloadWithCommercialCA(provider_json_url, danger_on); - try { - if(provider_json_string.isEmpty()) { - result.putBoolean(RESULT_KEY, false); - } else { - JSONObject provider_json = new JSONObject(provider_json_string); - - if(provider_json.has(ERRORS)) { - String reason_to_fail = provider_json.getString(ERRORS); - result.putString(ERRORS, reason_to_fail); - result.putBoolean(RESULT_KEY, false); - } else { - ConfigHelper.saveSharedPref(Provider.KEY, provider_json); - ConfigHelper.saveSharedPref(ProviderItem.DANGER_ON, danger_on); - ConfigHelper.saveSharedPref(EIP.ALLOWED_ANON, provider_json.getJSONObject(Provider.SERVICE).getBoolean(EIP.ALLOWED_ANON)); - ProviderItem added_provider = new ProviderItem(provider_name, provider_json_url, provider_json, custom, danger_on); - ProviderListContent.addItem(added_provider); - - result.putString(Provider.NAME, added_provider.getName()); - result.putBoolean(RESULT_KEY, true); - result.putString(Provider.KEY, provider_json.toString()); - result.putBoolean(ProviderItem.DANGER_ON, danger_on); - } + result.putBoolean(RESULT_KEY, true); + result.putString(Provider.KEY, provider_json.toString()); + result.putBoolean(ProviderItem.DANGER_ON, danger_on); } } catch (JSONException e) { result.putBoolean(RESULT_KEY, false); diff --git a/src/se/leap/bitmaskclient/ProviderListContent.java b/src/se/leap/bitmaskclient/ProviderListContent.java index a6da5620..3695066c 100644 --- a/src/se/leap/bitmaskclient/ProviderListContent.java +++ b/src/se/leap/bitmaskclient/ProviderListContent.java @@ -28,6 +28,8 @@ import java.net.MalformedURLException; import org.json.JSONException; import org.json.JSONObject; +import android.app.Activity; + /** * Models the provider list shown in the ConfigurationWizard. * @@ -60,7 +62,7 @@ public class ProviderListContent { final public static String CUSTOM = "custom"; final public static String DANGER_ON = "danger_on"; private boolean custom = false; - private String provider_json_url; + private String provider_main_url; private String name; private boolean danger_on = false; @@ -77,7 +79,7 @@ public class ProviderListContent { urls_file_input_stream.read(urls_file_bytes); String urls_file_content = new String(urls_file_bytes); JSONObject file_contents = new JSONObject(urls_file_content); - provider_json_url = file_contents.getString(Provider.DOT_JSON_URL); + provider_main_url = file_contents.getString(Provider.MAIN_URL); this.name = name; this.custom = custom; this.danger_on = danger_on; @@ -92,14 +94,14 @@ public class ProviderListContent { /** * @param name of the provider - * @param provider_json_url used to download provider.json file of the provider + * @param provider_main_url used to download provider.json file of the provider * @param provider_json already downloaded * @param custom if it's a new provider entered by the user or not * @param danger_on if the user trusts completely the new provider */ - public ProviderItem(String name, String provider_json_url, boolean custom, boolean danger_on) { + public ProviderItem(String name, String provider_main_url, boolean custom, boolean danger_on) { this.name = name; - this.provider_json_url = provider_json_url; + this.provider_main_url = provider_main_url; this.custom = custom; this.danger_on = danger_on; } @@ -108,13 +110,13 @@ public class ProviderListContent { public boolean custom() { return custom; } - public String providerJsonUrl() { return provider_json_url; } + public String providerMainUrl() { return provider_main_url; } public String domain() { try { - return new URL(provider_json_url).getHost(); + return new URL(provider_main_url).getHost(); } catch (MalformedURLException e) { - return provider_json_url.replaceFirst("http[s]?://", "").replaceFirst("/.*", ""); + return provider_main_url.replaceFirst("http[s]?://", "").replaceFirst("/.*", ""); } } diff --git a/src/se/leap/bitmaskclient/ProviderListFragment.java b/src/se/leap/bitmaskclient/ProviderListFragment.java index ca66d295..62dcef7a 100644 --- a/src/se/leap/bitmaskclient/ProviderListFragment.java +++ b/src/se/leap/bitmaskclient/ProviderListFragment.java @@ -172,6 +172,9 @@ public class ProviderListFragment extends ListFragment { } } + public void notifyAdapter() { + content_adapter.notifyDataSetChanged(); + } /** * Turns on activate-on-click mode. When this mode is on, list items will be * given the 'activated' state when touched. -- cgit v1.2.3 From 7f351332e7f308b52bbdded5e3df6a9c2c0d01e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Mon, 14 Oct 2013 13:08:22 +0200 Subject: Successfully rebased onto progress-bars. --- src/se/leap/bitmaskclient/ConfigurationWizard.java | 32 ++++++++++++---------- src/se/leap/bitmaskclient/ProviderAPI.java | 5 +++- src/se/leap/bitmaskclient/ProviderListAdapter.java | 20 ++++++-------- src/se/leap/bitmaskclient/ProviderListContent.java | 9 ++---- .../leap/bitmaskclient/ProviderListFragment.java | 1 + 5 files changed, 33 insertions(+), 34 deletions(-) diff --git a/src/se/leap/bitmaskclient/ConfigurationWizard.java b/src/se/leap/bitmaskclient/ConfigurationWizard.java index 43ac8dd8..36d90318 100644 --- a/src/se/leap/bitmaskclient/ConfigurationWizard.java +++ b/src/se/leap/bitmaskclient/ConfigurationWizard.java @@ -149,16 +149,14 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn if(resultData.containsKey(Provider.NAME)) { String provider_id = resultData.getString(Provider.NAME); mSelectedProvider = getProvider(provider_id); - provider_list_fragment.addItem(mSelectedProvider); - ProviderListContent.removeItem(mSelectedProvider); + //provider_list_fragment.addItem(mSelectedProvider); + //ProviderListContent.removeItem(mSelectedProvider); - if(mSelectedProvider.custom) - refreshProviderList(0); + //refreshProviderList(0); if(!mProgressBar.isShown()) { int provider_index = getProviderIndex(provider_id); startProgressBar(provider_index); - provider_list_fragment = (ProviderListFragment) getFragmentManager().findFragmentByTag(ProviderListFragment.TAG); provider_list_fragment.hide(provider_index-2); //setProviderList(provider_list_fragment); } @@ -171,7 +169,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn e.printStackTrace(); mProgressBar.setVisibility(ProgressBar.GONE); progressbar_description.setVisibility(TextView.GONE); - refreshProviderList(0); + //refreshProviderList(0); //Toast.makeText(this, getResources().getString(R.string.config_error_parsing), Toast.LENGTH_LONG); setResult(RESULT_CANCELED, mConfigState); } @@ -194,7 +192,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn mProgressBar.incrementProgressBy(1); mProgressBar.setVisibility(ProgressBar.GONE); progressbar_description.setVisibility(TextView.GONE); - refreshProviderList(0); + //refreshProviderList(0); //Toast.makeText(getApplicationContext(), R.string.success, Toast.LENGTH_LONG).show(); setResult(RESULT_OK); showProviderDetails(getCurrentFocus()); @@ -288,7 +286,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn while(providers_iterator.hasNext()) { ProviderItem provider = providers_iterator.next(); index++; - if(provider.id.equalsIgnoreCase(id)) { + if(provider.name().equalsIgnoreCase(id)) { break; } } @@ -447,18 +445,22 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn private void showProvider(final String provider_main_url, final boolean danger_on) { String provider_name = provider_main_url.replaceFirst("http[s]?://", "").replaceFirst("\\/", "_"); - boolean custom = true; - final ProviderItem added_provider = new ProviderItem(provider_name, provider_main_url, custom, danger_on); + final ProviderItem added_provider = new ProviderItem(provider_name, provider_main_url, danger_on); + + //ProviderListContent.addItem(added_provider); + provider_list_fragment.addItem(added_provider); + /*ProviderListFragment provider_list_fragment = (ProviderListFragment) getFragmentManager().findFragmentByTag(ProviderListFragment.TAG); + //provider_list_fragment.notifyAdapter(); + provider_list_fragment.addItem(added_provider); + refreshProviderList(0); + runOnUiThread(new Runnable() { @Override public void run() { - // TODO Auto-generated method stub - ProviderListContent.addItem(added_provider); - ProviderListFragment provider_list_fragment = (ProviderListFragment) getFragmentManager().findFragmentByTag("providerlist"); - provider_list_fragment.notifyAdapter(); + provider_list_fragment.addItem(added_provider); } - }); + });*/ } /** diff --git a/src/se/leap/bitmaskclient/ProviderAPI.java b/src/se/leap/bitmaskclient/ProviderAPI.java index 268275e2..8542aa92 100644 --- a/src/se/leap/bitmaskclient/ProviderAPI.java +++ b/src/se/leap/bitmaskclient/ProviderAPI.java @@ -488,7 +488,9 @@ public class ProviderAPI extends IntentService { private Bundle updateProviderDotJSON(Bundle task) { Bundle result = new Bundle(); boolean danger_on = task.getBoolean(ProviderItem.DANGER_ON); - String provider_json_url = task.getString(Provider.MAIN_URL) + "/provider.json"; + String provider_main_url = task.getString(Provider.MAIN_URL); + String provider_name = provider_main_url.replaceFirst("http[s]?://", "").replaceFirst("\\/", "_"); + String provider_json_url = provider_main_url + "/provider.json"; try { String provider_dot_json_string = downloadWithCommercialCA(provider_json_url, danger_on); @@ -503,6 +505,7 @@ public class ProviderAPI extends IntentService { } else { ConfigHelper.saveSharedPref(EIP.ALLOWED_ANON, provider_json.getJSONObject(Provider.SERVICE).getBoolean(EIP.ALLOWED_ANON)); + result.putString(Provider.NAME, added_provider.name()); result.putBoolean(RESULT_KEY, true); result.putString(Provider.KEY, provider_json.toString()); result.putBoolean(ProviderItem.DANGER_ON, danger_on); diff --git a/src/se/leap/bitmaskclient/ProviderListAdapter.java b/src/se/leap/bitmaskclient/ProviderListAdapter.java index 19c4f72c..bb1318fc 100644 --- a/src/se/leap/bitmaskclient/ProviderListAdapter.java +++ b/src/se/leap/bitmaskclient/ProviderListAdapter.java @@ -1,5 +1,6 @@ package se.leap.bitmaskclient; +import java.lang.reflect.Array; import java.util.List; import android.content.Context; @@ -10,7 +11,6 @@ import android.widget.ArrayAdapter; import android.widget.TwoLineListItem; public class ProviderListAdapter extends ArrayAdapter { - private T[] items = null; private static boolean[] hidden = null; public void hide(int position) { @@ -42,7 +42,7 @@ public class ProviderListAdapter extends ArrayAdapter { } private int getHiddenCount() { int count = 0; - for(int i=0;i extends ArrayAdapter { @Override public int getCount() { - return (items.length - getHiddenCount()); + return (hidden.length - getHiddenCount()); } public ProviderListAdapter(Context mContext, int layout, List objects) { super(mContext, layout, objects); - items = objects.toArray((T[])new Object[0]); if(hidden == null) { - hidden = new boolean[items.length]; - for (int i = 0; i < items.length; i++) + hidden = new boolean[objects.size()]; + for (int i = 0; i < objects.size(); i++) hidden[i] = false; } } public ProviderListAdapter(Context mContext, int layout, List objects, boolean show_all_providers) { super(mContext, layout, objects); - items = objects.toArray((T[])new Object[0]); if(show_all_providers) { - hidden = new boolean[items.length]; - for (int i = 0; i < items.length; i++) + hidden = new boolean[objects.size()]; + for (int i = 0; i < objects.size(); i++) hidden[i] = false; } } @@ -101,8 +99,8 @@ public class ProviderListAdapter extends ArrayAdapter { row = (TwoLineListItem)convertView; } ProviderListContent.ProviderItem data = ProviderListContent.ITEMS.get(position); - row.getText1().setText(data.domain); - row.getText2().setText(data.name); + row.getText1().setText(data.domain()); + row.getText2().setText(data.name()); return row; } diff --git a/src/se/leap/bitmaskclient/ProviderListContent.java b/src/se/leap/bitmaskclient/ProviderListContent.java index 3695066c..af61dbd6 100644 --- a/src/se/leap/bitmaskclient/ProviderListContent.java +++ b/src/se/leap/bitmaskclient/ProviderListContent.java @@ -61,7 +61,6 @@ public class ProviderListContent { public static class ProviderItem { final public static String CUSTOM = "custom"; final public static String DANGER_ON = "danger_on"; - private boolean custom = false; private String provider_main_url; private String name; private boolean danger_on = false; @@ -80,8 +79,7 @@ public class ProviderListContent { String urls_file_content = new String(urls_file_bytes); JSONObject file_contents = new JSONObject(urls_file_content); provider_main_url = file_contents.getString(Provider.MAIN_URL); - this.name = name; - this.custom = custom; + this.name = name; this.danger_on = danger_on; } catch (JSONException e) { // TODO Auto-generated catch block @@ -99,17 +97,14 @@ public class ProviderListContent { * @param custom if it's a new provider entered by the user or not * @param danger_on if the user trusts completely the new provider */ - public ProviderItem(String name, String provider_main_url, boolean custom, boolean danger_on) { + public ProviderItem(String name, String provider_main_url, boolean danger_on) { this.name = name; this.provider_main_url = provider_main_url; - this.custom = custom; this.danger_on = danger_on; } public String name() { return name; } - public boolean custom() { return custom; } - public String providerMainUrl() { return provider_main_url; } public String domain() { diff --git a/src/se/leap/bitmaskclient/ProviderListFragment.java b/src/se/leap/bitmaskclient/ProviderListFragment.java index 62dcef7a..6a0f2a05 100644 --- a/src/se/leap/bitmaskclient/ProviderListFragment.java +++ b/src/se/leap/bitmaskclient/ProviderListFragment.java @@ -199,6 +199,7 @@ public class ProviderListFragment extends ListFragment { public void addItem(ProviderItem provider) { content_adapter.add(provider); + content_adapter.notifyDataSetChanged(); } public void hide(int position) { -- cgit v1.2.3 From 8a5be8fb481beaad45779909e726fb884476b4da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Mon, 14 Oct 2013 15:52:38 +0200 Subject: Provider setup: One method downloads everything. This method uses another 3 to download each file. Next step: broadcast progress and remove unnecessary methods. --- src/se/leap/bitmaskclient/ConfigurationWizard.java | 21 ++++- src/se/leap/bitmaskclient/Dashboard.java | 1 + src/se/leap/bitmaskclient/Provider.java | 2 +- src/se/leap/bitmaskclient/ProviderAPI.java | 95 +++++++++++++++++++--- src/se/leap/bitmaskclient/ProviderListContent.java | 14 +--- 5 files changed, 105 insertions(+), 28 deletions(-) diff --git a/src/se/leap/bitmaskclient/ConfigurationWizard.java b/src/se/leap/bitmaskclient/ConfigurationWizard.java index 36d90318..6c02d612 100644 --- a/src/se/leap/bitmaskclient/ConfigurationWizard.java +++ b/src/se/leap/bitmaskclient/ConfigurationWizard.java @@ -163,7 +163,20 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn mProgressBar.incrementProgressBy(1); } - downloadJSONFiles(provider_json, danger_on); + + if (ConfigHelper.getBoolFromSharedPref(EIP.ALLOWED_ANON)){ + mConfigState.putExtra(SERVICES_RETRIEVED, true); + downloadAnonCert(); + } else { + mProgressBar.incrementProgressBy(1); + mProgressBar.setVisibility(ProgressBar.GONE); + progressbar_description.setVisibility(TextView.GONE); + //refreshProviderList(0); + //Toast.makeText(getApplicationContext(), R.string.success, Toast.LENGTH_LONG).show(); + setResult(RESULT_OK); + showProviderDetails(getCurrentFocus()); + } + //downloadJSONFiles(provider_json, danger_on); } catch (JSONException e) { // TODO Auto-generated catch block e.printStackTrace(); @@ -236,7 +249,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn int provider_index = getProviderIndex(id); startProgressBar(provider_index); mSelectedProvider = selected_provider; - updateProviderDotJson(mSelectedProvider.providerMainUrl(), mSelectedProvider.completelyTrusted()); + updateProviderDotJson(mSelectedProvider.providerMainUrl(), true); } @Override @@ -331,7 +344,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn boolean custom = false; provider_name = url_filepath.subSequence(0, url_filepath.indexOf(".")).toString(); if(ProviderListContent.ITEMS.isEmpty()) //TODO I have to implement a way of checking if a provider new or is already present in that ITEMS list - ProviderListContent.addItem(new ProviderItem(provider_name, asset_manager.open(url_files_folder + "/" + url_filepath), custom, false)); + ProviderListContent.addItem(new ProviderItem(provider_name, asset_manager.open(url_files_folder + "/" + url_filepath))); loaded_preseeded_providers = true; } } catch (IOException e) { @@ -445,7 +458,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn private void showProvider(final String provider_main_url, final boolean danger_on) { String provider_name = provider_main_url.replaceFirst("http[s]?://", "").replaceFirst("\\/", "_"); - final ProviderItem added_provider = new ProviderItem(provider_name, provider_main_url, danger_on); + final ProviderItem added_provider = new ProviderItem(provider_name, provider_main_url); //ProviderListContent.addItem(added_provider); provider_list_fragment.addItem(added_provider); diff --git a/src/se/leap/bitmaskclient/Dashboard.java b/src/se/leap/bitmaskclient/Dashboard.java index 65ff2800..0ae7085a 100644 --- a/src/se/leap/bitmaskclient/Dashboard.java +++ b/src/se/leap/bitmaskclient/Dashboard.java @@ -243,6 +243,7 @@ public class Dashboard extends Activity implements LogInDialog.LogInDialogInterf } eipStop(); } + ConfigHelper.removeFromSharedPref(Provider.KEY); startActivityForResult(new Intent(this,ConfigurationWizard.class), SWITCH_PROVIDER); return true; case R.id.login_button: diff --git a/src/se/leap/bitmaskclient/Provider.java b/src/se/leap/bitmaskclient/Provider.java index f36e5946..598999fd 100644 --- a/src/se/leap/bitmaskclient/Provider.java +++ b/src/se/leap/bitmaskclient/Provider.java @@ -99,7 +99,7 @@ public final class Provider implements Serializable { preferences = activity.getSharedPreferences(Dashboard.SHARED_PREFERENCES,Context.MODE_PRIVATE); // Inflate our provider.json data try { - definition = new JSONObject( preferences.getString("provider", "") ); + definition = new JSONObject( preferences.getString(Provider.KEY, "") ); } catch (JSONException e) { // TODO: handle exception diff --git a/src/se/leap/bitmaskclient/ProviderAPI.java b/src/se/leap/bitmaskclient/ProviderAPI.java index 8542aa92..6003fa6c 100644 --- a/src/se/leap/bitmaskclient/ProviderAPI.java +++ b/src/se/leap/bitmaskclient/ProviderAPI.java @@ -36,6 +36,7 @@ import java.security.KeyStore; import java.security.KeyStoreException; import java.security.NoSuchAlgorithmException; import java.security.SecureRandom; +import java.security.cert.CertificateEncodingException; import java.security.cert.CertificateException; import java.security.cert.X509Certificate; import java.security.interfaces.RSAPrivateKey; @@ -68,7 +69,6 @@ import android.os.Handler; import android.os.ResultReceiver; import android.util.Base64; import android.util.Log; -import android.widget.ProgressBar; import android.widget.Toast; /** @@ -99,7 +99,8 @@ public class ProviderAPI extends IntentService { SESSION_ID_KEY = "session_id", ERRORS = "errors", UPDATE_ACTION = "update_action", - UPDATE_DATA = "update data" + UPDATE_DATA = "update data", + TAG = "provider_api_tag" ; final public static int @@ -489,9 +490,13 @@ public class ProviderAPI extends IntentService { Bundle result = new Bundle(); boolean danger_on = task.getBoolean(ProviderItem.DANGER_ON); String provider_main_url = task.getString(Provider.MAIN_URL); - String provider_name = provider_main_url.replaceFirst("http[s]?://", "").replaceFirst("\\/", "_"); - String provider_json_url = provider_main_url + "/provider.json"; - + if(downloadCACert(provider_main_url, danger_on)) { + result.putBoolean(RESULT_KEY, true); + if(getAndSetProviderJson(provider_main_url)) + if(getAndSetEipServiceJson()) + ; + } + /* try { String provider_dot_json_string = downloadWithCommercialCA(provider_json_url, danger_on); if(provider_dot_json_string.isEmpty()) { @@ -514,10 +519,72 @@ public class ProviderAPI extends IntentService { result.putBoolean(RESULT_KEY, false); result.putString(ERRORS, "Corrupt download"); } + */ + return result; + } + + private boolean downloadCACert(String provider_main_url, boolean danger_on) { + String cert_string = downloadWithCommercialCA(provider_main_url + "/ca.crt", danger_on); + if(validCertificate(cert_string)) + ConfigHelper.saveSharedPref(Provider.CA_CERT, "-----BEGIN CERTIFICATE-----\n"+cert_string+"-----END CERTIFICATE-----"); + else + return false; + return true; + } + + private boolean validCertificate(String cert_string) { + boolean result = false; + if(!cert_string.isEmpty()) { + X509Certificate certCert = ConfigHelper.parseX509CertificateFromString(cert_string); + try { + Base64.encodeToString( certCert.getEncoded(), Base64.DEFAULT); + result = true; + } catch (CertificateEncodingException e) { + Log.d(TAG, e.getLocalizedMessage()); + } + } + + return result; + } + + private boolean getAndSetProviderJson(String provider_main_url) { + boolean result = false; + + String provider_dot_json_string = downloadWithProviderCA(provider_main_url + "/provider.json", true); + + try { + JSONObject provider_json = new JSONObject(provider_dot_json_string); + String name = provider_json.getString(Provider.NAME); + //TODO setProviderName(name); + + ConfigHelper.saveSharedPref(Provider.KEY, provider_json); + ConfigHelper.saveSharedPref(EIP.ALLOWED_ANON, provider_json.getJSONObject(Provider.SERVICE).getBoolean(EIP.ALLOWED_ANON)); + ProviderItem added_provider = new ProviderItem(name, provider_main_url); + + result = true; + } catch (JSONException e) { + } return result; } + + private boolean getAndSetEipServiceJson() { + boolean result = false; + + try { + JSONObject provider_json = ConfigHelper.getJsonFromSharedPref(Provider.KEY); + String eip_service_url = provider_json.getString(Provider.API_URL) + "/" + provider_json.getString(Provider.API_VERSION) + "/" + EIP.SERVICE_API_PATH; + String eip_service_json_string = downloadWithProviderCA(eip_service_url, true); + JSONObject eip_service_json = new JSONObject(eip_service_json_string); + eip_service_json.getInt(Provider.API_RETURN_SERIAL); + + ConfigHelper.saveSharedPref(EIP.KEY, eip_service_json); + result = true; + } catch (JSONException e) { + } + return result; + } /** * Tries to download the contents of the provided url using commercially validated CA certificate from chosen provider. * @@ -543,13 +610,13 @@ public class ProviderAPI extends IntentService { json_file_content = formatErrorMessage(R.string.server_is_down_message); } catch (IOException e) { if(provider_url != null) { - json_file_content = downloadWithProviderCA(provider_url, danger_on); + json_file_content = downloadWithProviderCA(string_url, danger_on); } else { json_file_content = formatErrorMessage(R.string.certificate_error); } } catch (Exception e) { if(provider_url != null && danger_on) { - json_file_content = downloadWithProviderCA(provider_url, danger_on); + json_file_content = downloadWithProviderCA(string_url, danger_on); } } @@ -557,15 +624,16 @@ public class ProviderAPI extends IntentService { } /** - * Tries to download the contents of the provided url using not commercially validated CA certificate from chosen provider. - * @param url + * Tries to download the contents of the provided url using not commercially validated CA certificate from chosen provider. + * @param url as a string * @param danger_on true to download CA certificate in case it has not been downloaded. * @return an empty string if it fails, the url content if not. */ - private String downloadWithProviderCA(URL url, boolean danger_on) { + private String downloadWithProviderCA(String url_string, boolean danger_on) { String json_file_content = ""; try { + URL url = new URL(url_string); // Tell the URLConnection to use a SocketFactory from our SSLContext HttpsURLConnection urlConnection = (HttpsURLConnection)url.openConnection(); @@ -579,7 +647,7 @@ public class ProviderAPI extends IntentService { } catch (IOException e) { // The downloaded certificate doesn't validate our https connection. if(danger_on) { - json_file_content = downloadWithoutCA(url); + json_file_content = downloadWithoutCA(url_string); } else { json_file_content = formatErrorMessage(R.string.certificate_error); } @@ -622,7 +690,7 @@ public class ProviderAPI extends IntentService { /** * Downloads the string that's in the url with any certificate. */ - private String downloadWithoutCA(URL url) { + private String downloadWithoutCA(String url_string) { String string = ""; try { @@ -650,6 +718,7 @@ public class ProviderAPI extends IntentService { SSLContext context = SSLContext.getInstance("TLS"); context.init(new KeyManager[0], new TrustManager[] {new DefaultTrustManager()}, new SecureRandom()); + URL url = new URL(url_string); HttpsURLConnection urlConnection = (HttpsURLConnection)url.openConnection(); urlConnection.setSSLSocketFactory(context.getSocketFactory()); urlConnection.setHostnameVerifier(hostnameVerifier); @@ -741,7 +810,7 @@ public class ProviderAPI extends IntentService { String new_cert_string_url = provider_main_url.toString() + "/" + provider_json.getString(Provider.API_VERSION) + "/" + EIP.CERTIFICATE; boolean danger_on = ConfigHelper.getBoolFromSharedPref(ProviderItem.DANGER_ON); - String cert_string = downloadWithCommercialCA(new_cert_string_url, danger_on); + String cert_string = downloadWithProviderCA(new_cert_string_url, true); if(!cert_string.isEmpty()) { if(ConfigHelper.checkErroneousDownload(cert_string)) { String reason_to_fail = provider_json.getString(ERRORS); diff --git a/src/se/leap/bitmaskclient/ProviderListContent.java b/src/se/leap/bitmaskclient/ProviderListContent.java index af61dbd6..b13c5db4 100644 --- a/src/se/leap/bitmaskclient/ProviderListContent.java +++ b/src/se/leap/bitmaskclient/ProviderListContent.java @@ -62,8 +62,7 @@ public class ProviderListContent { final public static String CUSTOM = "custom"; final public static String DANGER_ON = "danger_on"; private String provider_main_url; - private String name; - private boolean danger_on = false; + private String name; /** * @param name of the provider @@ -71,7 +70,7 @@ public class ProviderListContent { * @param custom if it's a new provider entered by the user or not * @param danger_on if the user trusts completely the new provider */ - public ProviderItem(String name, InputStream urls_file_input_stream, boolean custom, boolean danger_on) { + public ProviderItem(String name, InputStream urls_file_input_stream) { try { byte[] urls_file_bytes = new byte[urls_file_input_stream.available()]; @@ -80,7 +79,6 @@ public class ProviderListContent { JSONObject file_contents = new JSONObject(urls_file_content); provider_main_url = file_contents.getString(Provider.MAIN_URL); this.name = name; - this.danger_on = danger_on; } catch (JSONException e) { // TODO Auto-generated catch block e.printStackTrace(); @@ -95,12 +93,10 @@ public class ProviderListContent { * @param provider_main_url used to download provider.json file of the provider * @param provider_json already downloaded * @param custom if it's a new provider entered by the user or not - * @param danger_on if the user trusts completely the new provider */ - public ProviderItem(String name, String provider_main_url, boolean danger_on) { + public ProviderItem(String name, String provider_main_url) { this.name = name; - this.provider_main_url = provider_main_url; - this.danger_on = danger_on; + this.provider_main_url = provider_main_url; } public String name() { return name; } @@ -114,7 +110,5 @@ public class ProviderListContent { return provider_main_url.replaceFirst("http[s]?://", "").replaceFirst("/.*", ""); } } - - public boolean completelyTrusted() { return danger_on; } } } -- cgit v1.2.3 From 9a33e4ccff4cf148a1a3ac3bbf20fcaf0238f24b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Mon, 14 Oct 2013 16:04:56 +0200 Subject: A bit of cleaning. --- src/se/leap/bitmaskclient/ConfigurationWizard.java | 96 +++------------------- src/se/leap/bitmaskclient/ProviderAPI.java | 92 ++------------------- src/se/leap/bitmaskclient/ProviderListContent.java | 2 - 3 files changed, 18 insertions(+), 172 deletions(-) diff --git a/src/se/leap/bitmaskclient/ConfigurationWizard.java b/src/se/leap/bitmaskclient/ConfigurationWizard.java index 6c02d612..ee42bae9 100644 --- a/src/se/leap/bitmaskclient/ConfigurationWizard.java +++ b/src/se/leap/bitmaskclient/ConfigurationWizard.java @@ -30,7 +30,6 @@ import android.app.DialogFragment; import android.app.Fragment; import android.app.FragmentManager; import android.app.FragmentTransaction; -import android.app.ListFragment; import android.content.Context; import android.content.Intent; import android.content.res.AssetManager; @@ -126,17 +125,10 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn .replace(R.id.configuration_wizard_layout, new_provider_list_fragment, ProviderListFragment.TAG) .commit(); } - - private void setProviderList(ProviderListFragment new_provider_list_fragment) { - FragmentManager fragmentManager = getFragmentManager(); - fragmentManager.beginTransaction() - .replace(R.id.configuration_wizard_layout, new_provider_list_fragment, ProviderListFragment.TAG) - .commit(); - } @Override public void onReceiveResult(int resultCode, Bundle resultData) { - if(resultCode == ProviderAPI.CORRECTLY_UPDATED_PROVIDER_DOT_JSON) { + if(resultCode == ProviderAPI.PROVIDER_OK) { JSONObject provider_json; try { provider_json = new JSONObject(resultData.getString(Provider.KEY)); @@ -185,42 +177,16 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn //refreshProviderList(0); //Toast.makeText(this, getResources().getString(R.string.config_error_parsing), Toast.LENGTH_LONG); setResult(RESULT_CANCELED, mConfigState); - } - } - else if(resultCode == ProviderAPI.INCORRECTLY_UPDATED_PROVIDER_DOT_JSON) { + } + } else if(resultCode == ProviderAPI.PROVIDER_NOK) { + //refreshProviderList(0); String reason_to_fail = resultData.getString(ProviderAPI.ERRORS); showDownloadFailedDialog(getCurrentFocus(), reason_to_fail); - refreshProviderList(0); mProgressBar.setVisibility(ProgressBar.GONE); - progressbar_description.setVisibility(TextView.GONE); + progressbar_description.setVisibility(TextView.GONE); ConfigHelper.removeFromSharedPref(Provider.KEY); setResult(RESULT_CANCELED, mConfigState); } - else if(resultCode == ProviderAPI.CORRECTLY_DOWNLOADED_JSON_FILES) { - mProgressBar.incrementProgressBy(1); - if (ConfigHelper.getBoolFromSharedPref(EIP.ALLOWED_ANON)){ - mConfigState.putExtra(SERVICES_RETRIEVED, true); - downloadAnonCert(); - } else { - mProgressBar.incrementProgressBy(1); - mProgressBar.setVisibility(ProgressBar.GONE); - progressbar_description.setVisibility(TextView.GONE); - //refreshProviderList(0); - //Toast.makeText(getApplicationContext(), R.string.success, Toast.LENGTH_LONG).show(); - setResult(RESULT_OK); - showProviderDetails(getCurrentFocus()); - } - } - else if(resultCode == ProviderAPI.INCORRECTLY_DOWNLOADED_JSON_FILES) { - //Toast.makeText(getApplicationContext(), R.string.incorrectly_downloaded_json_files_message, Toast.LENGTH_LONG).show(); - String reason_to_fail = resultData.getString(ProviderAPI.ERRORS); - showDownloadFailedDialog(getCurrentFocus(), reason_to_fail); - refreshProviderList(0); - //Toast.makeText(getApplicationContext(), R.string.incorrectly_downloaded_json_files_message, - mProgressBar.setVisibility(ProgressBar.GONE); - progressbar_description.setVisibility(TextView.GONE); - setResult(RESULT_CANCELED, mConfigState); - } else if(resultCode == ProviderAPI.CORRECTLY_DOWNLOADED_CERTIFICATE) { mProgressBar.incrementProgressBy(1); mProgressBar.setVisibility(ProgressBar.GONE); @@ -249,7 +215,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn int provider_index = getProviderIndex(id); startProgressBar(provider_index); mSelectedProvider = selected_provider; - updateProviderDotJson(mSelectedProvider.providerMainUrl(), true); + setUpProvider(mSelectedProvider.providerMainUrl(), true); } @Override @@ -353,34 +319,6 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn return loaded_preseeded_providers; } - - /** - * Asks ProviderAPI to download provider site's certificate and eip-service.json - * - * URLs are fetched from the provider parameter - * @param provider_json describing the provider from which certificate and eip-service.json files are going to be downloaded - */ - private void downloadJSONFiles(JSONObject provider_json, boolean danger_on) { - try { - Intent provider_API_command = new Intent(this, ProviderAPI.class); - - Bundle parameters = new Bundle(); - - parameters.putBoolean(ProviderItem.DANGER_ON, danger_on); - parameters.putString(Provider.CA_CERT, provider_json.getString("ca_cert_uri")); - String eip_service_url = provider_json.getString(Provider.API_URL) + "/" + provider_json.getString(Provider.API_VERSION) + "/config/eip-service.json"; - parameters.putString(EIP.KEY, eip_service_url); - - provider_API_command.setAction(ProviderAPI.DOWNLOAD_JSON_FILES_BUNDLE_EXTRA); - provider_API_command.putExtra(ProviderAPI.PARAMETERS, parameters); - provider_API_command.putExtra(ProviderAPI.RECEIVER_KEY, providerAPI_result_receiver); - - startService(provider_API_command); - } catch (JSONException e) { - //TODO Show error to the user. This will eventually be transformed to "unselectProvider()", which will show the graphical notice itself. - ConfigHelper.removeFromSharedPref(Provider.KEY); - } - } /** * Asks ProviderAPI to download an anonymous (anon) VPN certificate. @@ -453,27 +391,13 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn public void showAndSelectProvider(String provider_main_url, boolean danger_on) { showProvider(provider_main_url, danger_on); - updateProviderDotJson(provider_main_url, danger_on); + setUpProvider(provider_main_url, danger_on); } private void showProvider(final String provider_main_url, final boolean danger_on) { String provider_name = provider_main_url.replaceFirst("http[s]?://", "").replaceFirst("\\/", "_"); - final ProviderItem added_provider = new ProviderItem(provider_name, provider_main_url); - - //ProviderListContent.addItem(added_provider); - provider_list_fragment.addItem(added_provider); - /*ProviderListFragment provider_list_fragment = (ProviderListFragment) getFragmentManager().findFragmentByTag(ProviderListFragment.TAG); - //provider_list_fragment.notifyAdapter(); + ProviderItem added_provider = new ProviderItem(provider_name, provider_main_url); provider_list_fragment.addItem(added_provider); - refreshProviderList(0); - - runOnUiThread(new Runnable() { - - @Override - public void run() { - provider_list_fragment.addItem(added_provider); - } - });*/ } /** @@ -482,13 +406,13 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn * @param provider_main_url * @param danger_on tells if HTTPS client should bypass certificate errors */ - public void updateProviderDotJson(String provider_main_url, boolean danger_on) { + public void setUpProvider(String provider_main_url, boolean danger_on) { Intent provider_API_command = new Intent(this, ProviderAPI.class); Bundle parameters = new Bundle(); parameters.putString(Provider.MAIN_URL, provider_main_url); parameters.putBoolean(ProviderItem.DANGER_ON, danger_on); - provider_API_command.setAction(ProviderAPI.UPDATE_PROVIDER_DOTJSON); + provider_API_command.setAction(ProviderAPI.SET_UP_PROVIDER); provider_API_command.putExtra(ProviderAPI.PARAMETERS, parameters); provider_API_command.putExtra(ProviderAPI.RECEIVER_KEY, providerAPI_result_receiver); diff --git a/src/se/leap/bitmaskclient/ProviderAPI.java b/src/se/leap/bitmaskclient/ProviderAPI.java index 6003fa6c..60ed1e1f 100644 --- a/src/se/leap/bitmaskclient/ProviderAPI.java +++ b/src/se/leap/bitmaskclient/ProviderAPI.java @@ -85,8 +85,7 @@ public class ProviderAPI extends IntentService { private Handler mHandler; final public static String - DOWNLOAD_JSON_FILES_BUNDLE_EXTRA = "downloadJSONFiles", - UPDATE_PROVIDER_DOTJSON = "updateProviderDotJSON", + SET_UP_PROVIDER = "setUpProvider", DOWNLOAD_NEW_PROVIDER_DOTJSON = "downloadNewProviderDotJSON", SRP_REGISTER = "srpRegister", SRP_AUTH = "srpAuth", @@ -105,8 +104,6 @@ public class ProviderAPI extends IntentService { final public static int CUSTOM_PROVIDER_ADDED = 0, - CORRECTLY_DOWNLOADED_JSON_FILES = 1, - INCORRECTLY_DOWNLOADED_JSON_FILES = 2, SRP_AUTHENTICATION_SUCCESSFUL = 3, SRP_AUTHENTICATION_FAILED = 4, SRP_REGISTRATION_SUCCESSFUL = 5, @@ -115,8 +112,8 @@ public class ProviderAPI extends IntentService { LOGOUT_FAILED = 8, CORRECTLY_DOWNLOADED_CERTIFICATE = 9, INCORRECTLY_DOWNLOADED_CERTIFICATE = 10, - CORRECTLY_UPDATED_PROVIDER_DOT_JSON = 11, - INCORRECTLY_UPDATED_PROVIDER_DOT_JSON = 12, + PROVIDER_OK = 11, + PROVIDER_NOK = 12, CORRECTLY_DOWNLOADED_ANON_CERTIFICATE = 13, INCORRECTLY_DOWNLOADED_ANON_CERTIFICATE = 14 ; @@ -143,19 +140,12 @@ public class ProviderAPI extends IntentService { String action = command.getAction(); Bundle parameters = command.getBundleExtra(PARAMETERS); - if(action.equalsIgnoreCase(DOWNLOAD_JSON_FILES_BUNDLE_EXTRA)) { - Bundle result = downloadJsonFiles(parameters); + if(action.equalsIgnoreCase(SET_UP_PROVIDER)) { + Bundle result = setUpProvider(parameters); if(result.getBoolean(RESULT_KEY)) { - receiver.send(CORRECTLY_DOWNLOADED_JSON_FILES, Bundle.EMPTY); - } else { - receiver.send(INCORRECTLY_DOWNLOADED_JSON_FILES, result); - } - } else if(action.equalsIgnoreCase(UPDATE_PROVIDER_DOTJSON)) { - Bundle result = updateProviderDotJSON(parameters); - if(result.getBoolean(RESULT_KEY)) { - receiver.send(CORRECTLY_UPDATED_PROVIDER_DOT_JSON, result); + receiver.send(PROVIDER_OK, result); } else { - receiver.send(INCORRECTLY_UPDATED_PROVIDER_DOT_JSON, Bundle.EMPTY); + receiver.send(PROVIDER_NOK, Bundle.EMPTY); } } else if (action.equalsIgnoreCase(SRP_AUTH)) { Bundle session_id_bundle = authenticateBySRP(parameters); @@ -178,63 +168,6 @@ public class ProviderAPI extends IntentService { } } } - - /** - * Downloads the main cert and the eip-service.json files given through the task parameter - * @param task - * @return true if eip-service.json was parsed as a JSON object correctly. - */ - private Bundle downloadJsonFiles(Bundle task) { - Bundle result = new Bundle(); - String cert_url = task.getString(Provider.CA_CERT); - String eip_service_json_url = task.getString(EIP.KEY); - boolean danger_on = task.getBoolean(ProviderItem.DANGER_ON); - try { - String cert_string = downloadWithCommercialCA(cert_url, danger_on); - - if(ConfigHelper.checkErroneousDownload(cert_string)) { - JSONObject possible_errors = new JSONObject(cert_string); - String reason_to_fail = ""; - if(cert_string.isEmpty()) - reason_to_fail = "Empty certificate downloaded"; - else - reason_to_fail = possible_errors.getString(ERRORS); - result.putString(ERRORS, reason_to_fail); - result.putBoolean(RESULT_KEY, false); - } else { - X509Certificate certCert = ConfigHelper.parseX509CertificateFromString(cert_string); - cert_string = Base64.encodeToString( certCert.getEncoded(), Base64.DEFAULT); - ConfigHelper.saveSharedPref(Provider.CA_CERT, "-----BEGIN CERTIFICATE-----\n"+cert_string+"-----END CERTIFICATE-----"); - } - } catch (JSONException e) { - e.printStackTrace(); - result.putBoolean(RESULT_KEY, false); - } catch (CertificateException e) { - // TODO Auto-generated catch block - e.printStackTrace(); - result.putBoolean(RESULT_KEY, false); - } - - try { - String eip_service_string = downloadWithCommercialCA(eip_service_json_url, danger_on); - JSONObject eip_service_json = new JSONObject(eip_service_string); - if(eip_service_json.has(ERRORS)) { - String reason_to_fail = eip_service_json.getString(ERRORS); - result.putString(ERRORS, reason_to_fail); - result.putBoolean(RESULT_KEY, false); - } - else { - ConfigHelper.saveSharedPref(EIP.KEY, eip_service_json); - ConfigHelper.saveSharedPref(EIP.PARSED_SERIAL, 0); - } - - result.putBoolean(RESULT_KEY, true); - } catch (JSONException e) { - result.putBoolean(RESULT_KEY, false); - } - - return result; - } /** * Starts the authentication process using SRP protocol. @@ -486,7 +419,7 @@ public class ProviderAPI extends IntentService { * @param task containing a boolean meaning if the provider is custom or not, another boolean meaning if the user completely trusts this provider, the provider name and its provider.json url. * @return a bundle with a boolean value mapped to a key named RESULT_KEY, and which is true if the update was successful. */ - private Bundle updateProviderDotJSON(Bundle task) { + private Bundle setUpProvider(Bundle task) { Bundle result = new Bundle(); boolean danger_on = task.getBoolean(ProviderItem.DANGER_ON); String provider_main_url = task.getString(Provider.MAIN_URL); @@ -740,15 +673,6 @@ public class ProviderAPI extends IntentService { } return string; } - - /** - * Tries to guess the provider.json url given the main provider url. - * @param provider_main_url - * @return the guessed provider.json url - */ - private String guessProviderDotJsonURL(String provider_main_url) { - return provider_main_url + "/provider.json"; - } /** * Logs out from the api url retrieved from the task. diff --git a/src/se/leap/bitmaskclient/ProviderListContent.java b/src/se/leap/bitmaskclient/ProviderListContent.java index b13c5db4..e1ca4f9a 100644 --- a/src/se/leap/bitmaskclient/ProviderListContent.java +++ b/src/se/leap/bitmaskclient/ProviderListContent.java @@ -28,8 +28,6 @@ import java.net.MalformedURLException; import org.json.JSONException; import org.json.JSONObject; -import android.app.Activity; - /** * Models the provider list shown in the ConfigurationWizard. * -- cgit v1.2.3 From b61c632cb90b87cc7b069f42f2b08928ee15a5d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Mon, 14 Oct 2013 17:05:06 +0200 Subject: ProviderAPI broadcasts progress to CW. Setting up a provider makes the progressbar move according to the number of files downloaded (1/3, 2/3, 3/3). Next step: recover from download errors individually. That means that if a download fails but the others went OK, the user will be prompted to retry that individual failing download. --- src/se/leap/bitmaskclient/ConfigurationWizard.java | 78 +++++++++++++--------- src/se/leap/bitmaskclient/Dashboard.java | 21 +----- src/se/leap/bitmaskclient/ProviderAPI.java | 38 +++-------- src/se/leap/bitmaskclient/ProviderListAdapter.java | 1 - .../leap/bitmaskclient/ProviderListFragment.java | 8 ++- 5 files changed, 61 insertions(+), 85 deletions(-) diff --git a/src/se/leap/bitmaskclient/ConfigurationWizard.java b/src/se/leap/bitmaskclient/ConfigurationWizard.java index ee42bae9..b35123b0 100644 --- a/src/se/leap/bitmaskclient/ConfigurationWizard.java +++ b/src/se/leap/bitmaskclient/ConfigurationWizard.java @@ -30,8 +30,10 @@ import android.app.DialogFragment; import android.app.Fragment; import android.app.FragmentManager; import android.app.FragmentTransaction; +import android.content.BroadcastReceiver; import android.content.Context; import android.content.Intent; +import android.content.IntentFilter; import android.content.res.AssetManager; import android.os.Bundle; import android.os.Handler; @@ -61,7 +63,6 @@ import android.widget.TextView; public class ConfigurationWizard extends Activity implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogInterface, ProviderDetailFragment.ProviderDetailFragmentInterface, Receiver { - private ProviderItem mSelectedProvider; private ProgressBar mProgressBar; private TextView progressbar_description; private ProviderListFragment provider_list_fragment; @@ -76,6 +77,8 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn final protected static String SERVICES_RETRIEVED = "SERVICES RETRIEVED"; public ProviderAPIResultReceiver providerAPI_result_receiver; + private ProviderAPIBroadcastReceiver_Update providerAPI_broadcast_receiver_update; + @Override protected void onCreate(Bundle savedInstanceState) { @@ -88,7 +91,11 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn progressbar_description.setVisibility(TextView.INVISIBLE); providerAPI_result_receiver = new ProviderAPIResultReceiver(new Handler()); providerAPI_result_receiver.setReceiver(this); - + providerAPI_broadcast_receiver_update = new ProviderAPIBroadcastReceiver_Update(); + IntentFilter update_intent_filter = new IntentFilter(ProviderAPI.UPDATE_PROGRESSBAR); + update_intent_filter.addCategory(Intent.CATEGORY_DEFAULT); + registerReceiver(providerAPI_broadcast_receiver_update, update_intent_filter); + ConfigHelper.setSharedPreferences(getSharedPreferences(Dashboard.SHARED_PREFERENCES, MODE_PRIVATE)); loadPreseededProviders(); @@ -114,6 +121,12 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn // TODO: If exposing deep links into your app, handle intents here. } + @Override + protected void onDestroy() { + super.onDestroy(); + unregisterReceiver(providerAPI_broadcast_receiver_update); + } + public void refreshProviderList(int top_padding) { ProviderListFragment new_provider_list_fragment = new ProviderListFragment(); Bundle top_padding_bundle = new Bundle(); @@ -133,29 +146,8 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn try { provider_json = new JSONObject(resultData.getString(Provider.KEY)); boolean danger_on = resultData.getBoolean(ProviderItem.DANGER_ON); - ConfigHelper.saveSharedPref(Provider.KEY, provider_json); - ConfigHelper.saveSharedPref(ProviderItem.DANGER_ON, danger_on); - ConfigHelper.saveSharedPref(EIP.ALLOWED_ANON, provider_json.getJSONObject(Provider.SERVICE).getBoolean(EIP.ALLOWED_ANON)); mConfigState.setAction(PROVIDER_SET); - if(resultData.containsKey(Provider.NAME)) { - String provider_id = resultData.getString(Provider.NAME); - mSelectedProvider = getProvider(provider_id); - //provider_list_fragment.addItem(mSelectedProvider); - //ProviderListContent.removeItem(mSelectedProvider); - - //refreshProviderList(0); - - if(!mProgressBar.isShown()) { - int provider_index = getProviderIndex(provider_id); - startProgressBar(provider_index); - provider_list_fragment.hide(provider_index-2); - //setProviderList(provider_list_fragment); - } - mProgressBar.incrementProgressBy(1); - } - - if (ConfigHelper.getBoolFromSharedPref(EIP.ALLOWED_ANON)){ mConfigState.putExtra(SERVICES_RETRIEVED, true); downloadAnonCert(); @@ -163,14 +155,10 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn mProgressBar.incrementProgressBy(1); mProgressBar.setVisibility(ProgressBar.GONE); progressbar_description.setVisibility(TextView.GONE); - //refreshProviderList(0); - //Toast.makeText(getApplicationContext(), R.string.success, Toast.LENGTH_LONG).show(); setResult(RESULT_OK); showProviderDetails(getCurrentFocus()); } - //downloadJSONFiles(provider_json, danger_on); } catch (JSONException e) { - // TODO Auto-generated catch block e.printStackTrace(); mProgressBar.setVisibility(ProgressBar.GONE); progressbar_description.setVisibility(TextView.GONE); @@ -214,8 +202,8 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn ProviderItem selected_provider = getProvider(id); int provider_index = getProviderIndex(id); startProgressBar(provider_index); - mSelectedProvider = selected_provider; - setUpProvider(mSelectedProvider.providerMainUrl(), true); + provider_list_fragment.hideAllBut(provider_index); + setUpProvider(selected_provider.providerMainUrl(), true); } @Override @@ -238,16 +226,27 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn setResult(RESULT_CANCELED, ask_quit); } - private ProviderItem getProvider(String id) { + private ProviderItem getProvider(String name) { Iterator providers_iterator = ProviderListContent.ITEMS.iterator(); while(providers_iterator.hasNext()) { ProviderItem provider = providers_iterator.next(); - if(provider.name().equalsIgnoreCase(id)) { + if(provider.name().equalsIgnoreCase(name)) { return provider; } } return null; } + + private String getId(String provider_main_url) { + Iterator providers_iterator = ProviderListContent.ITEMS.iterator(); + while(providers_iterator.hasNext()) { + ProviderItem provider = providers_iterator.next(); + if(provider.providerMainUrl().equalsIgnoreCase(provider_main_url)) { + return provider.name(); + } + } + return ""; + } private void startProgressBar(int list_item_index) { mProgressBar.setVisibility(ProgressBar.VISIBLE); @@ -264,10 +263,10 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn Iterator providers_iterator = ProviderListContent.ITEMS.iterator(); while(providers_iterator.hasNext()) { ProviderItem provider = providers_iterator.next(); - index++; if(provider.name().equalsIgnoreCase(id)) { break; } + index++; } return index; } @@ -391,7 +390,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn public void showAndSelectProvider(String provider_main_url, boolean danger_on) { showProvider(provider_main_url, danger_on); - setUpProvider(provider_main_url, danger_on); + autoSelectProvider(provider_main_url, danger_on); } private void showProvider(final String provider_main_url, final boolean danger_on) { @@ -400,6 +399,10 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn provider_list_fragment.addItem(added_provider); } + private void autoSelectProvider(String provider_main_url, boolean danger_on) { + onItemSelected(getId(provider_main_url)); + } + /** * Asks ProviderAPI to download a new provider.json file * @param provider_name @@ -475,4 +478,13 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn setResult(RESULT_OK); finish(); } + + public class ProviderAPIBroadcastReceiver_Update extends BroadcastReceiver { + + @Override + public void onReceive(Context context, Intent intent) { + int update = intent.getIntExtra(ProviderAPI.CURRENT_PROGRESS, 0); + mProgressBar.setProgress(update); + } + } } diff --git a/src/se/leap/bitmaskclient/Dashboard.java b/src/se/leap/bitmaskclient/Dashboard.java index 0ae7085a..8c7c495d 100644 --- a/src/se/leap/bitmaskclient/Dashboard.java +++ b/src/se/leap/bitmaskclient/Dashboard.java @@ -16,8 +16,6 @@ */ package se.leap.bitmaskclient; -import org.apache.http.cookie.Cookie; -import org.apache.http.impl.cookie.BasicClientCookie; import org.json.JSONException; import org.json.JSONObject; @@ -30,12 +28,9 @@ import android.app.DialogFragment; import android.app.Fragment; import android.app.FragmentManager; import android.app.FragmentTransaction; -import android.app.ProgressDialog; -import android.content.BroadcastReceiver; import android.content.Context; import android.content.DialogInterface; import android.content.Intent; -import android.content.IntentFilter; import android.content.SharedPreferences; import android.os.Bundle; import android.os.Handler; @@ -45,11 +40,7 @@ import android.view.Menu; import android.view.MenuItem; import android.view.View; import android.view.ViewGroup; -import android.view.ViewStub; -import android.widget.CompoundButton; import android.widget.ProgressBar; -import android.widget.RelativeLayout; -import android.widget.Switch; import android.widget.TextView; import android.widget.Toast; @@ -76,7 +67,6 @@ public class Dashboard extends Activity implements LogInDialog.LogInDialogInterf private ProgressBar mProgressBar; private TextView eipStatus; - private ProviderAPIBroadcastReceiver_Update providerAPI_broadcast_receiver_update; private static Context app; private static SharedPreferences preferences; private static Provider provider; @@ -98,10 +88,7 @@ public class Dashboard extends Activity implements LogInDialog.LogInDialogInterf // mProgressBar = (ProgressBar) findViewById(R.id.eipProgress); // eipStatus = (TextView) findViewById(R.id.eipStatus); - providerAPI_broadcast_receiver_update = new ProviderAPIBroadcastReceiver_Update(); - IntentFilter update_intent_filter = new IntentFilter(ProviderAPI.UPDATE_ACTION); - update_intent_filter.addCategory(Intent.CATEGORY_DEFAULT); - registerReceiver(providerAPI_broadcast_receiver_update, update_intent_filter); + mProgressBar = (ProgressBar) findViewById(R.id.eipProgress); ConfigHelper.setSharedPreferences(getSharedPreferences(SHARED_PREFERENCES, MODE_PRIVATE)); preferences = ConfigHelper.shared_preferences; @@ -116,7 +103,6 @@ public class Dashboard extends Activity implements LogInDialog.LogInDialogInterf @Override protected void onDestroy() { super.onDestroy(); - unregisterReceiver(providerAPI_broadcast_receiver_update); } @Override @@ -176,11 +162,6 @@ public class Dashboard extends Activity implements LogInDialog.LogInDialogInterf provider.init( this ); setContentView(R.layout.client_dashboard); - - providerAPI_broadcast_receiver_update = new ProviderAPIBroadcastReceiver_Update(); - IntentFilter update_intent_filter = new IntentFilter(ProviderAPI.UPDATE_ACTION); - update_intent_filter.addCategory(Intent.CATEGORY_DEFAULT); - registerReceiver(providerAPI_broadcast_receiver_update, update_intent_filter); providerNameTV = (TextView) findViewById(R.id.providerName); providerNameTV.setText(provider.getDomain()); diff --git a/src/se/leap/bitmaskclient/ProviderAPI.java b/src/se/leap/bitmaskclient/ProviderAPI.java index 60ed1e1f..27081df2 100644 --- a/src/se/leap/bitmaskclient/ProviderAPI.java +++ b/src/se/leap/bitmaskclient/ProviderAPI.java @@ -97,8 +97,8 @@ public class ProviderAPI extends IntentService { SESSION_ID_COOKIE_KEY = "session_id_cookie_key", SESSION_ID_KEY = "session_id", ERRORS = "errors", - UPDATE_ACTION = "update_action", - UPDATE_DATA = "update data", + UPDATE_PROGRESSBAR = "update_action", + CURRENT_PROGRESS = "update data", TAG = "provider_api_tag" ; @@ -266,9 +266,9 @@ public class ProviderAPI extends IntentService { */ private void broadcast_progress(int progress) { Intent intentUpdate = new Intent(); - intentUpdate.setAction(UPDATE_ACTION); + intentUpdate.setAction(UPDATE_PROGRESSBAR); intentUpdate.addCategory(Intent.CATEGORY_DEFAULT); - intentUpdate.putExtra(UPDATE_DATA, progress); + intentUpdate.putExtra(CURRENT_PROGRESS, progress); sendBroadcast(intentUpdate); } @@ -421,38 +421,18 @@ public class ProviderAPI extends IntentService { */ private Bundle setUpProvider(Bundle task) { Bundle result = new Bundle(); + int progress = 0; boolean danger_on = task.getBoolean(ProviderItem.DANGER_ON); String provider_main_url = task.getString(Provider.MAIN_URL); if(downloadCACert(provider_main_url, danger_on)) { + broadcast_progress(progress++); result.putBoolean(RESULT_KEY, true); - if(getAndSetProviderJson(provider_main_url)) + if(getAndSetProviderJson(provider_main_url)) { + broadcast_progress(progress++); if(getAndSetEipServiceJson()) - ; - } - /* - try { - String provider_dot_json_string = downloadWithCommercialCA(provider_json_url, danger_on); - if(provider_dot_json_string.isEmpty()) { - result.putBoolean(RESULT_KEY, false); - } else { - JSONObject provider_json = new JSONObject(provider_dot_json_string); - if(provider_json.has(ERRORS)) { - String reason_to_fail = provider_json.getString(ERRORS); - result.putString(ERRORS, reason_to_fail); - result.putBoolean(RESULT_KEY, false); - } else { - ConfigHelper.saveSharedPref(EIP.ALLOWED_ANON, provider_json.getJSONObject(Provider.SERVICE).getBoolean(EIP.ALLOWED_ANON)); - - result.putString(Provider.NAME, added_provider.name()); - result.putBoolean(RESULT_KEY, true); - result.putString(Provider.KEY, provider_json.toString()); - result.putBoolean(ProviderItem.DANGER_ON, danger_on); + broadcast_progress(progress++); } - } catch (JSONException e) { - result.putBoolean(RESULT_KEY, false); - result.putString(ERRORS, "Corrupt download"); } - */ return result; } diff --git a/src/se/leap/bitmaskclient/ProviderListAdapter.java b/src/se/leap/bitmaskclient/ProviderListAdapter.java index bb1318fc..4abf15a2 100644 --- a/src/se/leap/bitmaskclient/ProviderListAdapter.java +++ b/src/se/leap/bitmaskclient/ProviderListAdapter.java @@ -1,6 +1,5 @@ package se.leap.bitmaskclient; -import java.lang.reflect.Array; import java.util.List; import android.content.Context; diff --git a/src/se/leap/bitmaskclient/ProviderListFragment.java b/src/se/leap/bitmaskclient/ProviderListFragment.java index 6a0f2a05..862177a2 100644 --- a/src/se/leap/bitmaskclient/ProviderListFragment.java +++ b/src/se/leap/bitmaskclient/ProviderListFragment.java @@ -202,8 +202,12 @@ public class ProviderListFragment extends ListFragment { content_adapter.notifyDataSetChanged(); } - public void hide(int position) { - content_adapter.hide(position); + public void hideAllBut(int position) { + for(int i = 0; i < content_adapter.getCount(); i++) + if(i != position) + content_adapter.hide(i); + else + content_adapter.unHide(i); } public void unhideAll() { -- cgit v1.2.3 From 4a28c438ac147854381a0be01889de9858218efe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Fri, 18 Oct 2013 08:56:00 +0200 Subject: CA cert saved correctly in SharedPreferences. I/O error at login phase fixed. --- src/se/leap/bitmaskclient/ProviderAPI.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/se/leap/bitmaskclient/ProviderAPI.java b/src/se/leap/bitmaskclient/ProviderAPI.java index 27081df2..b23bdc7f 100644 --- a/src/se/leap/bitmaskclient/ProviderAPI.java +++ b/src/se/leap/bitmaskclient/ProviderAPI.java @@ -439,7 +439,7 @@ public class ProviderAPI extends IntentService { private boolean downloadCACert(String provider_main_url, boolean danger_on) { String cert_string = downloadWithCommercialCA(provider_main_url + "/ca.crt", danger_on); if(validCertificate(cert_string)) - ConfigHelper.saveSharedPref(Provider.CA_CERT, "-----BEGIN CERTIFICATE-----\n"+cert_string+"-----END CERTIFICATE-----"); + ConfigHelper.saveSharedPref(Provider.CA_CERT, cert_string); else return false; -- cgit v1.2.3 From c3464b9bb7eed4409d817aa9ee59387fb4eb73e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Tue, 19 Nov 2013 18:02:43 +0100 Subject: Successfully rebased onto 0.2.2 --- src/se/leap/bitmaskclient/ConfigurationWizard.java | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/src/se/leap/bitmaskclient/ConfigurationWizard.java b/src/se/leap/bitmaskclient/ConfigurationWizard.java index b35123b0..a4d8599f 100644 --- a/src/se/leap/bitmaskclient/ConfigurationWizard.java +++ b/src/se/leap/bitmaskclient/ConfigurationWizard.java @@ -142,10 +142,6 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn @Override public void onReceiveResult(int resultCode, Bundle resultData) { if(resultCode == ProviderAPI.PROVIDER_OK) { - JSONObject provider_json; - try { - provider_json = new JSONObject(resultData.getString(Provider.KEY)); - boolean danger_on = resultData.getBoolean(ProviderItem.DANGER_ON); mConfigState.setAction(PROVIDER_SET); if (ConfigHelper.getBoolFromSharedPref(EIP.ALLOWED_ANON)){ @@ -157,15 +153,7 @@ implements ProviderListFragment.Callbacks, NewProviderDialog.NewProviderDialogIn progressbar_description.setVisibility(TextView.GONE); setResult(RESULT_OK); showProviderDetails(getCurrentFocus()); - } - } catch (JSONException e) { - e.printStackTrace(); - mProgressBar.setVisibility(ProgressBar.GONE); - progressbar_description.setVisibility(TextView.GONE); - //refreshProviderList(0); - //Toast.makeText(this, getResources().getString(R.string.config_error_parsing), Toast.LENGTH_LONG); - setResult(RESULT_CANCELED, mConfigState); - } + } } else if(resultCode == ProviderAPI.PROVIDER_NOK) { //refreshProviderList(0); String reason_to_fail = resultData.getString(ProviderAPI.ERRORS); -- cgit v1.2.3 From ee87387c8318796986e7e5dd4fb1278eab7f9624 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Mon, 9 Dec 2013 20:14:00 +0100 Subject: Rebased onto 0.2.3 --- src/se/leap/bitmaskclient/Dashboard.java | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/se/leap/bitmaskclient/Dashboard.java b/src/se/leap/bitmaskclient/Dashboard.java index 8c7c495d..7f898a67 100644 --- a/src/se/leap/bitmaskclient/Dashboard.java +++ b/src/se/leap/bitmaskclient/Dashboard.java @@ -465,13 +465,4 @@ public class Dashboard extends Activity implements LogInDialog.LogInDialogInterf startService(eip_intent); } - - public class ProviderAPIBroadcastReceiver_Update extends BroadcastReceiver { - - @Override - public void onReceive(Context context, Intent intent) { - int update = intent.getIntExtra(ProviderAPI.UPDATE_DATA, 0); - //mProgressBar.setProgress(update); - } - } } -- cgit v1.2.3 From dca94d79c3391568b4228cab26ea2f02de46cde4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Tue, 10 Dec 2013 17:39:43 +0100 Subject: Setting up a provider w/o connection doesn't fail. There was a nullpointer already fixed in another branch which completely complements this one. The message shown to the user is empty, but that belongs to bug/more-detailed-response-to-CW-errors. --- src/se/leap/bitmaskclient/ProviderAPI.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/se/leap/bitmaskclient/ProviderAPI.java b/src/se/leap/bitmaskclient/ProviderAPI.java index b23bdc7f..2a1cd29b 100644 --- a/src/se/leap/bitmaskclient/ProviderAPI.java +++ b/src/se/leap/bitmaskclient/ProviderAPI.java @@ -448,7 +448,7 @@ public class ProviderAPI extends IntentService { private boolean validCertificate(String cert_string) { boolean result = false; - if(!cert_string.isEmpty()) { + if(!ConfigHelper.checkErroneousDownload(cert_string)) { X509Certificate certCert = ConfigHelper.parseX509CertificateFromString(cert_string); try { Base64.encodeToString( certCert.getEncoded(), Base64.DEFAULT); -- cgit v1.2.3 From f35ac034aae5c344bcb84e6bfb17fe0886a4042a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Parm=C3=A9nides=20GV?= Date: Tue, 10 Dec 2013 20:45:35 +0100 Subject: Fixed algorithm to hide all but one provider. --- src/se/leap/bitmaskclient/ProviderListFragment.java | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/se/leap/bitmaskclient/ProviderListFragment.java b/src/se/leap/bitmaskclient/ProviderListFragment.java index 862177a2..501da609 100644 --- a/src/se/leap/bitmaskclient/ProviderListFragment.java +++ b/src/se/leap/bitmaskclient/ProviderListFragment.java @@ -156,11 +156,6 @@ public class ProviderListFragment extends ListFragment { // Notify the active callbacks interface (the activity, if the // fragment is attached to one) that an item has been selected. mCallbacks.onItemSelected(ProviderListContent.ITEMS.get(position).name()); - - for(int item_position = 0; item_position < listView.getCount(); item_position++) { - if(item_position != position) - content_adapter.hide(item_position); - } } @Override @@ -203,11 +198,15 @@ public class ProviderListFragment extends ListFragment { } public void hideAllBut(int position) { - for(int i = 0; i < content_adapter.getCount(); i++) - if(i != position) + int real_count = content_adapter.getCount(); + for(int i = 0; i < real_count;) + if(i != position) { content_adapter.hide(i); - else - content_adapter.unHide(i); + position--; + real_count--; + } else { + i++; + } } public void unhideAll() { -- cgit v1.2.3 From 72f1d170adbaa08ca846a0e4ec77556c9a7ffc7d Mon Sep 17 00:00:00 2001 From: cyBerta Date: Mon, 16 Dec 2013 20:02:54 +0100 Subject: remove 'Assigning IP address' from the progress notification (#4661) --- src/se/leap/bitmaskclient/EipServiceFragment.java | 5 ++++- src/se/leap/openvpn/OpenVpnService.java | 3 +-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/se/leap/bitmaskclient/EipServiceFragment.java b/src/se/leap/bitmaskclient/EipServiceFragment.java index e182b3fd..b409394b 100644 --- a/src/se/leap/bitmaskclient/EipServiceFragment.java +++ b/src/se/leap/bitmaskclient/EipServiceFragment.java @@ -202,7 +202,10 @@ public class EipServiceFragment extends Fragment implements StateListener, OnCli switchState = false; } else if (state.equals("NOPROCESS")){ statusMessage = logmessage; - } else { + } else if (state.equals("ASSIGN_IP")){ //don't show assigning message in eipStatus + statusMessage = (String) eipStatus.getText(); + } + else { statusMessage = prefix + " " + logmessage; } diff --git a/src/se/leap/openvpn/OpenVpnService.java b/src/se/leap/openvpn/OpenVpnService.java index f5b932f2..b5c9c798 100644 --- a/src/se/leap/openvpn/OpenVpnService.java +++ b/src/se/leap/openvpn/OpenVpnService.java @@ -482,8 +482,7 @@ public class OpenVpnService extends VpnService implements StateListener, Callbac if (("NOPROCESS".equals(state) ) || ("EXITING").equals(state)){ showNotification(state, getString(R.string.eip_state_not_connected), ticker, false, 0, persist); } - else if (state.equals("GET_CONFIG")){ - + else if (state.equals("GET_CONFIG") || state.equals("ASSIGN_IP")){ //don't show them in the notification message } else{ persist = true; -- cgit v1.2.3 From 4d9b896481594297421a157a5906b5a8ead48ab6 Mon Sep 17 00:00:00 2001 From: cyBerta Date: Mon, 16 Dec 2013 23:11:41 +0100 Subject: Correct the location name in the notification (Bug #4660) --- src/se/leap/bitmaskclient/EIP.java | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/se/leap/bitmaskclient/EIP.java b/src/se/leap/bitmaskclient/EIP.java index ec2f6972..edd73e83 100644 --- a/src/se/leap/bitmaskclient/EIP.java +++ b/src/se/leap/bitmaskclient/EIP.java @@ -439,7 +439,8 @@ public final class EIP extends IntentService { String ports = "ports"; String protos = "protocols"; String capabilities = "capabilities"; - String location = "location"; + String location_key = "location"; + String locations = "locations"; Vector arg = new Vector(); Vector> args = new Vector>(); @@ -456,7 +457,6 @@ public final class EIP extends IntentService { arg.add(word); value.add( (Vector) arg.clone() ); options.put(key, (Vector>) value.clone()); - value.clear(); arg.clear(); } @@ -477,16 +477,22 @@ public final class EIP extends IntentService { arg.clear(); args.clear(); + try { - arg.add(location); - arg.add(mGateway.getString(location)); + + arg.add(location_key); + String locationText = ""; + locationText = eipDefinition.getJSONObject(locations).getJSONObject(mGateway.getString(location_key)).getString("name"); + arg.add(locationText); + } catch (JSONException e) { // TODO Auto-generated catch block e.printStackTrace(); } args.add((Vector) arg.clone()); options.put("location", (Vector>) args.clone() ); + arg.clear(); args.clear(); JSONArray protocolsJSON = null; -- cgit v1.2.3