Age | Commit message (Collapse) | Author |
|
Logging in, it was returning a "Bad response from server" due to the malinterpretation of the received JSON. It was looking for a field named "m2", but it was "M2".
|
|
|
|
If there is an error while downloading CA cert on downloadJsonFiles, false is returned and progress dialog is dismissed.
|
|
They have been relocated to the corresponding classes.
|
|
|
|
|
|
I do not manually manage cookies anymore, letting HttpURLConnection
manage them via default CookieHandler (using
CookiePolicy.ACCEPT_ORIGINAL_SERVER).
|
|
SRP parameter A tries to be sent via HttpsURLConnection. Right now, we
have a problem with certificates because I'm not using provider CA cert
to get the response. I'm going to merge the branch with better method
names to download response using already existing code.
|
|
I send session_id cookie in the request for 1/cert, getting it from
LeapHttpClient directly.
|
|
|
|
I still let one method to bypass hostname verifier, otherwise dev.bm
will not work.
I've reduced downloading functions to 3: download without CA, download
with commercial CA and download with provider CA.
I only download CA cert once, when the user selects the corresponding
provider. Each time a user switch provider, the cert is downloaded
(along with other json files).
|
|
|
|
|
|
|
|
develop
|
|
into develop
|
|
|
|
|
|
We were checking if eip existed before adding it again, but that check
can be removed if we make a replace instead of an add.
|
|
Added a new catch block in all downloads methods.
|
|
|
|
We no longer use BundleExtras named as the action ProviderAPI is
intended to perform, but we standardise this name
(ProviderAPI.PARAMETERS), and use setAction to pass that action string.
|
|
New login dialog shows the original username, so that if the user failed
writing his/her password, s/he does not have to write again the
username.
|
|
Pressing back after entering Dashboard from notification bar, the user
goes back to home.
|
|
This fixes #3287
|
|
|
|
Clean erroneous copyright text (Consulted Arne)
ics-openvpn uses GPLv2+
|
|
If login is successful, dialog is dismissed and toast is showed.
If login is not successful and the user cancels the new login dialog
presented to him/her, then Dashboard is showed.
|
|
If the CA cert was correctly downloaded, we assume it can be used to
validate the string download.
If CA cert cannot validate that connection, then if the trust completely
checkbox was checked it will try with the other methods. If it was not
checked, a certificate error is shown (telling the user the
provider is not trusted).
|
|
Only if all downloading methods fail and the last one throws an
IOException, the certificate error message toast is shown.
|
|
I've also rearranged how we handle SSL errors. In first place, if the
user checked the "Trust completely" checkbox, leap_android tries to use
the CA cert pointed out by provider.json.
If that does not succeed, it uses an always-returning-true hostname
verifier (this was previously done before using CA cert).
|
|
|
|
|
|
|
|
Fixes VPN reconnection when framework rebuilds view, triggering onCheckedChangeListener
|
|
|
|
|
|
Includes AlertDialog if the user attempts to stop EIP while a connection is being established
|
|
|
|
|
|
|
|
|
|
|
|
|
|
If an empty json string is received after sending M1 (that means no M2
in return), bad user/password message is shown.
This fixes bug 3153.
|
|
Login option is not shown if the user is already logged in, and logout
option is not shown if the user is not logged in.
I've also removed a debug line from ProviderDetailFragment, which
returned true when it returned false because of an exception.
|
|
LeapHttpClient can fetch the main CA certificate downloaded from the
provider and add it to its in-memory keystore, without saving the
certificate in a file.
This is a very important feature, I think it can be cherry picked (it has
little modifications, and very localized).
It's very important because authentication does not work without this
bug fix in the latest branches, because I removed the code that saved
the certificate in a file but didn't test the authentication part.
|
|
If a download didn't occurr due to an IOException, we assume it was for
an SSL error and notify the user telling him/her that LEAP provider is
not trusted.
|
|
I've set ProviderAPI to show its own toast depending on the exception
that getStringFromProvider issues. If the socket timeout reaches its
end, a toast different from when an IOException or a MalformedException
occur.
|
|
Feature #3023 first solution.
I don't like to tell anything to the user when s/he wants to exit
pressing the back button. I assume s/he is saying: "Wanna go out!!"
I've implemented the behaviour written in UI Rev II.
If a user selects a new provider when coming back from Switch Provider,
the previous provider is forgotten and we assume s/he wants to change of
provider but he is not sure to which. That means that previous provider
configuration will be removed (that means there is no provider selected
and Dashboard will not be launched before a new provider is selected).
|