Age | Commit message (Collapse) | Author |
|
code guidelines
|
|
|
|
|
|
|
|
This is also an open issue in Transifex: https://www.transifex.com/otf/bitmask-android/translate/#es/$/22692144?issue=yes You should double check if this is correct.
|
|
|
|
|
|
|
|
ics-openvpn is now officially on GitHub, and they track openssl and
openvpn as submodules, so it's easier to update everything. Just a git
submodule update --recursive.
I've also set up soft links to native modules from ics-openvpn in app,
so that we don't copy files in Gradle (which was causing problems with
the submodules .git* files, not being copied). That makes the repo
cleaner.
|
|
Updated butterknife, dagger, renderers, fabbuton and gson, as well as
gradle plugin.
|
|
The FabButton doesn't scale the icon as big as I want it to be, and it
doesn't let me set the size to "wrap_content" because the library sets
the sizes to match_parent.
I'm going to try to modify my fork of FabButton to see if I can obtain
what I want in its demo: just an icon and the progress indicator, the
icon as big as possible.
|
|
|
|
Next step: beautify.
|
|
|
|
Tests click new button, instead of action bar's.
Fixing more bugs...
|
|
I've separated the user session management to it, and encapsulated
ProviderAPICommand into its own class.
Putting the fragment statically in dashboard.xml isn't working, Android
complains about it being duplicated, so I'm going to add it dynamically.
|
|
|
|
Some devices are too small to show everything in the same row, so I'm
centering everything and spliting the layout in two: the label and the
button&icon.
|
|
|
|
|
|
Turn on VPN touching that button, and leave the image as a mere indicator.
|
|
|
|
Tested with physical Galaxy Young S6310.
|
|
I had a difficult moment trying to detect if the LogWindow had already
been shown after an error. Finally, I implemented a LogWindowWrapper
which contains a field for the reason it was shown, so that we can check
if the previous error is the same than the current one leading to the
avoidance of the second LogWindow. For this to work, we need to reset
that reason each time we trigger a new vpn state (i.e. each time the
user taps on the vpn icon).
|
|
|
|
|
|
Next step: a bit of UI design, removing the switch.
|
|
Using AndroidPinning library from Moxie, I make sure the provider.json
file Bitmask downloads is fetched from a pinned https connection, so
that the api certificate fingerprint is the good one.
|
|
String locale = Locale.getDefault().getLanguage() + Locale.getDefault().getCountry();
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Also reindent some code.
|
|
|
|
Copy changes to xlarge layout.
|
|
Switching orientation doesn't hide that information, now we have two
places to avoid it.
|
|
|
|
Now that I fixed the internal inconsistencies of checking if the user is
logged in, if this error happens it should be caused by the provider or
the network itself. So I tell the user.
|
|
|
|
Improved build.gradle script.
|
|
testIsValid depends on the speed of Runtime's exec: sometimes it's quick
and passes (because it changes the date correctly) and sometimes is
not. A waitFor doesn't fix the issue, it waits forever.
|
|
Last refactor, introducing ButterKnife and all those things, I forgot to
update this layouts.
|
|
|
|
Gradle doesn't invoke updateIcsOpenVpn task unless the task is
explicitly invoked. I needed to put all the related tasks into the
configuration phase, rather than on the execution one.
|
|
|
|
|