summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorParménides GV <parmegv@sdf.org>2016-04-03 17:19:04 +0200
committerParménides GV <parmegv@sdf.org>2016-04-03 17:19:04 +0200
commit2daac1d12c4784443a872492b7f29d02c429d19f (patch)
treec2435766b6a8d7ddd70f2a0dcfc501a7d93c45f4
parentc260dff02dcc773320fbdc4e3f89131ec7a1b3fc (diff)
Bitmask does not show the log if an error happens.
ics-openvpn already shows it if necessary. Our heuristic (just looking for an "error" keyword in the past N messages of the log) is very weak, and it returns an annoying false positive: turning off the VPN triggers the show log error.
-rw-r--r--app/src/main/java/se/leap/bitmaskclient/VpnFragment.java5
1 files changed, 1 insertions, 4 deletions
diff --git a/app/src/main/java/se/leap/bitmaskclient/VpnFragment.java b/app/src/main/java/se/leap/bitmaskclient/VpnFragment.java
index 2e3d7524..9210c6ec 100644
--- a/app/src/main/java/se/leap/bitmaskclient/VpnFragment.java
+++ b/app/src/main/java/se/leap/bitmaskclient/VpnFragment.java
@@ -244,10 +244,7 @@ public class VpnFragment extends Fragment implements Observer {
Context context = dashboard.getApplicationContext();
String error = eip_status.lastError(5, context);
- if (!error.isEmpty()) {
- dashboard.showLog();
- VoidVpnService.stop();
- }
+ if (!error.isEmpty()) VoidVpnService.stop();
updateIcon();
updateButton();
}