Removed setDefinition from ConfigParser.

We now directly use the parseConfiguration method, translating the
eip-service.json openvpn options to a string containing the
corresponding openvpn config file lines.

2 files changed, 79 insertions, 110 deletions

diff --git a/app/src/main/java/de/blinkt/openvpn/core/ConfigParser.java b/app/src/main/java/de/blinkt/openvpn/core/ConfigParser.java
index 4fbbe165..5d5b3471 100644
--- a/app/src/main/java/de/blinkt/openvpn/core/ConfigParser.java
+++ b/app/src/main/java/de/blinkt/openvpn/core/ConfigParser.java
@@ -25,14 +25,6 @@ public class ConfigParser {
 
 
 	private boolean extraRemotesAsCustom=false;
-
-    /*
-     * TODO: We shouldn't be using this method. 
-     * We need to figure out how to use just parseConfig, probably removing parseOptions.
-     */
-    public void setDefinition(HashMap<String,Vector<Vector<String>>> args) {
-	options = args;
-    }
     
 	public void parseConfig(Reader reader) throws IOException, ConfigParseError {
 
diff --git a/app/src/main/java/se/leap/bitmaskclient/EIP.java b/app/src/main/java/se/leap/bitmaskclient/EIP.java
index c439d6b7..c340467c 100644
--- a/app/src/main/java/se/leap/bitmaskclient/EIP.java
+++ b/app/src/main/java/se/leap/bitmaskclient/EIP.java
@@ -16,6 +16,8 @@
  */
  package se.leap.bitmaskclient;
 
+import java.io.StringReader;
+import java.io.IOException;
 import java.util.Calendar;
 import java.util.Collection;
 import java.util.HashMap;
@@ -472,7 +474,6 @@ public final class EIP extends IntentService {
 				}
 			}
 			
-			this.parseOptions();
 			this.createVPNProfile();
 			
 			setUniqueProfileName(vpl);
@@ -508,125 +509,101 @@ public final class EIP extends IntentService {
 			}
 		}
 
-		/**
-		 * FIXME This method is really the outline of the refactoring needed in se.leap.openvpn.ConfigParser 
-		 */
-		private void parseOptions(){
-			
-			// FIXME move these to a common API (& version) definition place, like ProviderAPI or ConfigHelper
-			String common_options = "openvpn_configuration";
-			String remote = "ip_address";
-			String ports = "ports";
-			String protos = "protocols";
-			String capabilities = "capabilities";
-			String location_key = "location";
-			String locations = "locations";
-			
-			Vector<String> arg = new Vector<String>();
-			Vector<Vector<String>> args = new Vector<Vector<String>>();
+	    /**
+	     * Parses data from eip-service.json to a section of the openvpn config file
+	     */
+	    private StringReader configFromEipServiceDotJson() {
+		String parsed_configuration = "";
+		    
+		String common_options = "openvpn_configuration";
+		String remote = "ip_address";
+		String ports = "ports";
+		String protos = "protocols";
+		String capabilities = "capabilities";
+		String location_key = "location";
+		String locations = "locations";
+		
+		Vector<String> arg = new Vector<String>();
+		Vector<Vector<String>> args = new Vector<Vector<String>>();
 			
-			try {
-				JSONObject def = (JSONObject) eipDefinition.get(common_options);
-				Iterator keys = def.keys();
-				Vector<Vector<String>> value = new Vector<Vector<String>>();
-				while ( keys.hasNext() ){
-					String key = keys.next().toString();
+		try {
+		    JSONObject openvpn_configuration = eipDefinition.getJSONObject(common_options);
+		    Iterator keys = openvpn_configuration.keys();
+		    Vector<Vector<String>> value = new Vector<Vector<String>>();
+		    while ( keys.hasNext() ){
+			String key = keys.next().toString();
 					
-					arg.add(key);
-					for ( String word : def.getString(key).split(" ") )
-						arg.add(word);
-					value.add( (Vector<String>) arg.clone() );
-					options.put(key, (Vector<Vector<String>>) value.clone());
-					value.clear();
-					arg.clear();
-				}
-			} catch (JSONException e) {
-				// TODO Auto-generated catch block
-				e.printStackTrace();
-			}
-
-            // We are always client, because the ifconfig will be received by a needed command
-            options.put("client", null);
-
-			try {
-				arg.add(remote);
-				arg.add(mGateway.getString(remote));
-			} catch (JSONException e) {
-				// TODO Auto-generated catch block
-				e.printStackTrace();
-			}
-			args.add((Vector<String>) arg.clone());
-			options.put("remote", (Vector<Vector<String>>) args.clone() );
-			arg.clear();
-			args.clear();
-
-
+			parsed_configuration += key + " ";
+			for ( String word : openvpn_configuration.getString(key).split(" ") )
+			    parsed_configuration += word + " ";
+			parsed_configuration += System.getProperty("line.separator");
 			
-			// try {
-			// 	arg.add(location_key);
-			// 	String locationText = "";
-			// 	locationText = eipDefinition.getJSONObject(locations).getJSONObject(mGateway.getString(location_key)).getString("name");		
-			// 	arg.add(locationText);
-			//     Log.d(TAG, "location = " + locationText);
+		    }
+		} catch (JSONException e) {
+		    // TODO Auto-generated catch block
+		    e.printStackTrace();
+		}
 
-			// } catch (JSONException e) {
-			// 	// TODO Auto-generated catch block
-			// 	e.printStackTrace();
-			// }
-			// args.add((Vector<String>) arg.clone());
-			// options.put("location", (Vector<Vector<String>>) args.clone() );
+		parsed_configuration += "client" + System.getProperty("line.separator");
 
-			// arg.clear();
-			// args.clear();
-			JSONArray protocolsJSON = null;
-			arg.add("proto");
-			try {
-				protocolsJSON = mGateway.getJSONObject(capabilities).getJSONArray(protos);
-			} catch (JSONException e) {
-				// TODO Auto-generated catch block
-				e.printStackTrace();
-			}
-			Vector<String> protocols = new Vector<String>();
-			for ( int i=0; i<protocolsJSON.length(); i++ )
-				protocols.add(protocolsJSON.optString(i));
-			if ( protocols.contains("udp"))
-				arg.add("udp");
-			else if ( protocols.contains("tcp"))
-				arg.add("tcp");
-			args.add((Vector<String>) arg.clone());
-			options.put("proto", (Vector<Vector<String>>) args.clone());
-			arg.clear();
-			args.clear();
-			
-			
-			String port = null;
-			arg.add("port");
-			try {
-				port = mGateway.getJSONObject(capabilities).getJSONArray(ports).optString(0);
-			} catch (JSONException e) {
-				// TODO Auto-generated catch block
-				e.printStackTrace();
-			}
-			arg.add(port);
-			args.add((Vector<String>) arg.clone());
-			options.put("port", (Vector<Vector<String>>) args.clone());
-			args.clear();
-			arg.clear();
+		try {		    
+		    JSONArray protocolsJSON = mGateway.getJSONObject(capabilities).getJSONArray(protos);
+		    String remote_line = "remote";
+		    for ( int i=0; i<protocolsJSON.length(); i++ ) {
+			remote_line += " " + mGateway.getString(remote);
+			remote_line += " " + mGateway.getJSONObject(capabilities).getJSONArray(ports).optString(0);
+			remote_line += " " + protocolsJSON.optString(i);
+			if(remote_line.endsWith("udp"))
+			    parsed_configuration = parsed_configuration.replaceFirst(System.getProperty("line.separator") + "remote", System.getProperty("line.separator") + remote_line + System.getProperty("line.separator") + "remote");
+			else
+			    parsed_configuration += remote_line;
+			remote_line = "remote";
+			parsed_configuration += System.getProperty("line.separator");
+		    }
+		} catch (JSONException e) {
+		    // TODO Auto-generated catch block
+		    e.printStackTrace();
 		}
 		
+		// try {
+		// 	arg.add(location_key);
+		// 	String locationText = "";
+		// 	locationText = eipDefinition.getJSONObject(locations).getJSONObject(mGateway.getString(location_key)).getString("name");		
+		// 	arg.add(locationText);
+		//     Log.d(TAG, "location = " + locationText);
+
+		// } catch (JSONException e) {
+		// 	// TODO Auto-generated catch block
+		// 	e.printStackTrace();
+		// }
+		// args.add((Vector<String>) arg.clone());
+		// options.put("location", (Vector<Vector<String>>) args.clone() );
+
+		// arg.clear();
+		// args.clear();
+		
+		Log.d("EIP", "parsed configuration");
+		Log.d("EIP", parsed_configuration);
+		return new StringReader(parsed_configuration.trim());
+	    }
+		
 		/**
 		 * Create and attach the VpnProfile to our gateway object
 		 */
 		protected void createVPNProfile(){
 			try {
 				ConfigParser cp = new ConfigParser();
-				cp.setDefinition(options);
+				cp.parseConfig(configFromEipServiceDotJson());
 				VpnProfile vp = cp.convertProfile();
 				mVpnProfile = vp;
 				Log.v(TAG,"Created VPNProfile");
 			} catch (ConfigParseError e) {
 				// FIXME We didn't get a VpnProfile!  Error handling! and log level
-				Log.v(TAG,"Error createing VPNProfile");
+				Log.v(TAG,"Error creating VPNProfile");
+				e.printStackTrace();
+			} catch (IOException e) {
+				// FIXME We didn't get a VpnProfile!  Error handling! and log level
+				Log.v(TAG,"Error creating VPNProfile");
 				e.printStackTrace();
 			}
 		}