From da761575541809a3a91fad3e469aa3079f435f65 Mon Sep 17 00:00:00 2001 From: "kali kaneko (leap communications)" Date: Thu, 11 Mar 2021 04:37:51 +0100 Subject: [bug] fail gracefully on connection initialization errors There's some corner cases that were very badly captured. On the first place, it's confusing to quit on connection errors. Secondly, a side-effect of aborting the initialization of the bitmask object was a semi-random segfault when trying to access the object. Here I pass any connection errors to the gui, but leave to the user to quit the app. This probably will need more work when we want to terminate the app on unrecoverable errors (no polkit, etc...), but for now it makes the systray much more usable. - Resolves: #465 --- pkg/vpn/openvpn.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'pkg/vpn') diff --git a/pkg/vpn/openvpn.go b/pkg/vpn/openvpn.go index c0ec2e1..d5f9dc2 100644 --- a/pkg/vpn/openvpn.go +++ b/pkg/vpn/openvpn.go @@ -47,7 +47,8 @@ func (b *Bitmask) StartVPN(provider string) error { if !b.CanStartVPN() { return errors.New("BUG: cannot start vpn") } - return b.startOpenVPN(proxy) + err := b.startOpenVPN(proxy) + return err } func (b *Bitmask) CanStartVPN() bool { -- cgit v1.2.3