From 967351425241d00364a3ebd77722206aa17fb95a Mon Sep 17 00:00:00 2001 From: Ruben Pollan Date: Wed, 25 Sep 2019 12:08:07 +0200 Subject: [bug] firewall isup return 1 is not an error bitmask-root firewall isup uses the return code to signal if the firewall is up or not. We should not report it as an error. - Resolves: #179 --- pkg/standalone/launcher_linux.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/standalone/launcher_linux.go b/pkg/standalone/launcher_linux.go index f2d0392..76f74f8 100644 --- a/pkg/standalone/launcher_linux.go +++ b/pkg/standalone/launcher_linux.go @@ -193,13 +193,12 @@ func runBitmaskRoot(arg ...string) error { arg = append([]string{bitmaskRoot}, arg...) out, err := exec.Command("pkexec", arg...).Output() - if err != nil { + if err != nil && arg[2] != "isup" { log.Println("Error while running bitmask-root:") log.Println("args: ", arg) log.Println("output: ", string(out)) - return err } - return nil + return err } func bitmaskRootPath() (string, error) { -- cgit v1.2.3