[bug] fail gracefully on connection initialization errors

There's some corner cases that were very badly captured. On the first
place, it's confusing to quit on connection errors.

Secondly, a side-effect of aborting the initialization of the bitmask
object was a semi-random segfault when trying to access the object.

Here I pass any connection errors to the gui, but leave to the user to
quit the app. This probably will need more work when we want to
terminate the app on unrecoverable errors (no polkit, etc...), but for
now it makes the systray much more usable.

- Resolves: #465

1 files changed, 3 insertions, 1 deletions

diff --git a/pkg/bitmask/init.go b/pkg/bitmask/init.go
index 02ee544..b6b41b4 100644
--- a/pkg/bitmask/init.go
+++ b/pkg/bitmask/init.go
@@ -97,8 +97,10 @@ func InitializeBitmask(conf *config.Config) (Bitmask, error) {
 	if !conf.SkipLaunch {
 		err := maybeStartVPN(b, conf)
 		if err != nil {
+			// we don't want this error to avoid initialization of
+			// the bitmask object. If we cannot autostart it's not
+			// so terrible.
 			log.Println("Error starting VPN: ", err)
-			return nil, err
 		}
 	}
 	return b, nil