From 466ccbafb38cf8fd767ed2b88d93c547a4eca9a2 Mon Sep 17 00:00:00 2001
From: kali <kali@leap.se>
Date: Wed, 3 Apr 2013 03:22:08 +0900
Subject: Do not populate user/pass when deselecting "remember"

Closes: #2059
---
 src/leap/config/leapsettings.py | 20 ++++++++++++++++++++
 src/leap/gui/mainwindow.py      |  5 +++++
 2 files changed, 25 insertions(+)

(limited to 'src')

diff --git a/src/leap/config/leapsettings.py b/src/leap/config/leapsettings.py
index 35c9fef6..19ec4a9a 100644
--- a/src/leap/config/leapsettings.py
+++ b/src/leap/config/leapsettings.py
@@ -64,6 +64,7 @@ class LeapSettings(object):
     USER_KEY = "User"
     AUTOLOGIN_KEY = "AutoLogin"
     PROPERPROVIDER_KEY = "ProperProvider"
+    REMEMBER_KEY = "RememberUserAndPass"
 
     def __init__(self, standalone=False):
         """
@@ -169,6 +170,25 @@ class LeapSettings(object):
         leap_assert(len(user) > 0, "We cannot save an empty user")
         self._settings.setValue(self.USER_KEY, user)
 
+    def get_remember(self):
+        """
+        Returns the value of the remember selection.
+
+        @rtype: bool
+        """
+        return to_bool(self._settings.value(self.REMEMBER_KEY, False))
+
+    def set_remember(self, remember):
+        """
+        Sets wheter the app should remember username and password
+
+        @param remember: True if the app should remember username and
+            password, False otherwise
+        @rtype: bool
+        """
+        leap_assert_type(remember, bool)
+        self._settings.setValue(self.REMEMBER_KEY, remember)
+
     def get_autologin(self):
         """
         Returns True if the app should automatically login, False otherwise
diff --git a/src/leap/gui/mainwindow.py b/src/leap/gui/mainwindow.py
index 863640ef..e5efdbed 100644
--- a/src/leap/gui/mainwindow.py
+++ b/src/leap/gui/mainwindow.py
@@ -225,6 +225,7 @@ class MainWindow(QtGui.QMainWindow):
 
     def _remember_state_changed(self, state):
         self.ui.chkAutoLogin.setEnabled(state == QtCore.Qt.Checked)
+        self._settings.set_remember(bool(state))
 
     def _finish_init(self):
         self.ui.cmbProviders.addItems(self._configured_providers())
@@ -249,6 +250,10 @@ class MainWindow(QtGui.QMainWindow):
             self._wizard = None
             self._settings.set_properprovider(True)
         else:
+            if not self._settings.get_remember():
+                # nothing to do here
+                return
+
             saved_user = self._settings.get_user()
             auto_login = self._settings.get_autologin()
 
-- 
cgit v1.2.3


From a0497a6e1a4ef556e55299c967441e237a5e7bce Mon Sep 17 00:00:00 2001
From: kali <kali@leap.se>
Date: Tue, 9 Apr 2013 20:03:54 +0900
Subject: remove lambdas

---
 src/leap/platform_init/initializers.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

(limited to 'src')

diff --git a/src/leap/platform_init/initializers.py b/src/leap/platform_init/initializers.py
index 3cb19fc6..049d32a2 100644
--- a/src/leap/platform_init/initializers.py
+++ b/src/leap/platform_init/initializers.py
@@ -117,13 +117,14 @@ def _darwin_has_tun_kext():
     """
     # XXX we should be smarter here and use kextstats output.
 
-    has_kext = lambda: os.path.isdir("/System/Library/Extensions/tun.kext")
-    has_startup = lambda: os.path.isdir("/System/Library/StartupItems/tun")
-    has_tun_and_startup = has_kext() and has_startup()
+    has_kext = os.path.isdir("/System/Library/Extensions/tun.kext")
+    has_startup = os.path.isdir("/System/Library/StartupItems/tun")
+    has_tun_and_startup = has_kext and has_startup
     logger.debug('platform initializer check: has tun_and_startup = %s' %
             (has_tun_and_startup,))
     return has_tun_and_startup
 
+
 def DarwinInitializer():
     """
     Raises a dialog in case that the osx tuntap driver has not been found
-- 
cgit v1.2.3


From bcfdc13f5450e3df695c61c44bf637b18386f31a Mon Sep 17 00:00:00 2001
From: kali <kali@leap.se>
Date: Tue, 9 Apr 2013 20:48:29 +0900
Subject: make state switch more readable

---
 src/leap/gui/mainwindow.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'src')

diff --git a/src/leap/gui/mainwindow.py b/src/leap/gui/mainwindow.py
index e5efdbed..3c256bea 100644
--- a/src/leap/gui/mainwindow.py
+++ b/src/leap/gui/mainwindow.py
@@ -224,8 +224,9 @@ class MainWindow(QtGui.QMainWindow):
         self._wizard = None
 
     def _remember_state_changed(self, state):
-        self.ui.chkAutoLogin.setEnabled(state == QtCore.Qt.Checked)
-        self._settings.set_remember(bool(state))
+        enable = True if state == QtCore.Qt.Checked else False
+        self.ui.chkAutoLogin.setEnabled(enable)
+        self._settings.set_remember(enable)
 
     def _finish_init(self):
         self.ui.cmbProviders.addItems(self._configured_providers())
-- 
cgit v1.2.3