From 7f0ff6a52119a423c1539c2122318b767eddf220 Mon Sep 17 00:00:00 2001 From: drebs Date: Sun, 12 Mar 2017 20:08:57 +0100 Subject: [bug] remove offline toggle The offline toggle added a race condition in which the client could end up offline forever. We decided to remove it for now and then decide if soledad client needs to know about network connectivity (check: https://0xacab.org/leap/soledad/issues/8789). --- src/leap/bitmask/mail/imap/service/imap-server.tac | 3 +-- src/leap/bitmask/mail/testing/__init__.py | 3 +-- src/leap/bitmask/mail/testing/common.py | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) (limited to 'src/leap/bitmask/mail') diff --git a/src/leap/bitmask/mail/imap/service/imap-server.tac b/src/leap/bitmask/mail/imap/service/imap-server.tac index a5c390f3..295bdc0f 100644 --- a/src/leap/bitmask/mail/imap/service/imap-server.tac +++ b/src/leap/bitmask/mail/imap/service/imap-server.tac @@ -65,8 +65,7 @@ def initialize_soledad(uuid, email, passwd, secrets, localdb, server_url, - cert_file, - offline=True) + cert_file) return soledad diff --git a/src/leap/bitmask/mail/testing/__init__.py b/src/leap/bitmask/mail/testing/__init__.py index 54aaa87a..2fc4c073 100644 --- a/src/leap/bitmask/mail/testing/__init__.py +++ b/src/leap/bitmask/mail/testing/__init__.py @@ -54,8 +54,7 @@ class KeyManagerWithSoledadTestCase(unittest.TestCase, BaseLeapTest): server_url='', cert_file=None, auth_token=None, - shared_db=defaultMockSharedDB(), - offline=True) + shared_db=defaultMockSharedDB()) self.km = self._key_manager() diff --git a/src/leap/bitmask/mail/testing/common.py b/src/leap/bitmask/mail/testing/common.py index d969deef..3bd7bc91 100644 --- a/src/leap/bitmask/mail/testing/common.py +++ b/src/leap/bitmask/mail/testing/common.py @@ -70,7 +70,6 @@ def _initialize_soledad(email, gnupg_home, tempdir): local_db_path, server_url, cert_file, - offline=True, shared_db=FakeSharedDb()) return soledad -- cgit v1.2.3