summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-11-30[tests] add unit tests for the keymanager token fixKali Kaneko (leap communications)
my goal here is also to start *real* unit tests for the keymanager, that do not need an actual soledad implementation. this should make all the coming tests much faster. I would like to have a common soledad stub that follows the soledad api, but w/o actual disk persistance, and migrate all the bulk of the keymanager tests to these unit tests.
2016-11-30[bug] make srp token changes propagate to nicknym objectKali Kaneko (leap communications)
the token is set when we get the srp token in the keymanager service, but it wasn't been propagated properly to the internal nicknym object that was refactored recently. here I make the setter write the same token to both keymanager itself and the nicknym. some little additional refactors: - move gpg initialization to a helper method in this way it becomes easier to stub the soledad and keymanager components, for testing. - name nicknym token as publicly visible, since i'm accessing it from the keymanager object. - Resolves: #8651
2016-11-22[bug] use the bundled gpg binaryKali Kaneko (leap communications)
the bundle was trying to get the gpg binary from the config folder instead of the bundled binary.
2016-11-22[tests] fix keymanager tests after refactor and mergeZara Gebru
- some pep8 problems - some confusion with old and new code after merging from old keymanager
2016-11-22[tests] fix some refresher tests after the refactorKali Kaneko (leap communications)
disabled some tests that were failing, for some reason the twisted logger doesn't want to be patched? besides, I don't think it's a good idea to rely on log information for tests. what is it really that we were trying to test there?
2016-11-22[refactor] use qualified exceptionsKali Kaneko (leap communications)
2016-11-22[feature] keymanager: background update keysZara Gebru
Port of the original commit: 8f1fe8dd4a54fd2bdda2fc78c339ce9b3d0fc331 by Zara Gebru that introduced updating keys in the background. This was made in the legacy leapcode/keymanager repo, but was lost in the merge to the unified bitmask-dev. Original commit message follows: -------------------------------- - refresh random key in random time - add get key by fingerprint - refactor nicknym methods to own file - tests - note this do not include a check for revoked key, since that need some changes in gnupg - Related: #6089
2016-11-18[refactor] defer_encryption is gone with latest soledadKali Kaneko (leap communications)
2016-11-18[build] use streaming encrypter branch for automatic gitlab bundlesKali Kaneko (leap communications)
this also means that these bundles can only be used against cdev for now, since we need the latest soledad server. i'm using my personal devpi repo because the development mode install breaks the bundles for some reason (namespace probably). latest version uploaded is: leap-soledad-client-0.9.0+58.g0d9e74e which is today's shyba state but rebased on top of the 0.9.0 tag.
2016-11-18[build] verbose artifact nameKali Kaneko (leap communications)
this should affect the name in the download dropdown in Gitlab
2016-11-18[build] expire artifactsKali Kaneko (leap communications)
I think 1 week should be enough so that we don't clutter the machine too much. It probably will give trouble when someone goes on vacation, or if we stall the development of bitmask because we're moving development towards other fronts, but...
2016-11-18[build] add gpg binaryKali Kaneko (leap communications)
just the one shipped with the ubuntu image used by the docker container for now. I have to investigate how to properly use a docker container only for building the gpg binary.
2016-11-18[build] modify bundle name in gitlab CIKali Kaneko (leap communications)
2016-11-18[build] include dbschema in bundleKali Kaneko (leap communications)
2016-11-11[bug] do not always print feedback from start commandKali Kaneko (leap communications)
2016-11-11[bug] return early from bonafide.get_providerKali Kaneko (leap communications)
otherwise, the call from the rest API hangs forever because the authentication has not happened and not all the configs have been downloaded. - Resolves: #8576
2016-11-11[bug] get user parameter in the key commandsKali Kaneko (leap communications)
This has been previously encapsulated in a dict, and the commands were not modified accordingly. I'm adding some very basic test for the KeymanagerService public api contract. - Resolves: #8577
2016-11-11[bug] fix cli autostartKali Kaneko (leap communications)
this reverts the refactoring made at 596f1f8 it seems it is now allowed to call a function that yields from inside as part of an inline deferred.
2016-11-09[feature] serve UI as an hidden serviceKali Kaneko (leap communications)
you need to configure onion = True in the services config. for sure, this is gonna be more interesting when we ship pixelated. but for now I thought it can be handy for testing ui changes: no need to bundle, just use your tor browser :) still need to try to serve imap/smtp over the onion service. kudos to meejah for this super-usable library!
2016-11-09[ci] generate bundle from gitlab runnerKali Kaneko (leap communications)
some hacks needed, it seems pyinstaller is choking again on namespace packages for some reason that is beyond my current comprenhension.
2016-11-08ui: disable account remove button when appropriateelijah
2016-11-08ui: auto-initialize provider when logging in from the greeterelijah
2016-11-08ui: allow removing accountselijah
2016-11-07ui: add initial addressbook panelelijah
2016-11-06[feat] add '-v' optiondrebs
2016-11-06[feat] allow verbose flag when autostartingdrebs
2016-11-06[feat] increase verbosity using command linedrebs
2016-11-06[feat] allow for decreased verbositydrebs
2016-11-06[bug] properly format failure for logging on errbackdrebs
2016-11-06[feat] change update period with environment variabledrebs
2016-11-04[tests] do not mock failuresKali Kaneko (leap communications)
in the variant that was merged, we call a failure method to get the exception, so it's better to test a real failure initialized with an exception. besides, I'm starting to hate mocks.
2016-11-04[docs] add tulio to authorsKali Kaneko (leap communications)
2016-11-04[doc] fix typoTulio Casagrande
2016-11-04[bug] add tests for outgoing serviceTulio Casagrande
This commit originall contained a fix for a wrong variable name that avoided the outgoing service to be launched. This had been fixed in a concurrent mr that got merged before this one. However, this MR contained a couple of tests for the OutgoingService, and I'm merging those tests now.
2016-11-04[tests] remove npm steps from generic build in the CIKali Kaneko (leap communications)
this takes too long. if we want to test the ui npm build, we probably should do it only when we touch anything under ui/*
2016-11-04[bug] extend the list of argsKali Kaneko (leap communications)
otherwise, we were appending a list as the last element of the list.
2016-11-03[tests] _insert_key_docs is a deferredVictor Shyba
Missing yield from _insert_key_docs, which returns a Deferred, was causing tests to fail.
2016-11-03[bug] message can also be a BytesIOVictor Shyba
Twisted 16.5 sends a BytesIO as message, which was unexpected in this types list.
2016-11-03[docs] add a fixme for the scrypt workaroundKali Kaneko (leap communications)
2016-11-03[style] pep8 fixesKali Kaneko (leap communications)
2016-10-21[feat] fallback support for PySideKali Kaneko (leap communications)
basically, I give up trying to compile pyqt5 for python2. not worthy. fortunately, the api changes are minimal so we can support two. the way forward should be Py3. still some bugs with rendering the viewport. trying to help that, I introduced the web inspector, use DEBUG=1 flag to have it visible.
2016-10-21[bug] capture the exception value properlyKali Kaneko (leap communications)
this looks like a careless migration to twisted failures. who knows how long this was like this, this should be covered by tests.
2016-10-21[bug] fix yet another logger syntax errorKali Kaneko (leap communications)
2016-10-21[bug] workaround around scrypt.encrypt() failure in windowsKali Kaneko (leap communications)
scrypt raises a "unable to get salt from /dev/urandom" error when using encrypt method in windows. this is a quick workaround for obfuscating the uuid map, but it needs to be carefully reviewed as per the security implications (i'm using the hostname to salt the key hashing). doing this, I contemplated the possibility that the scrypt encryption we were using could be flawed, since the payloads can be easily guessed. so, take this with a pinch of salt (haha), and let's review it for the future. as always, this was in a rush trying to bring windows support.
2016-10-21[bug] fallback to python-gnupg as a workaroundKali Kaneko (leap communications)
currently windows 7 support is broken with gnupg.
2016-10-21[bug] fail gracefully if cannot find cert fileKali Kaneko (leap communications)
2016-10-21[bug] avoid choking with some failuresKali Kaneko (leap communications)
2016-10-21[bug] avoid passing posix-only args to twistd on windowsKali Kaneko (leap communications)
2016-10-21[feat] add path for windows bundleKali Kaneko (leap communications)
2016-10-21[bug] use tcp endpoint for windowsKali Kaneko (leap communications)