diff options
author | Kali Kaneko (leap communications) <kali@leap.se> | 2017-05-24 01:55:13 +0200 |
---|---|---|
committer | Kali Kaneko (leap communications) <kali@leap.se> | 2017-05-24 14:35:43 +0200 |
commit | 0bba2d84a584396e888d1f4cd0d0011f5137ab8b (patch) | |
tree | 026e0b4dc16689d03899a6d31eeb5a0e49d7ebff /src/leap/bitmask/hooks.py | |
parent | ba2ae87fa16f1f8aa56faa25b8ab1fdd1fd3b7d3 (diff) |
[bug] fix sending mail error from pixelated
- Create the 'Sent folder' ourselves to avoid pixelated hitting a bug in
mailbox creation.
- I believe there's still a problem with bitmask desing for the adaptor
(in get-or-create mailbox). This needs further tests.
- Case manipualation to avoid having a 'Sent' and 'SENT' folder when
Thunderbird and Pixelated write to those.
- Further hacks to monkeypatch the leap-mail-adapter that Pixelated
uses (make them reuse the account instance!). This is getting insane,
I am really looking forward to the fork.
- Duly note our technical debt in the area of Pixelated integration.
Keeping the Pixelated codebase untouched for a long time will
backfire. As far as I've noticed, we have a basic violation of the
assumptions about a single-instance writes and notifications to all
listeners. As commented in the commit, this should go either for a
guarantee that only one account object is created per user (creating
it in the bootstrapping process in bitmask), or for the opposite
direction in which the listeners are communicated in some other way
(zmq events, for instance).
- In any case, it's strongly recommended to deduplicate the Pixelated
libraries as soon as possible and make Pixelated use a better defined
set of Bitmask's public apis.
- Modify the wrapper create methods so that they return the modified
wrapper itself.
- Resolves: #8903, #8904
Diffstat (limited to 'src/leap/bitmask/hooks.py')
0 files changed, 0 insertions, 0 deletions