Merge branch 'feature/generic-wizard' into develop

The generic wizard (big) branch is now stabilised.
A bunch of refactors have gone together with this topic branch:

- client does not have any info included for default service providers.
- user has to run the first-run wizard and manually entry domain for sample provider.
- remove all remains of the older branding strategy for default provider.
- srp registration + authentication are integrated with the signup process.

3 files changed, 11 insertions, 2 deletions

diff --git a/src/leap/base/tests/__init__.py b/src/leap/base/tests/__init__.py
new file mode 100644
index 00000000..e69de29b
--- /dev/null
+++ b/src/leap/base/tests/__init__.py
diff --git a/src/leap/base/tests/test_checks.py b/src/leap/base/tests/test_checks.py
index bec09ce6..8d573b1e 100644
--- a/src/leap/base/tests/test_checks.py
+++ b/src/leap/base/tests/test_checks.py
@@ -40,7 +40,14 @@ class LeapNetworkCheckTest(BaseLeapTest):
 
     def test_checker_should_actually_call_all_tests(self):
         checker = checks.LeapNetworkChecker()
+        mc = Mock()
+        checker.run_all(checker=mc)
+        self.assertTrue(mc.check_internet_connection.called, "not called")
+        self.assertTrue(mc.check_tunnel_default_interface.called, "not called")
+        self.assertTrue(mc.is_internet_up.called, "not called")
 
+        # ping gateway only called if we pass provider_gw
+        checker = checks.LeapNetworkChecker(provider_gw="0.0.0.0")
         mc = Mock()
         checker.run_all(checker=mc)
         self.assertTrue(mc.check_internet_connection.called, "not called")
diff --git a/src/leap/base/tests/test_providers.py b/src/leap/base/tests/test_providers.py
index 8d3b8847..15c4ed58 100644
--- a/src/leap/base/tests/test_providers.py
+++ b/src/leap/base/tests/test_providers.py
@@ -30,7 +30,9 @@ EXPECTED_DEFAULT_CONFIG = {
 
 class TestLeapProviderDefinition(BaseLeapTest):
     def setUp(self):
-        self.definition = providers.LeapProviderDefinition()
+        self.domain = "testprovider.example.org"
+        self.definition = providers.LeapProviderDefinition(
+            domain=self.domain)
         self.definition.save()
         self.definition.load()
         self.config = self.definition.config
@@ -51,7 +53,7 @@ class TestLeapProviderDefinition(BaseLeapTest):
             os.path.join(
                 self.home,
                 '.config', 'leap', 'providers',
-                '%s' % BRANDING.get('provider_domain'),
+                '%s' % self.domain,
                 'provider.json'))
         with self.assertRaises(AttributeError):
             self.definition.slug = 23