in leap.base.checks.check_internet_connection modified the order

in which errors are checked  and improved test coverage.

1 files changed, 16 insertions, 0 deletions

diff --git a/src/leap/base/tests/test_checks.py b/src/leap/base/tests/test_checks.py
index 8d573b1e..272e7053 100644
--- a/src/leap/base/tests/test_checks.py
+++ b/src/leap/base/tests/test_checks.py
@@ -118,6 +118,22 @@ class LeapNetworkCheckTest(BaseLeapTest):
             with self.assertRaises(exceptions.NoInternetConnection):
                 checker.check_internet_connection()
 
+        with patch.object(requests, "get") as mocked_get:
+            mocked_get.side_effect = \
+                    requests.ConnectionError("[Errno 113] No route to host")
+            with self.assertRaises(exceptions.NoInternetConnection):
+                with patch.object(checker, "ping_gateway") as mock_ping:
+                    mock_ping.return_value = True
+                    checker.check_internet_connection()
+
+        with patch.object(requests, "get") as mocked_get:
+            mocked_get.side_effect = \
+                    requests.ConnectionError("[Errno 113] No route to host")
+            with self.assertRaises(exceptions.NoInternetConnection):
+                with patch.object(checker, "ping_gateway") as mock_ping:
+                    mock_ping.side_effect = exceptions.NoConnectionToGateway
+                    checker.check_internet_connection()
+
     @unittest.skipUnless(_uid == 0, "root only")
     def test_ping_gateway(self):
         checker = checks.LeapNetworkChecker()