Merge branch 'develop' of ssh://code.leap.se/leap_client into develop

3 files changed, 84 insertions, 7 deletions

diff --git a/src/leap/base/tests/test_auth.py b/src/leap/base/tests/test_auth.py
new file mode 100644
index 00000000..17b84b52
--- /dev/null
+++ b/src/leap/base/tests/test_auth.py
@@ -0,0 +1,58 @@
+from BaseHTTPServer import BaseHTTPRequestHandler
+import urlparse
+try:
+    import unittest2 as unittest
+except ImportError:
+    import unittest
+
+import requests
+#from mock import Mock
+
+from leap.base import auth
+#from leap.base import exceptions
+from leap.eip.tests.test_checks import NoLogRequestHandler
+from leap.testing.basetest import BaseLeapTest
+from leap.testing.https_server import BaseHTTPSServerTestCase
+
+
+class LeapSRPRegisterTests(BaseHTTPSServerTestCase, BaseLeapTest):
+    __name__ = "leap_srp_register_test"
+    provider = "testprovider.example.org"
+
+    class request_handler(NoLogRequestHandler, BaseHTTPRequestHandler):
+        responses = {
+            '/': ['OK', '']}
+
+        def do_GET(self):
+            path = urlparse.urlparse(self.path)
+            message = '\n'.join(self.responses.get(
+                path.path, None))
+            self.send_response(200)
+            self.end_headers()
+            self.wfile.write(message)
+
+    def setUp(self):
+        pass
+
+    def tearDown(self):
+        pass
+
+    def test_srp_auth_should_implement_check_methods(self):
+        SERVER = "https://localhost:8443"
+        srp_auth = auth.LeapSRPRegister(provider=SERVER, verify=False)
+
+        self.assertTrue(hasattr(srp_auth, "init_session"),
+                        "missing meth")
+        self.assertTrue(hasattr(srp_auth, "get_registration_uri"),
+                        "missing meth")
+        self.assertTrue(hasattr(srp_auth, "register_user"),
+                        "missing meth")
+
+    def test_srp_auth_basic_functionality(self):
+        SERVER = "https://localhost:8443"
+        srp_auth = auth.LeapSRPRegister(provider=SERVER, verify=False)
+
+        self.assertIsInstance(srp_auth.session, requests.sessions.Session)
+        self.assertEqual(
+            srp_auth.get_registration_uri(),
+            "https://localhost:8443/1/users.json")
diff --git a/src/leap/base/tests/test_checks.py b/src/leap/base/tests/test_checks.py
index 8d573b1e..7a694f89 100644
--- a/src/leap/base/tests/test_checks.py
+++ b/src/leap/base/tests/test_checks.py
@@ -118,6 +118,22 @@ class LeapNetworkCheckTest(BaseLeapTest):
             with self.assertRaises(exceptions.NoInternetConnection):
                 checker.check_internet_connection()
 
+        with patch.object(requests, "get") as mocked_get:
+            mocked_get.side_effect = requests.ConnectionError(
+                "[Errno 113] No route to host")
+            with self.assertRaises(exceptions.NoInternetConnection):
+                with patch.object(checker, "ping_gateway") as mock_ping:
+                    mock_ping.return_value = True
+                    checker.check_internet_connection()
+
+        with patch.object(requests, "get") as mocked_get:
+            mocked_get.side_effect = requests.ConnectionError(
+                "[Errno 113] No route to host")
+            with self.assertRaises(exceptions.NoInternetConnection):
+                with patch.object(checker, "ping_gateway") as mock_ping:
+                    mock_ping.side_effect = exceptions.NoConnectionToGateway
+                    checker.check_internet_connection()
+
     @unittest.skipUnless(_uid == 0, "root only")
     def test_ping_gateway(self):
         checker = checks.LeapNetworkChecker()
diff --git a/src/leap/base/tests/test_providers.py b/src/leap/base/tests/test_providers.py
index 15c4ed58..9c11f270 100644
--- a/src/leap/base/tests/test_providers.py
+++ b/src/leap/base/tests/test_providers.py
@@ -8,7 +8,7 @@ import os
 
 import jsonschema
 
-from leap import __branding as BRANDING
+#from leap import __branding as BRANDING
 from leap.testing.basetest import BaseLeapTest
 from leap.base import providers
 
@@ -16,10 +16,12 @@ from leap.base import providers
 EXPECTED_DEFAULT_CONFIG = {
     u"api_version": u"0.1.0",
     u"description": {u'en': u"Test provider"},
-    u"display_name": {u'en': u"Test Provider"},
+    u"default_language": u"en",
+    #u"display_name": {u'en': u"Test Provider"},
     u"domain": u"testprovider.example.org",
+    u'name': {u'en': u'Test Provider'},
     u"enrollment_policy": u"open",
-    u"serial": 1,
+    #u"serial": 1,
     u"services": [
         u"eip"
     ],
@@ -33,8 +35,8 @@ class TestLeapProviderDefinition(BaseLeapTest):
         self.domain = "testprovider.example.org"
         self.definition = providers.LeapProviderDefinition(
             domain=self.domain)
-        self.definition.save()
-        self.definition.load()
+        self.definition.save(force=True)
+        self.definition.load()  # why have to load after save??
         self.config = self.definition.config
 
     def tearDown(self):
@@ -61,7 +63,7 @@ class TestLeapProviderDefinition(BaseLeapTest):
     def test_provider_dump(self):
         # check a good provider definition is dumped to disk
         self.testfile = self.get_tempfile('test.json')
-        self.definition.save(to=self.testfile)
+        self.definition.save(to=self.testfile, force=True)
         deserialized = json.load(open(self.testfile, 'rb'))
         self.maxDiff = None
         self.assertEqual(deserialized, EXPECTED_DEFAULT_CONFIG)
@@ -88,7 +90,8 @@ class TestLeapProviderDefinition(BaseLeapTest):
     def test_provider_validation(self):
         self.definition.validate(self.config)
         _config = copy.deepcopy(self.config)
-        _config['serial'] = 'aaa'
+        # bad type, raise validation error
+        _config['domain'] = 111
         with self.assertRaises(jsonschema.ValidationError):
             self.definition.validate(_config)