summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorkali <kali@leap.se>2013-05-01 04:45:05 +0900
committerkali <kali@leap.se>2013-05-01 04:45:05 +0900
commitfd60462163c6a27bf8a7e394a62f75ccab462fae (patch)
treebcebd3ec774a75fca9930671a86c9860bc2d3a03
parent2370950c7e2d15355daa95a01f20e77786da742e (diff)
remove comment about shell expansion
-rw-r--r--src/leap/platform_init/initializers.py2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/leap/platform_init/initializers.py b/src/leap/platform_init/initializers.py
index 7e184d8a..91c7086b 100644
--- a/src/leap/platform_init/initializers.py
+++ b/src/leap/platform_init/initializers.py
@@ -103,7 +103,6 @@ def WindowsInitializer():
inf_path = os.path.join(driver_path,
"OemWin2k.inf")
cmd = [dev_installer, "install", inf_path, "tap0901"]
- # XXX should avoid shell expansion.
ret = subprocess.call(cmd, stdout=subprocess.PIPE, shell=True)
else:
logger.error("Tried to install TAP driver, but the installer "
@@ -164,7 +163,6 @@ def DarwinInitializer():
if os.path.isdir(installer_path):
cmd = ["open %s" % (installer_path,)]
try:
- # XXX should avoid shell expansion
ret = subprocess.call(
cmd, stdout=subprocess.PIPE,
shell=True)