diff options
| author | Ivan Alejandro <ivanalejandro0@gmail.com> | 2013-09-24 13:01:34 -0300 | 
|---|---|---|
| committer | Ivan Alejandro <ivanalejandro0@gmail.com> | 2013-09-24 13:49:28 -0300 | 
| commit | 924264776e8dab3c17c09a3188ae701edbaf797b (patch) | |
| tree | e2a7c0e372bdad1acb593cb40a412df2a2db0d5b | |
| parent | a073ad8e329a3d90427737ca698e7acaa9d11b8d (diff) | |
Update path comparison for certs.
We need to check if the path *after* the prefix is correct, assuming
that the prefix methods works fine.
| -rw-r--r-- | src/leap/bitmask/config/tests/test_providerconfig.py | 12 | ||||
| -rw-r--r-- | src/leap/bitmask/services/eip/tests/test_eipconfig.py | 12 | 
2 files changed, 8 insertions, 16 deletions
| diff --git a/src/leap/bitmask/config/tests/test_providerconfig.py b/src/leap/bitmask/config/tests/test_providerconfig.py index 7661a1ce..fe27e683 100644 --- a/src/leap/bitmask/config/tests/test_providerconfig.py +++ b/src/leap/bitmask/config/tests/test_providerconfig.py @@ -175,10 +175,9 @@ class ProviderConfigTest(BaseLeapTest):      def test_get_ca_cert_path_as_expected(self):          pc = self._provider_config -        pc.get_path_prefix = Mock(return_value='test')          provider_domain = sample_config['domain'] -        expected_path = os.path.join('test', 'leap', 'providers', +        expected_path = os.path.join('leap', 'providers',                                       provider_domain, 'keys', 'ca',                                       'cacert.pem') @@ -186,24 +185,21 @@ class ProviderConfigTest(BaseLeapTest):          os.path.exists = Mock(return_value=True)          cert_path = pc.get_ca_cert_path() -        self.assertEqual(cert_path, expected_path) +        self.assertTrue(cert_path.endswith(expected_path))      def test_get_ca_cert_path_about_to_download(self):          pc = self._provider_config -        pc.get_path_prefix = Mock(return_value='test')          provider_domain = sample_config['domain'] -        expected_path = os.path.join('test', 'leap', 'providers', +        expected_path = os.path.join('leap', 'providers',                                       provider_domain, 'keys', 'ca',                                       'cacert.pem')          cert_path = pc.get_ca_cert_path(about_to_download=True) - -        self.assertEqual(cert_path, expected_path) +        self.assertTrue(cert_path.endswith(expected_path))      def test_get_ca_cert_path_fails(self):          pc = self._provider_config -        pc.get_path_prefix = Mock(return_value='test')          # mock 'get_domain' so we don't need to load a config          provider_domain = 'test.provider.com' diff --git a/src/leap/bitmask/services/eip/tests/test_eipconfig.py b/src/leap/bitmask/services/eip/tests/test_eipconfig.py index 76305e83..4e340f4c 100644 --- a/src/leap/bitmask/services/eip/tests/test_eipconfig.py +++ b/src/leap/bitmask/services/eip/tests/test_eipconfig.py @@ -262,15 +262,13 @@ class EIPConfigTest(BaseLeapTest):      def test_get_client_cert_path_as_expected(self):          config = self._get_eipconfig() -        config.get_path_prefix = Mock(return_value='test') -          provider_config = ProviderConfig()          # mock 'get_domain' so we don't need to load a config          provider_domain = 'test.provider.com'          provider_config.get_domain = Mock(return_value=provider_domain) -        expected_path = os.path.join('test', 'leap', 'providers', +        expected_path = os.path.join('leap', 'providers',                                       provider_domain, 'keys', 'client',                                       'openvpn.pem') @@ -278,26 +276,24 @@ class EIPConfigTest(BaseLeapTest):          os.path.exists = Mock(return_value=True)          cert_path = config.get_client_cert_path(provider_config) -        self.assertEqual(cert_path, expected_path) +        self.assertTrue(cert_path.endswith(expected_path))      def test_get_client_cert_path_about_to_download(self):          config = self._get_eipconfig() -        config.get_path_prefix = Mock(return_value='test') -          provider_config = ProviderConfig()          # mock 'get_domain' so we don't need to load a config          provider_domain = 'test.provider.com'          provider_config.get_domain = Mock(return_value=provider_domain) -        expected_path = os.path.join('test', 'leap', 'providers', +        expected_path = os.path.join('leap', 'providers',                                       provider_domain, 'keys', 'client',                                       'openvpn.pem')          cert_path = config.get_client_cert_path(              provider_config, about_to_download=True) -        self.assertEqual(cert_path, expected_path) +        self.assertTrue(cert_path.endswith(expected_path))      def test_get_client_cert_path_fails(self):          config = self._get_eipconfig() | 
