diff options
| author | kali <kali@leap.se> | 2013-05-01 04:45:05 +0900 |
|---|---|---|
| committer | kali <kali@leap.se> | 2013-05-11 21:59:58 +0900 |
| commit | c85894efdbd6f65eb2b0c2edfc216827c192c1d1 (patch) | |
| tree | 713ec99763de4b676a11dc19e022f1b7b792afb2 | |
| parent | 544717da3e95a553fa2af8555df6b4e06d9e5af2 (diff) | |
remove comment about shell expansion
| -rw-r--r-- | src/leap/platform_init/initializers.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/leap/platform_init/initializers.py b/src/leap/platform_init/initializers.py index 7e184d8a..91c7086b 100644 --- a/src/leap/platform_init/initializers.py +++ b/src/leap/platform_init/initializers.py @@ -103,7 +103,6 @@ def WindowsInitializer(): inf_path = os.path.join(driver_path, "OemWin2k.inf") cmd = [dev_installer, "install", inf_path, "tap0901"] - # XXX should avoid shell expansion. ret = subprocess.call(cmd, stdout=subprocess.PIPE, shell=True) else: logger.error("Tried to install TAP driver, but the installer " @@ -164,7 +163,6 @@ def DarwinInitializer(): if os.path.isdir(installer_path): cmd = ["open %s" % (installer_path,)] try: - # XXX should avoid shell expansion ret = subprocess.call( cmd, stdout=subprocess.PIPE, shell=True) |