bitmask-dev.git/src, branch api_uri [bitmask-dev] [feat] use bonafide Provider object as a singleton 2017-10-06T16:38:42+00:00 Ruben Pollan meskio@sindominio.net 2017-10-06T09:50:36+00:00 a5cb9c9940b34252da66d43498d705980532f60c There was common situations where two provider instances where running in parallel. And was creating weird errors (like getting wrong api_uri) because the bootstrap deferreds were global but the Provider objects not. I don't like much singletons, but I think now is simpler than before. - Resolves: #9073 
There was common situations where two provider instances where running
in parallel. And was creating weird errors (like getting wrong api_uri)
because the bootstrap deferreds were global but the Provider objects
not.

I don't like much singletons, but I think now is simpler than before.

- Resolves: #9073
[bug] use sytem-wide bitmask-root, if found 2017-10-06T16:32:11+00:00 Kali Kaneko kali@leap.se 2017-10-06T00:30:06+00:00 b66ec16f764be769e4a15dae783292ac4cd32f3b we make a distinction between the system-wide bitmask-root, which should be placed there by the maintainers of whatever packages your distribution uses, and the bitmask-root that is placed by the bundles (using polkit). since the bundles copying over the helper from user-writeable folders is a potential attack vector, we prefer to use the package's version if present. also, if we cannot find either, we abort the launching of the VPN. we've discussed that this might move to the service initialization instead, but I think the cases in which this is needed should be rare. I fix also a corner-case in which we were using getcwd() at import time. if you execute code and then remove the installation path, this will raise a traceback in bitmaskctl. I think it's nicer to catch the error properly when starting. 
we make a distinction between the system-wide bitmask-root, which should
be placed there by the maintainers of whatever packages your
distribution uses, and the bitmask-root that is placed by the bundles
(using polkit).

since the bundles copying over the helper from user-writeable folders
is a potential attack vector, we prefer to use the package's version if
present.

also, if we cannot find either, we abort the launching of the VPN. we've
discussed that this might move to the service initialization instead,
but I think the cases in which this is needed should be rare.

I fix also a corner-case in which we were using getcwd() at import time.
if you execute code and then remove the installation path, this will
raise a traceback in bitmaskctl. I think it's nicer to catch the error
properly when starting.
[feat] Update polkit options 2017-10-03T18:23:01+00:00 Ruben Pollan meskio@sindominio.net 2017-10-02T22:04:52+00:00 b3a36b10232c5aaaf7dddf3dfa1a275945bc6174 






[style] pep8
2017-09-29T18:29:54+00:00

Kali Kaneko
kali@leap.se

2017-09-29T18:29:54+00:00

7b5bb23990acccd435af663e6786fad003f23cd3












[bug] look also from bitmask-root in the debian path
2017-09-29T17:58:28+00:00

Kali Kaneko
kali@leap.se

2017-09-29T17:58:28+00:00

09cbaa0f6a02d9ae769df394939dc5cc6a771548












[bug] fixes needed to launch vpn on mac after refactor
2017-09-29T15:46:24+00:00

kali
kali@leap.se

2017-09-29T15:29:57+00:00

d45338761e3e6774809fd827060928876aa6696c












[bug] check for pkexec only in linux
2017-09-29T15:46:14+00:00

kali
kali@leap.se

2017-09-21T21:30:05+00:00

0f3ee7cfa34546ec5636e1d13a9884e7dce8997a












[bug] workaround for using private parseMbox function
2017-09-29T12:38:46+00:00

Kali Kaneko
kali@leap.se

2017-09-29T01:39:25+00:00

76e60371cd89897dd16dc09e0a84a41f146b044f

we're doing something that shouldn't be done, that is relying on private
methods of the imap server implementation.

until I get to cleanup properly and submit patches for the several things
we're patching in the imap server implementation, keeping up with the
evolution of the imap server implementation is the only thing to do.

specially when we want to get 0.10 out of the door asap.





we're doing something that shouldn't be done, that is relying on private
methods of the imap server implementation.

until I get to cleanup properly and submit patches for the several things
we're patching in the imap server implementation, keeping up with the
evolution of the imap server implementation is the only thing to do.

specially when we want to get 0.10 out of the door asap.







[bug] create /usr/local/sbin folder if it does not exist
2017-09-29T12:00:31+00:00

Kali Kaneko
kali@leap.se

2017-09-29T12:00:31+00:00

461778ae25902d3046f44f8e7634a5ea95431080

- Resolves: #9084





- Resolves: #9084







[bug] fix initialization of default parameter to mutable data structure
2017-09-21T16:16:27+00:00

Kali Kaneko
kali@leap.se

2017-09-21T15:45:25+00:00

a271852b1ba74ddbbf2b1c7cc509615ed8cd0664

whoever wrote this in the first place needs to get introduced to
import-time initialization, even if it was me. one of the nastiest
python gotchas in my opinion :)





whoever wrote this in the first place needs to get introduced to
import-time initialization, even if it was me. one of the nastiest
python gotchas in my opinion :)