<feed xmlns='http://www.w3.org/2005/Atom'>
<title>bitmask-dev.git/src/leap/bitmask/mail/adaptors, branch master</title>
<subtitle>[bitmask-dev] 
</subtitle>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/'/>
<entry>
<title>[bug] Accept any character for message-id</title>
<updated>2018-01-12T12:33:56+00:00</updated>
<author>
<name>Ruben Pollan</name>
<email>meskio@sindominio.net</email>
</author>
<published>2018-01-12T12:33:56+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/commit/?id=45e5fb4e868274c9afc4bc6f47da9acaaa4af940'/>
<id>45e5fb4e868274c9afc4bc6f47da9acaaa4af940</id>
<content type='text'>
- Resolves: #9202
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Resolves: #9202
</pre>
</div>
</content>
</entry>
<entry>
<title>[bug] accept message-ids with '-'</title>
<updated>2017-12-20T14:27:07+00:00</updated>
<author>
<name>Ruben Pollan</name>
<email>meskio@sindominio.net</email>
</author>
<published>2017-12-08T18:27:42+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/commit/?id=caf3e217935faabc6d47672b058e7c8eb0cb5a63'/>
<id>caf3e217935faabc6d47672b058e7c8eb0cb5a63</id>
<content type='text'>
Thunderbird produces message ids with '-' in them.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Thunderbird produces message ids with '-' in them.
</pre>
</div>
</content>
</entry>
<entry>
<title>[refactor] simplify wrapper create and add_msg</title>
<updated>2017-05-24T12:59:50+00:00</updated>
<author>
<name>Kali Kaneko (leap communications)</name>
<email>kali@leap.se</email>
</author>
<published>2017-05-24T12:22:26+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/commit/?id=37b25fd88400df8cc726470b5d897111f2373b96'/>
<id>37b25fd88400df8cc726470b5d897111f2373b96</id>
<content type='text'>
- remove premature optimization for fast-notifies. blobs will cover
that, no point in maintaning the optimization at the price of creeping
complexity.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- remove premature optimization for fast-notifies. blobs will cover
that, no point in maintaning the optimization at the price of creeping
complexity.
</pre>
</div>
</content>
</entry>
<entry>
<title>[bug] fix sending mail error from pixelated</title>
<updated>2017-05-24T12:35:43+00:00</updated>
<author>
<name>Kali Kaneko (leap communications)</name>
<email>kali@leap.se</email>
</author>
<published>2017-05-23T23:55:13+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/commit/?id=0bba2d84a584396e888d1f4cd0d0011f5137ab8b'/>
<id>0bba2d84a584396e888d1f4cd0d0011f5137ab8b</id>
<content type='text'>
- Create the 'Sent folder' ourselves to avoid pixelated hitting a bug in
  mailbox creation.
- I believe there's still a problem with bitmask desing for the adaptor
  (in get-or-create mailbox). This needs further tests.
- Case manipualation to avoid having a 'Sent' and 'SENT' folder when
  Thunderbird and Pixelated write to those.
- Further hacks to monkeypatch the leap-mail-adapter that Pixelated
  uses (make them reuse the account instance!). This is getting insane,
  I am really looking forward to the fork.
- Duly note our technical debt in the area of Pixelated integration.
  Keeping the Pixelated codebase untouched for a long time will
  backfire. As far as I've noticed, we have a basic violation of the
  assumptions about a single-instance writes and notifications to all
  listeners. As commented in the commit, this should go either for a
  guarantee that only one account object is created per user (creating
  it in the bootstrapping process in bitmask), or for the opposite
  direction in which the listeners are communicated in some other way
  (zmq events, for instance).
- In any case, it's strongly recommended to deduplicate the Pixelated
  libraries as soon as possible and make Pixelated use a better defined
  set of Bitmask's public apis.
- Modify the wrapper create methods so that they return the modified
  wrapper itself.

- Resolves: #8903, #8904
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Create the 'Sent folder' ourselves to avoid pixelated hitting a bug in
  mailbox creation.
- I believe there's still a problem with bitmask desing for the adaptor
  (in get-or-create mailbox). This needs further tests.
- Case manipualation to avoid having a 'Sent' and 'SENT' folder when
  Thunderbird and Pixelated write to those.
- Further hacks to monkeypatch the leap-mail-adapter that Pixelated
  uses (make them reuse the account instance!). This is getting insane,
  I am really looking forward to the fork.
- Duly note our technical debt in the area of Pixelated integration.
  Keeping the Pixelated codebase untouched for a long time will
  backfire. As far as I've noticed, we have a basic violation of the
  assumptions about a single-instance writes and notifications to all
  listeners. As commented in the commit, this should go either for a
  guarantee that only one account object is created per user (creating
  it in the bootstrapping process in bitmask), or for the opposite
  direction in which the listeners are communicated in some other way
  (zmq events, for instance).
- In any case, it's strongly recommended to deduplicate the Pixelated
  libraries as soon as possible and make Pixelated use a better defined
  set of Bitmask's public apis.
- Modify the wrapper create methods so that they return the modified
  wrapper itself.

- Resolves: #8903, #8904
</pre>
</div>
</content>
</entry>
<entry>
<title>[bug] fix notification for incoming mail with several listeners registered</title>
<updated>2017-05-16T17:28:35+00:00</updated>
<author>
<name>Kali Kaneko (leap communications)</name>
<email>kali@leap.se</email>
</author>
<published>2017-04-27T13:20:24+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/commit/?id=c980cae46d101c0def23bf3398b65b2e0c614d2a'/>
<id>c980cae46d101c0def23bf3398b65b2e0c614d2a</id>
<content type='text'>
When setting the listeners in the IMAP Folder, we avoid setting more
than one listener for the same imap mailbox (because in some situations
we were registering way too many listeners).

this was making the pixelated inbox registering the notification and
therefore the imap mailbox not being registered.

this MR also refactors the way pixelated is initialized, so that it
avoid creating a second Account instance. In this way, we make sure that
the pixelated mua and the imap server share the same collections for a
given mailbox, and therefore any of the two is able to get a
notification whenever the other adds a message to the mailbox.

- Resolves: #8846, #8798
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When setting the listeners in the IMAP Folder, we avoid setting more
than one listener for the same imap mailbox (because in some situations
we were registering way too many listeners).

this was making the pixelated inbox registering the notification and
therefore the imap mailbox not being registered.

this MR also refactors the way pixelated is initialized, so that it
avoid creating a second Account instance. In this way, we make sure that
the pixelated mua and the imap server share the same collections for a
given mailbox, and therefore any of the two is able to get a
notification whenever the other adds a message to the mailbox.

- Resolves: #8846, #8798
</pre>
</div>
</content>
</entry>
<entry>
<title>[bug] unify logging style using class attr</title>
<updated>2017-04-27T17:33:28+00:00</updated>
<author>
<name>Kali Kaneko (leap communications)</name>
<email>kali@leap.se</email>
</author>
<published>2017-04-25T16:00:12+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/commit/?id=9f95446a55533c8cdceec7c4430be5cad752ecb1'/>
<id>9f95446a55533c8cdceec7c4430be5cad752ecb1</id>
<content type='text'>
I changed most of the logger statements to use a class attribute, in
this way it's easier to identify which class it's logging them.

in some cases I leave a module-level logger, when we're either using
functions or when the module it's too small.

at the same time I did a general review and cleanup of the logging
statements.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I changed most of the logger statements to use a class attribute, in
this way it's easier to identify which class it's logging them.

in some cases I leave a module-level logger, when we're either using
functions or when the module it's too small.

at the same time I did a general review and cleanup of the logging
statements.
</pre>
</div>
</content>
</entry>
<entry>
<title>[bug] catch failures with newer twisted logger</title>
<updated>2017-04-27T17:33:24+00:00</updated>
<author>
<name>Kali Kaneko (leap communications)</name>
<email>kali@leap.se</email>
</author>
<published>2017-04-23T23:06:24+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/commit/?id=47b30db62f339f5143298b3bcb6e2709b5a99926'/>
<id>47b30db62f339f5143298b3bcb6e2709b5a99926</id>
<content type='text'>
the migration from the stdlib python's logger to twisted logger is
unable to format properly the failures unless the call is adapted

- Related: #8849
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
the migration from the stdlib python's logger to twisted logger is
unable to format properly the failures unless the call is adapted

- Related: #8849
</pre>
</div>
</content>
</entry>
<entry>
<title>[bug] Fix warning logging.</title>
<updated>2016-10-19T20:55:50+00:00</updated>
<author>
<name>Denis Costa</name>
<email>deniscostadsc@gmail.com</email>
</author>
<published>2016-10-19T16:46:05+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/commit/?id=4cee83f733238e5ebed6b8083158c6df3ad98f54'/>
<id>4cee83f733238e5ebed6b8083158c6df3ad98f54</id>
<content type='text'>
Following Twisted documentation, I found out that the warning method
doesn't exist on logger class. That class has warn method instead. And I
got a error because of that.

https://twistedmatrix.com/documents/16.4.1/api/twisted.logger.Logger.html
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Following Twisted documentation, I found out that the warning method
doesn't exist on logger class. That class has warn method instead. And I
got a error because of that.

https://twistedmatrix.com/documents/16.4.1/api/twisted.logger.Logger.html
</pre>
</div>
</content>
</entry>
<entry>
<title>[feat] leap.mail: expose content charset as a separated attribute</title>
<updated>2016-10-19T20:48:57+00:00</updated>
<author>
<name>NavaL</name>
<email>ayoyo@thoughtworks.com</email>
</author>
<published>2016-10-19T13:23:17+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/commit/?id=0329b242c851ea1f05e795102638b01bbac7c231'/>
<id>0329b242c851ea1f05e795102638b01bbac7c231</id>
<content type='text'>
Before we used to have content_doc.content_type = 'text/plain;
charset="utf-8"'.
Currently, we have content_doc.content_type = 'text/plain'.

This change will give us, on top of that: content_doc.charset = 'utf-8'.
One can reconstruct the original one using .content_type and .charset.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Before we used to have content_doc.content_type = 'text/plain;
charset="utf-8"'.
Currently, we have content_doc.content_type = 'text/plain'.

This change will give us, on top of that: content_doc.charset = 'utf-8'.
One can reconstruct the original one using .content_type and .charset.
</pre>
</div>
</content>
</entry>
<entry>
<title>[bug] fix error logging calls using twisted logger</title>
<updated>2016-10-10T14:19:11+00:00</updated>
<author>
<name>drebs</name>
<email>drebs@riseup.net</email>
</author>
<published>2016-10-10T13:40:54+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/bitmask-dev.git/commit/?id=7fd29055b61e0e201f1806c8d19dab6a4ce53bdf'/>
<id>7fd29055b61e0e201f1806c8d19dab6a4ce53bdf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
